All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: eguan@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 1/4] xfs/{319,323}: don't checksum files after log recovery
Date: Tue, 29 Aug 2017 21:40:50 -0700	[thread overview]
Message-ID: <150406805060.31349.16766271336969357123.stgit@magnolia> (raw)

From: Darrick J. Wong <darrick.wong@oracle.com>

These two tests simulate log failure during a reflink operation.
However, the contents of the target of the reflink operation depend on
the block size, so we cannot hardcode md5 hashes in this test.  Since
the whole point of the test is to ensure that the the complex chain of
transactions actually finishes no matter where the interruption, it is
sufficient simply to run the usual end-of-test fsck to look for corrupt
metadata.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/319     |    5 -----
 tests/xfs/319.out |    4 ----
 tests/xfs/323     |    4 ----
 tests/xfs/323.out |    3 ---
 4 files changed, 16 deletions(-)


diff --git a/tests/xfs/319 b/tests/xfs/319
index bbe21df..457f181 100755
--- a/tests/xfs/319
+++ b/tests/xfs/319
@@ -82,11 +82,6 @@ touch $SCRATCH_MNT/badfs 2>&1 | _filter_scratch
 echo "Remount to replay log"
 _scratch_inject_logprint >> $seqres.full
 
-echo "Check files"
-md5sum $SCRATCH_MNT/file1 | _filter_scratch
-md5sum $SCRATCH_MNT/file2 | _filter_scratch
-md5sum $SCRATCH_MNT/file3 | _filter_scratch
-
 echo "FS should be online, touch should succeed"
 touch $SCRATCH_MNT/goodfs
 
diff --git a/tests/xfs/319.out b/tests/xfs/319.out
index bccde84..160f5fd 100644
--- a/tests/xfs/319.out
+++ b/tests/xfs/319.out
@@ -11,9 +11,5 @@ XFS_IOC_CLONE_RANGE: Input/output error
 FS should be shut down, touch will fail
 touch: cannot touch 'SCRATCH_MNT/badfs': Input/output error
 Remount to replay log
-Check files
-2a4f043bf9730a9e8882c9264b9797b3  SCRATCH_MNT/file1
-2a4f043bf9730a9e8882c9264b9797b3  SCRATCH_MNT/file2
-2a4f043bf9730a9e8882c9264b9797b3  SCRATCH_MNT/file3
 FS should be online, touch should succeed
 Done
diff --git a/tests/xfs/323 b/tests/xfs/323
index c124f25..18893f2 100755
--- a/tests/xfs/323
+++ b/tests/xfs/323
@@ -80,10 +80,6 @@ touch $SCRATCH_MNT/badfs 2>&1 | _filter_scratch
 echo "Remount to replay log"
 _scratch_inject_logprint >> $seqres.full
 
-echo "Check files"
-md5sum $SCRATCH_MNT/file1 | _filter_scratch
-md5sum $SCRATCH_MNT/file3 | _filter_scratch
-
 echo "FS should be online, touch should succeed"
 touch $SCRATCH_MNT/goodfs
 
diff --git a/tests/xfs/323.out b/tests/xfs/323.out
index be41b7e..99b9688 100644
--- a/tests/xfs/323.out
+++ b/tests/xfs/323.out
@@ -10,8 +10,5 @@ XFS_IOC_CLONE_RANGE: Input/output error
 FS should be shut down, touch will fail
 touch: cannot touch 'SCRATCH_MNT/badfs': Input/output error
 Remount to replay log
-Check files
-2a4f043bf9730a9e8882c9264b9797b3  SCRATCH_MNT/file1
-2a4f043bf9730a9e8882c9264b9797b3  SCRATCH_MNT/file3
 FS should be online, touch should succeed
 Done


             reply	other threads:[~2017-08-30  4:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  4:40 Darrick J. Wong [this message]
2017-08-30  4:40 ` [PATCH 2/4] xfs/013: exit cleaner thread if fsstress dies Darrick J. Wong
2017-08-30  7:51   ` Christoph Hellwig
2017-08-30  4:41 ` [PATCH 3/4] xfs: test rmapbt updates are correct with insert/collapse range Darrick J. Wong
2017-08-30  7:53   ` Christoph Hellwig
2017-08-30 22:58     ` Darrick J. Wong
2017-08-31 10:28   ` Eryu Guan
2017-08-31 14:47   ` [PATCH v2 " Darrick J. Wong
2017-08-30  4:41 ` [PATCH 4/4] generic: try various unicode normalization games Darrick J. Wong
2017-08-30 22:52   ` [PATCH v2 " Darrick J. Wong
2017-08-30 22:31 ` [PATCH 5/4] generic/173: don't dump core when mwrite fails Darrick J. Wong
2017-08-30 22:31 ` [PATCH 6/4] common/rc: fix xfs_io scrub command existence test Darrick J. Wong
2017-08-30 22:32 ` [PATCH 7/4] xfs/122: fix the size of fsop_ag_resblks structure Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150406805060.31349.16766271336969357123.stgit@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.