From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs: test rmapbt updates are correct with insert/collapse range
Date: Thu, 31 Aug 2017 18:28:37 +0800 [thread overview]
Message-ID: <20170831102837.GK27835@eguan.usersys.redhat.com> (raw)
In-Reply-To: <150406806291.31349.16354828502139354709.stgit@magnolia>
On Tue, Aug 29, 2017 at 09:41:02PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Make sure that we update the rmapbt correctly when we collapse-range a
> file and the extents on both sides of the hole can be merged. We can
> construct this pretty trivially with insert-range and write, so test
> that too.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> src/punch-alternating.c | 15 +++++-
> tests/xfs/706 | 127 +++++++++++++++++++++++++++++++++++++++++++++++
> tests/xfs/706.out | 9 +++
> tests/xfs/group | 1
> 4 files changed, 150 insertions(+), 2 deletions(-)
> create mode 100755 tests/xfs/706
> create mode 100644 tests/xfs/706.out
>
>
> diff --git a/src/punch-alternating.c b/src/punch-alternating.c
> index 25228cd..281e283 100644
> --- a/src/punch-alternating.c
> +++ b/src/punch-alternating.c
> @@ -24,6 +24,7 @@ int main(int argc, char *argv[])
> struct stat s;
> struct statfs sf;
> off_t offset;
> + off_t start_offset = 0;
> int fd;
> blksize_t blksz;
> off_t sz;
> @@ -33,11 +34,19 @@ int main(int argc, char *argv[])
> int size = 1; /* punch $SIZE blocks ... */
> int interval = 2; /* every $INTERVAL blocks */
>
> - while ((c = getopt(argc, argv, "i:s:")) != EOF) {
> + while ((c = getopt(argc, argv, "i:o:s:")) != EOF) {
Update usage info too?
Otherwise looks fine to me.
Thanks,
Eryu
next prev parent reply other threads:[~2017-08-31 10:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 4:40 [PATCH 1/4] xfs/{319,323}: don't checksum files after log recovery Darrick J. Wong
2017-08-30 4:40 ` [PATCH 2/4] xfs/013: exit cleaner thread if fsstress dies Darrick J. Wong
2017-08-30 7:51 ` Christoph Hellwig
2017-08-30 4:41 ` [PATCH 3/4] xfs: test rmapbt updates are correct with insert/collapse range Darrick J. Wong
2017-08-30 7:53 ` Christoph Hellwig
2017-08-30 22:58 ` Darrick J. Wong
2017-08-31 10:28 ` Eryu Guan [this message]
2017-08-31 14:47 ` [PATCH v2 " Darrick J. Wong
2017-08-30 4:41 ` [PATCH 4/4] generic: try various unicode normalization games Darrick J. Wong
2017-08-30 22:52 ` [PATCH v2 " Darrick J. Wong
2017-08-30 22:31 ` [PATCH 5/4] generic/173: don't dump core when mwrite fails Darrick J. Wong
2017-08-30 22:31 ` [PATCH 6/4] common/rc: fix xfs_io scrub command existence test Darrick J. Wong
2017-08-30 22:32 ` [PATCH 7/4] xfs/122: fix the size of fsop_ag_resblks structure Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831102837.GK27835@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.