* [U-Boot] [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3
@ 2017-09-04 10:13 Sriram Dash
2017-09-14 21:07 ` York Sun
0 siblings, 1 reply; 3+ messages in thread
From: Sriram Dash @ 2017-09-04 10:13 UTC (permalink / raw)
To: u-boot
Remove dependency of SYS_HAS_SERDES for Layerscape Chasis 3.
Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
---
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 4 ++--
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 2 ++
arch/arm/cpu/armv8/fsl-layerscape/soc.c | 2 ++
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
index cdeef26..355f8bb 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
@@ -58,6 +58,8 @@ config ARCH_LS2080A
select ARM_ERRATA_829520
select ARM_ERRATA_833471
select FSL_LSCH3
+ select SYS_FSL_SRDS_1
+ select SYS_HAS_SERDES
select SYS_FSL_DDR
select SYS_FSL_DDR_LE
select SYS_FSL_DDR_VER_50
@@ -93,8 +95,6 @@ config FSL_LSCH2
config FSL_LSCH3
bool
- select SYS_FSL_SRDS_1
- select SYS_HAS_SERDES
config FSL_MC_ENET
bool "Management Complex network"
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
index c6fede3..3ce2ffc 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
@@ -12,7 +12,9 @@
#include <asm/system.h>
#include <asm/armv8/mmu.h>
#include <asm/io.h>
+#ifdef CONFIG_SYS_HAS_SERDES
#include <asm/arch/fsl_serdes.h>
+#endif
#include <asm/arch/soc.h>
#include <asm/arch/cpu.h>
#include <asm/arch/speed.h>
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
index 639e9d2..72acb45 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
@@ -8,7 +8,9 @@
#include <fsl_ifc.h>
#include <ahci.h>
#include <scsi.h>
+#ifdef CONFIG_SYS_HAS_SERDES
#include <asm/arch/fsl_serdes.h>
+#endif
#include <asm/arch/soc.h>
#include <asm/io.h>
#include <asm/global_data.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3
2017-09-04 10:13 [U-Boot] [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3 Sriram Dash
@ 2017-09-14 21:07 ` York Sun
2017-09-15 4:51 ` Sriram Dash
0 siblings, 1 reply; 3+ messages in thread
From: York Sun @ 2017-09-14 21:07 UTC (permalink / raw)
To: u-boot
On 09/04/2017 03:14 AM, Sriram Dash wrote:
> Remove dependency of SYS_HAS_SERDES for Layerscape Chasis 3.
>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> ---
> arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 4 ++--
> arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 2 ++
> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 2 ++
> 3 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> index cdeef26..355f8bb 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> @@ -58,6 +58,8 @@ config ARCH_LS2080A
> select ARM_ERRATA_829520
> select ARM_ERRATA_833471
> select FSL_LSCH3
> + select SYS_FSL_SRDS_1
> + select SYS_HAS_SERDES
> select SYS_FSL_DDR
> select SYS_FSL_DDR_LE
> select SYS_FSL_DDR_VER_50
> @@ -93,8 +95,6 @@ config FSL_LSCH2
>
> config FSL_LSCH3
> bool
> - select SYS_FSL_SRDS_1
> - select SYS_HAS_SERDES
>
> config FSL_MC_ENET
> bool "Management Complex network"
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> index c6fede3..3ce2ffc 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> @@ -12,7 +12,9 @@
> #include <asm/system.h>
> #include <asm/armv8/mmu.h>
> #include <asm/io.h>
> +#ifdef CONFIG_SYS_HAS_SERDES
> #include <asm/arch/fsl_serdes.h>
> +#endif
Do not use ifdef here. Instead, fix fsl_serdes.h for proper include.
CONFIG_SYS_HAS_SERDES is already being check there. You can adjust it if
needed.
York
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3
2017-09-14 21:07 ` York Sun
@ 2017-09-15 4:51 ` Sriram Dash
0 siblings, 0 replies; 3+ messages in thread
From: Sriram Dash @ 2017-09-15 4:51 UTC (permalink / raw)
To: u-boot
>From: York Sun
>Subject: Re: [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3
>
>On 09/04/2017 03:14 AM, Sriram Dash wrote:
>> Remove dependency of SYS_HAS_SERDES for Layerscape Chasis 3.
>>
>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>> ---
>> arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 4 ++--
>> arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 2 ++
>> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 2 ++
>> 3 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> index cdeef26..355f8bb 100644
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> @@ -58,6 +58,8 @@ config ARCH_LS2080A
>> select ARM_ERRATA_829520
>> select ARM_ERRATA_833471
>> select FSL_LSCH3
>> + select SYS_FSL_SRDS_1
>> + select SYS_HAS_SERDES
>> select SYS_FSL_DDR
>> select SYS_FSL_DDR_LE
>> select SYS_FSL_DDR_VER_50
>> @@ -93,8 +95,6 @@ config FSL_LSCH2
>>
>> config FSL_LSCH3
>> bool
>> - select SYS_FSL_SRDS_1
>> - select SYS_HAS_SERDES
>>
>> config FSL_MC_ENET
>> bool "Management Complex network"
>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>> b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>> index c6fede3..3ce2ffc 100644
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>> @@ -12,7 +12,9 @@
>> #include <asm/system.h>
>> #include <asm/armv8/mmu.h>
>> #include <asm/io.h>
>> +#ifdef CONFIG_SYS_HAS_SERDES
>> #include <asm/arch/fsl_serdes.h>
>> +#endif
>
>Do not use ifdef here. Instead, fix fsl_serdes.h for proper include.
>CONFIG_SYS_HAS_SERDES is already being check there. You can adjust it if needed.
>
Sure. This will be better. I will make necessary changes in the next rev.
>York
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-15 4:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-04 10:13 [U-Boot] [PATCH] armv8: Remove dependency of SERDES for LS CHASIS3 Sriram Dash
2017-09-14 21:07 ` York Sun
2017-09-15 4:51 ` Sriram Dash
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.