* [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
@ 2017-08-23 12:24 Hemant Agrawal
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Hemant Agrawal @ 2017-08-23 12:24 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pablo.de.lara.guarch, akhil.goyal
errno should be initialized to 0 before calling strtol
Fixes: 1df9c0109f4c ("examples/l2fwd-crypto: parse key parameters")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
examples/l2fwd-crypto/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index f020be3..17673a3 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1088,6 +1088,7 @@ parse_key(uint8_t *data, char *input_arg)
unsigned byte_count;
char *token;
+ errno = 0;
for (byte_count = 0, token = strtok(input_arg, ":");
(byte_count < MAX_KEY_SIZE) && (token != NULL);
token = strtok(NULL, ":")) {
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] app/crypto-perf: fix uninitialized errno value
2017-08-23 12:24 [PATCH] examples/l2fwd-crypto: fix uninitialized errno value Hemant Agrawal
@ 2017-08-23 12:24 ` Hemant Agrawal
2017-09-04 14:54 ` Rybalchenko, Kirill
` (2 more replies)
2017-09-04 14:53 ` [PATCH] examples/l2fwd-crypto: " De Lara Guarch, Pablo
` (2 subsequent siblings)
3 siblings, 3 replies; 10+ messages in thread
From: Hemant Agrawal @ 2017-08-23 12:24 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pablo.de.lara.guarch, akhil.goyal
errno should be initialized to 0 before calling strtol
Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
app/test-crypto-perf/cperf_options_parsing.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 085aa8f..77c405c 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)
if (copy_arg == NULL)
return -1;
+ errno = 0;
token = strtok(copy_arg, ":");
/* Parse minimum value */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] app/crypto-perf: fix uninitialized errno value
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
@ 2017-09-04 14:54 ` Rybalchenko, Kirill
2017-09-04 14:56 ` De Lara Guarch, Pablo
2017-09-05 6:17 ` [PATCH v2] " Hemant Agrawal
2 siblings, 0 replies; 10+ messages in thread
From: Rybalchenko, Kirill @ 2017-09-04 14:54 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, De Lara Guarch, Pablo, akhil.goyal
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Wednesday 23 August 2017 13:24
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix uninitialized errno value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
> Cc: stable@dpdk.org
>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] app/crypto-perf: fix uninitialized errno value
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
2017-09-04 14:54 ` Rybalchenko, Kirill
@ 2017-09-04 14:56 ` De Lara Guarch, Pablo
2017-09-05 6:03 ` Hemant Agrawal
2017-09-05 6:17 ` [PATCH v2] " Hemant Agrawal
2 siblings, 1 reply; 10+ messages in thread
From: De Lara Guarch, Pablo @ 2017-09-04 14:56 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, akhil.goyal
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, August 23, 2017 1:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] app/crypto-perf: fix uninitialized errno value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> app/test-crypto-perf/cperf_options_parsing.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-
> perf/cperf_options_parsing.c
> index 085aa8f..77c405c 100644
> --- a/app/test-crypto-perf/cperf_options_parsing.c
> +++ b/app/test-crypto-perf/cperf_options_parsing.c
> @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min,
> uint32_t *max, uint32_t *inc)
> if (copy_arg == NULL)
> return -1;
>
> + errno = 0;
> token = strtok(copy_arg, ":");
>
> /* Parse minimum value */
> --
> 2.7.4
Could you extend this fix to the parse_list function?
Thanks!
Pablo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] app/crypto-perf: fix uninitialized errno value
2017-09-04 14:56 ` De Lara Guarch, Pablo
@ 2017-09-05 6:03 ` Hemant Agrawal
0 siblings, 0 replies; 10+ messages in thread
From: Hemant Agrawal @ 2017-09-05 6:03 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: Doherty, Declan, akhil.goyal
On 9/4/2017 8:26 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
>> Sent: Wednesday, August 23, 2017 1:24 PM
>> To: dev@dpdk.org
>> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
>> Subject: [PATCH] app/crypto-perf: fix uninitialized errno value
>>
>> errno should be initialized to 0 before calling strtol
>>
>> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>> app/test-crypto-perf/cperf_options_parsing.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-
>> perf/cperf_options_parsing.c
>> index 085aa8f..77c405c 100644
>> --- a/app/test-crypto-perf/cperf_options_parsing.c
>> +++ b/app/test-crypto-perf/cperf_options_parsing.c
>> @@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min,
>> uint32_t *max, uint32_t *inc)
>> if (copy_arg == NULL)
>> return -1;
>>
>> + errno = 0;
>> token = strtok(copy_arg, ":");
>>
>> /* Parse minimum value */
>> --
>> 2.7.4
>
> Could you extend this fix to the parse_list function?
>
> Thanks!
> Pablo
>
sure.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] app/crypto-perf: fix uninitialized errno value
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
2017-09-04 14:54 ` Rybalchenko, Kirill
2017-09-04 14:56 ` De Lara Guarch, Pablo
@ 2017-09-05 6:17 ` Hemant Agrawal
2017-09-05 11:25 ` De Lara Guarch, Pablo
2 siblings, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2017-09-05 6:17 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, pablo.de.lara.guarch, akhil.goyal
errno should be initialized to 0 before calling strtol
Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
app/test-crypto-perf/cperf_options_parsing.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 085aa8f..663f53f 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -137,6 +137,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)
if (copy_arg == NULL)
return -1;
+ errno = 0;
token = strtok(copy_arg, ":");
/* Parse minimum value */
@@ -203,6 +204,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, uint32_t *max)
if (copy_arg == NULL)
return -1;
+ errno = 0;
token = strtok(copy_arg, ",");
/* Parse first value */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2] app/crypto-perf: fix uninitialized errno value
2017-09-05 6:17 ` [PATCH v2] " Hemant Agrawal
@ 2017-09-05 11:25 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 10+ messages in thread
From: De Lara Guarch, Pablo @ 2017-09-05 11:25 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, akhil.goyal
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Tuesday, September 5, 2017 7:17 AM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [dpdk-dev] [PATCH v2] app/crypto-perf: fix uninitialized errno value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
2017-08-23 12:24 [PATCH] examples/l2fwd-crypto: fix uninitialized errno value Hemant Agrawal
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
@ 2017-09-04 14:53 ` De Lara Guarch, Pablo
2017-09-04 14:53 ` Rybalchenko, Kirill
2017-09-05 11:25 ` De Lara Guarch, Pablo
3 siblings, 0 replies; 10+ messages in thread
From: De Lara Guarch, Pablo @ 2017-09-04 14:53 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, akhil.goyal
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, August 23, 2017 1:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: 1df9c0109f4c ("examples/l2fwd-crypto: parse key parameters")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
2017-08-23 12:24 [PATCH] examples/l2fwd-crypto: fix uninitialized errno value Hemant Agrawal
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
2017-09-04 14:53 ` [PATCH] examples/l2fwd-crypto: " De Lara Guarch, Pablo
@ 2017-09-04 14:53 ` Rybalchenko, Kirill
2017-09-05 11:25 ` De Lara Guarch, Pablo
3 siblings, 0 replies; 10+ messages in thread
From: Rybalchenko, Kirill @ 2017-09-04 14:53 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, De Lara Guarch, Pablo, akhil.goyal
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Wednesday 23 August 2017 13:24
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix uninitialized errno
> value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: 1df9c0109f4c ("examples/l2fwd-crypto: parse key parameters")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> examples/l2fwd-crypto/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
2017-08-23 12:24 [PATCH] examples/l2fwd-crypto: fix uninitialized errno value Hemant Agrawal
` (2 preceding siblings ...)
2017-09-04 14:53 ` Rybalchenko, Kirill
@ 2017-09-05 11:25 ` De Lara Guarch, Pablo
3 siblings, 0 replies; 10+ messages in thread
From: De Lara Guarch, Pablo @ 2017-09-05 11:25 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: Doherty, Declan, akhil.goyal
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, August 23, 2017 1:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] examples/l2fwd-crypto: fix uninitialized errno value
>
> errno should be initialized to 0 before calling strtol
>
> Fixes: 1df9c0109f4c ("examples/l2fwd-crypto: parse key parameters")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-09-05 11:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-23 12:24 [PATCH] examples/l2fwd-crypto: fix uninitialized errno value Hemant Agrawal
2017-08-23 12:24 ` [PATCH] app/crypto-perf: " Hemant Agrawal
2017-09-04 14:54 ` Rybalchenko, Kirill
2017-09-04 14:56 ` De Lara Guarch, Pablo
2017-09-05 6:03 ` Hemant Agrawal
2017-09-05 6:17 ` [PATCH v2] " Hemant Agrawal
2017-09-05 11:25 ` De Lara Guarch, Pablo
2017-09-04 14:53 ` [PATCH] examples/l2fwd-crypto: " De Lara Guarch, Pablo
2017-09-04 14:53 ` Rybalchenko, Kirill
2017-09-05 11:25 ` De Lara Guarch, Pablo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.