From: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org, johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Subject: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT Date: Tue, 5 Sep 2017 20:58:43 +0200 [thread overview] Message-ID: <1504637923-21652-3-git-send-email-loic.poulain@linaro.org> (raw) In-Reply-To: <1504637923-21652-1-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Retrieve BD address from the DT local-bd-address property. This address must be unique and is usually added in the DT by the bootloader which has access to the provisioned data. Signed-off-by: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> --- v2: Set device as unconfigured if default address detected Add warning if BD addr retrieved from DT v3: if no addr retrieved from DT, unconditionally set the invalid BD addr flag. swap and set bdaddr in the platform probe v4: Add dt-bindings documentation split patch in two parts (setup, dt prop) use local-bd-address name instead of local-mac-address v5: remove 2/3 merged in bluetooth-next tree Add bluetooth.txt for common BT bindings expect local-bd-address in little-endian format drivers/bluetooth/btqcomsmd.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index bd810d0..c6d3fd9 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -15,6 +15,8 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/rpmsg.h> +#include <linux/of.h> + #include <linux/soc/qcom/wcnss_ctrl.h> #include <linux/platform_device.h> @@ -135,6 +137,7 @@ static int btqcomsmd_setup(struct hci_dev *hdev) static int btqcomsmd_probe(struct platform_device *pdev) { + const bdaddr_t *bdaddr; struct btqcomsmd *btq; struct hci_dev *hdev; void *wcnss; @@ -156,6 +159,15 @@ static int btqcomsmd_probe(struct platform_device *pdev) if (IS_ERR(btq->cmd_channel)) return PTR_ERR(btq->cmd_channel); + /* The local-bd-address DT property is usually injected by the + * bootloader which has access to the allocated BD address. + */ + bdaddr = of_get_property(pdev->dev.of_node, "local-bd-address", &ret); + if (bdaddr && ret == sizeof(bdaddr_t)) { + BT_INFO("BD address %pMR retrieved from device-tree", bdaddr); + bacpy(&btq->bdaddr, bdaddr); + } + hdev = hci_alloc_dev(); if (!hdev) return -ENOMEM; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Loic Poulain <loic.poulain@linaro.org> To: marcel@holtmann.org, johan.hedberg@gmail.com, robh+dt@kernel.org Cc: linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, bjorn.andersson@linaro.org, Loic Poulain <loic.poulain@linaro.org> Subject: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT Date: Tue, 5 Sep 2017 20:58:43 +0200 [thread overview] Message-ID: <1504637923-21652-3-git-send-email-loic.poulain@linaro.org> (raw) In-Reply-To: <1504637923-21652-1-git-send-email-loic.poulain@linaro.org> Retrieve BD address from the DT local-bd-address property. This address must be unique and is usually added in the DT by the bootloader which has access to the provisioned data. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- v2: Set device as unconfigured if default address detected Add warning if BD addr retrieved from DT v3: if no addr retrieved from DT, unconditionally set the invalid BD addr flag. swap and set bdaddr in the platform probe v4: Add dt-bindings documentation split patch in two parts (setup, dt prop) use local-bd-address name instead of local-mac-address v5: remove 2/3 merged in bluetooth-next tree Add bluetooth.txt for common BT bindings expect local-bd-address in little-endian format drivers/bluetooth/btqcomsmd.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index bd810d0..c6d3fd9 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -15,6 +15,8 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/rpmsg.h> +#include <linux/of.h> + #include <linux/soc/qcom/wcnss_ctrl.h> #include <linux/platform_device.h> @@ -135,6 +137,7 @@ static int btqcomsmd_setup(struct hci_dev *hdev) static int btqcomsmd_probe(struct platform_device *pdev) { + const bdaddr_t *bdaddr; struct btqcomsmd *btq; struct hci_dev *hdev; void *wcnss; @@ -156,6 +159,15 @@ static int btqcomsmd_probe(struct platform_device *pdev) if (IS_ERR(btq->cmd_channel)) return PTR_ERR(btq->cmd_channel); + /* The local-bd-address DT property is usually injected by the + * bootloader which has access to the allocated BD address. + */ + bdaddr = of_get_property(pdev->dev.of_node, "local-bd-address", &ret); + if (bdaddr && ret == sizeof(bdaddr_t)) { + BT_INFO("BD address %pMR retrieved from device-tree", bdaddr); + bacpy(&btq->bdaddr, bdaddr); + } + hdev = hci_alloc_dev(); if (!hdev) return -ENOMEM; -- 1.9.1
next prev parent reply other threads:[~2017-09-05 18:58 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-05 18:58 [PATCH v5 1/3] DT: net: document Bluetooth bindings in one place Loic Poulain 2017-09-05 18:58 ` Loic Poulain 2017-09-05 18:58 ` [PATCH v5 2/3] dt-bindings: soc: qcom: Add local-bd-address property to WCNSS-BT Loic Poulain 2017-09-13 16:21 ` Rob Herring [not found] ` <1504637923-21652-1-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-09-05 18:58 ` Loic Poulain [this message] 2017-09-05 18:58 ` [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT Loic Poulain [not found] ` <1504637923-21652-3-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-09-05 21:47 ` Rob Herring 2017-09-05 21:47 ` Rob Herring [not found] ` <CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-09-06 7:04 ` Marcel Holtmann 2017-09-06 7:04 ` Marcel Holtmann [not found] ` <46A7D7AE-FDBB-424D-8E85-7180FEE24A14-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2017-09-07 15:50 ` Rob Herring 2017-09-07 15:50 ` Rob Herring 2017-09-13 16:21 ` [PATCH v5 1/3] DT: net: document Bluetooth bindings in one place Rob Herring 2017-09-13 16:21 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1504637923-21652-3-git-send-email-loic.poulain@linaro.org \ --to=loic.poulain-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \ --cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.