All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	yong mao <yong.mao@mediatek.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Phong LE <ple@baylibre.com>, <linux-mmc@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Subject: [PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173
Date: Tue, 12 Sep 2017 17:07:44 +0800	[thread overview]
Message-ID: <1505207272-16983-5-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com>

the origin design of hs400_tune_response is for mt8173 because of
mt8173 has a special design. for doing that, we add a new member
"compatible", by now it's only for mt8173.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 643c795..e8f8ad9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -317,6 +317,7 @@ struct msdc_delay_phase {
 struct msdc_host {
 	struct device *dev;
 	const struct mtk_mmc_compatible *dev_comp;
+	const char *compatible;
 	struct mmc_host *mmc;	/* mmc structure */
 	int cmd_rsp;
 
@@ -666,7 +667,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
 		       host->base + PAD_CMD_TUNE);
 	}
 
-	if (timing == MMC_TIMING_MMC_HS400)
+	if (timing == MMC_TIMING_MMC_HS400 &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		sdr_set_field(host->base + PAD_CMD_TUNE,
 			      MSDC_PAD_TUNE_CMDRRDLY,
 			      host->hs400_cmd_int_delay);
@@ -1594,7 +1596,8 @@ static int msdc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 	struct msdc_host *host = mmc_priv(mmc);
 	int ret;
 
-	if (host->hs400_mode)
+	if (host->hs400_mode &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		ret = hs400_tune_response(mmc, opcode);
 	else
 		ret = msdc_tune_response(mmc, opcode);
@@ -1745,6 +1748,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->dev = &pdev->dev;
 	host->dev_comp = of_id->data;
+	host->compatible = of_id->compatible;
 	host->mmc = mmc;
 	host->src_clk_freq = clk_get_rate(host->src_clk);
 	/* Set host parameters to mmc */
-- 
1.8.1.1.dirty

WARNING: multiple messages have this Message-ID (diff)
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	Catalin Marinas <catalin.marinas@arm.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, yong mao <yong.mao@mediatek.com>,
	Phong LE <ple@baylibre.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mmc@vger.kernel.org,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173
Date: Tue, 12 Sep 2017 17:07:44 +0800	[thread overview]
Message-ID: <1505207272-16983-5-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com>

the origin design of hs400_tune_response is for mt8173 because of
mt8173 has a special design. for doing that, we add a new member
"compatible", by now it's only for mt8173.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 643c795..e8f8ad9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -317,6 +317,7 @@ struct msdc_delay_phase {
 struct msdc_host {
 	struct device *dev;
 	const struct mtk_mmc_compatible *dev_comp;
+	const char *compatible;
 	struct mmc_host *mmc;	/* mmc structure */
 	int cmd_rsp;
 
@@ -666,7 +667,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
 		       host->base + PAD_CMD_TUNE);
 	}
 
-	if (timing == MMC_TIMING_MMC_HS400)
+	if (timing == MMC_TIMING_MMC_HS400 &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		sdr_set_field(host->base + PAD_CMD_TUNE,
 			      MSDC_PAD_TUNE_CMDRRDLY,
 			      host->hs400_cmd_int_delay);
@@ -1594,7 +1596,8 @@ static int msdc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 	struct msdc_host *host = mmc_priv(mmc);
 	int ret;
 
-	if (host->hs400_mode)
+	if (host->hs400_mode &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		ret = hs400_tune_response(mmc, opcode);
 	else
 		ret = msdc_tune_response(mmc, opcode);
@@ -1745,6 +1748,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->dev = &pdev->dev;
 	host->dev_comp = of_id->data;
+	host->compatible = of_id->compatible;
 	host->mmc = mmc;
 	host->src_clk_freq = clk_get_rate(host->src_clk);
 	/* Set host parameters to mmc */
-- 
1.8.1.1.dirty

WARNING: multiple messages have this Message-ID (diff)
From: chaotian.jing@mediatek.com (Chaotian Jing)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173
Date: Tue, 12 Sep 2017 17:07:44 +0800	[thread overview]
Message-ID: <1505207272-16983-5-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1505207272-16983-1-git-send-email-chaotian.jing@mediatek.com>

the origin design of hs400_tune_response is for mt8173 because of
mt8173 has a special design. for doing that, we add a new member
"compatible", by now it's only for mt8173.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 643c795..e8f8ad9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -317,6 +317,7 @@ struct msdc_delay_phase {
 struct msdc_host {
 	struct device *dev;
 	const struct mtk_mmc_compatible *dev_comp;
+	const char *compatible;
 	struct mmc_host *mmc;	/* mmc structure */
 	int cmd_rsp;
 
@@ -666,7 +667,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
 		       host->base + PAD_CMD_TUNE);
 	}
 
-	if (timing == MMC_TIMING_MMC_HS400)
+	if (timing == MMC_TIMING_MMC_HS400 &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		sdr_set_field(host->base + PAD_CMD_TUNE,
 			      MSDC_PAD_TUNE_CMDRRDLY,
 			      host->hs400_cmd_int_delay);
@@ -1594,7 +1596,8 @@ static int msdc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 	struct msdc_host *host = mmc_priv(mmc);
 	int ret;
 
-	if (host->hs400_mode)
+	if (host->hs400_mode &&
+	    !strcmp(host->compatible, "mediatek,mt8173-mmc"))
 		ret = hs400_tune_response(mmc, opcode);
 	else
 		ret = msdc_tune_response(mmc, opcode);
@@ -1745,6 +1748,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->dev = &pdev->dev;
 	host->dev_comp = of_id->data;
+	host->compatible = of_id->compatible;
 	host->mmc = mmc;
 	host->src_clk_freq = clk_get_rate(host->src_clk);
 	/* Set host parameters to mmc */
-- 
1.8.1.1.dirty

  parent reply	other threads:[~2017-09-12  9:12 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12  9:07 mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-09-12  9:07 ` Chaotian Jing
2017-09-12  9:07 ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 01/12] mmc: dt-bindings: update Mediatek MMC bindings Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-13 14:10   ` Rob Herring
2017-09-13 14:10     ` Rob Herring
2017-09-13 14:10     ` Rob Herring
2017-09-14  2:10     ` Chaotian Jing
2017-09-14  2:10       ` Chaotian Jing
2017-09-14  2:10       ` Chaotian Jing
2017-09-21 11:38       ` Linus Walleij
2017-09-21 11:38         ` Linus Walleij
2017-09-21 11:38         ` Linus Walleij
2017-09-26 22:33       ` Ulf Hansson
2017-09-26 22:33         ` Ulf Hansson
2017-09-26 22:33         ` Ulf Hansson
2017-09-27  1:18         ` Chaotian Jing
2017-09-27  1:18           ` Chaotian Jing
2017-09-27  1:18           ` Chaotian Jing
2017-09-29  1:56           ` Chaotian Jing
2017-09-29  1:56             ` Chaotian Jing
2017-09-29  1:56             ` Chaotian Jing
2017-10-02  6:53             ` Ulf Hansson
2017-10-02  6:53               ` Ulf Hansson
2017-10-02  6:53               ` Ulf Hansson
2017-10-09  2:16               ` Chaotian Jing
2017-10-09  2:16                 ` Chaotian Jing
2017-10-09  2:16                 ` Chaotian Jing
2017-10-02 10:49             ` Yingjoe Chen
2017-10-02 10:49               ` Yingjoe Chen
2017-10-02 10:49               ` Yingjoe Chen
2017-09-12  9:07 ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Chaotian Jing
2017-09-12  9:07   ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek, mt8135-mmc" " Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-26 22:37   ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" " Ulf Hansson
2017-09-26 22:37     ` Ulf Hansson
2017-09-26 22:37     ` Ulf Hansson
2017-09-27  1:14     ` Chaotian Jing
2017-09-27  1:14       ` Chaotian Jing
2017-09-27  1:14       ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 03/12] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-26  1:38   ` Chaotian Jing
2017-09-26  1:38     ` Chaotian Jing
2017-09-26  1:38     ` Chaotian Jing
2017-09-12  9:07 ` Chaotian Jing [this message]
2017-09-12  9:07   ` [PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 05/12] mmc: mediatek: add pad_tune0 support Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 06/12] mmc: mediatek: add async fifo and data tune support Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 07/12] mmc: mediatek: add busy_check support Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 08/12] mmc: mediatek: add stop_clk fix and enhance_rx support Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 09/12] mmc: mediatek: add support of source_cg clock Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 10/12] mmc: mediatek: add latch-ck support Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 11/12] mmc: mediatek: improve eMMC hs400 mode read performance Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07 ` [PATCH 12/12] mmc: mediatek: perfer to use rise edge latching for cmd line Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing
2017-09-12  9:07   ` Chaotian Jing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505207272-16983-5-git-send-email-chaotian.jing@mediatek.com \
    --to=chaotian.jing@mediatek.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=javier@osg.samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ple@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=yong.mao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.