All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jon Maloy <jon.maloy@ericsson.com>, Thomas Meyer <thomas@m3y3r.de>
Cc: Ying Xue <ying.xue@windriver.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"tipc-discussion@lists.sourceforge.net" 
	<tipc-discussion@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH V2] tipc: Use bsearch library function
Date: Sun, 17 Sep 2017 14:15:26 -0700	[thread overview]
Message-ID: <1505682926.16316.15.camel@perches.com> (raw)
In-Reply-To: <DB5PR0701MB195892D3D60DAB5D7C1109AE9A620@DB5PR0701MB1958.eurprd07.prod.outlook.com>

On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote:
> > -----Original Message-----
> > From: Thomas Meyer [mailto:thomas@m3y3r.de]
[]
> > What about the other binary search implementation in the same file? Should
> > I try to convert it it will it get NAKed for performance reasons too?
> 
> The searches for inserting and removing publications is less time critical,
> so that would be ok with me.
> If you have any more general interest in improving the code in this file
> (which is needed) it would also be appreciated.

Perhaps using an rbtree would be an improvement.

  reply	other threads:[~2017-09-17 21:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09  3:18 [PATCH] tipc: Use bsearch library function Thomas Meyer
2017-09-11 21:30 ` David Miller
2017-09-12  9:24   ` David Laight
2017-09-12  9:24     ` David Laight
2017-09-16  7:50   ` [PATCH V2] " Thomas Meyer
2017-09-16  9:02     ` Ying Xue
2017-09-16  9:26       ` Joe Perches
2017-09-16  9:36         ` Ying Xue
2017-09-16  9:58           ` Joe Perches
2017-09-16 10:10             ` Ying Xue
2017-09-16 10:17               ` Joe Perches
2017-09-16 13:20                 ` Jon Maloy
2017-09-16 13:20                   ` Jon Maloy
2017-09-17 15:00                   ` Thomas Meyer
2017-09-17 15:00                     ` Thomas Meyer
2017-09-17 16:27                     ` Jon Maloy
2017-09-17 16:27                       ` Jon Maloy
2017-09-17 21:15                       ` Joe Perches [this message]
2017-09-17 21:15                         ` Joe Perches
2017-09-19  1:08                         ` Jon Maloy
2017-09-19  1:08                           ` Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505682926.16316.15.camel@perches.com \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=thomas@m3y3r.de \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.