All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Return the correct score in i915_ppat_get()
@ 2017-09-18 13:36 Zhi Wang
  2017-09-18 15:03 ` Chris Wilson
  0 siblings, 1 reply; 5+ messages in thread
From: Zhi Wang @ 2017-09-18 13:36 UTC (permalink / raw)
  To: intel-gfx, intel-gvt-dev; +Cc: Rodrigo Vivi, Ben Widawsky

The cache attribute of the required entry has to be the same with the
existing value. After this requirement is met, the futher comparison
should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
 	};
 
 	/* Cache attribute has to be matched. */
-	if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+	if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
 		return 0;
 
 	score |= CA_MATCH;
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()
  2017-09-18 13:36 [PATCH] drm/i915: Return the correct score in i915_ppat_get() Zhi Wang
@ 2017-09-18 15:03 ` Chris Wilson
  2017-09-18 15:59   ` Wang, Zhi A
  0 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2017-09-18 15:03 UTC (permalink / raw)
  To: Zhi Wang, intel-gfx, intel-gvt-dev; +Cc: Rodrigo Vivi, Ben Widawsky

Quoting Zhi Wang (2017-09-18 14:36:34)
> The cache attribute of the required entry has to be the same with the
> existing value. After this requirement is met, the futher comparison
> should be performed. After this fix, the refined test case can pass.
> 
> v2:
> 
> - Refine the tittle and comments. (Rodrigo)
> 
> Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

And pushed, thanks for the followup.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()
  2017-09-18 15:03 ` Chris Wilson
@ 2017-09-18 15:59   ` Wang, Zhi A
  0 siblings, 0 replies; 5+ messages in thread
From: Wang, Zhi A @ 2017-09-18 15:59 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx, intel-gvt-dev; +Cc: Widawsky, Benjamin, Vivi, Rodrigo

Sorry for the trouble. :(

-----Original Message-----
From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On Behalf Of Chris Wilson
Sent: Monday, September 18, 2017 6:03 PM
To: Wang, Zhi A <zhi.a.wang@intel.com>; intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org
Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>; joonas.lahtinen@linux.intel.com; Wang, Zhi A <zhi.a.wang@intel.com>; zhenyuw@linux.intel.com; Widawsky, Benjamin <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()

Quoting Zhi Wang (2017-09-18 14:36:34)
> The cache attribute of the required entry has to be the same with the 
> existing value. After this requirement is met, the futher comparison 
> should be performed. After this fix, the refined test case can pass.
> 
> v2:
> 
> - Refine the tittle and comments. (Rodrigo)
> 
> Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

And pushed, thanks for the followup.
-Chris
_______________________________________________
intel-gvt-dev mailing list
intel-gvt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()
  2017-09-21 17:27 ` [PATCH] drm/i915: Return the correct score in i915_ppat_get() Zhi Wang
@ 2017-09-21 17:29   ` Wang, Zhi A
  0 siblings, 0 replies; 5+ messages in thread
From: Wang, Zhi A @ 2017-09-21 17:29 UTC (permalink / raw)
  To: intel-gfx, intel-gvt-dev; +Cc: Widawsky, Benjamin, Vivi, Rodrigo

Please drop this one.

-----Original Message-----
From: Wang, Zhi A 
Sent: Thursday, September 21, 2017 8:27 PM
To: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org
Cc: joonas.lahtinen@linux.intel.com; chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Wang, Zhi A <zhi.a.wang@intel.com>; Widawsky, Benjamin <benjamin.widawsky@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/i915: Return the correct score in i915_ppat_get()

The cache attribute of the required entry has to be the same with the existing value. After this requirement is met, the futher comparison should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
 	};
 
 	/* Cache attribute has to be matched. */
-	if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+	if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
 		return 0;
 
 	score |= CA_MATCH;
--
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/i915: Return the correct score in i915_ppat_get()
  2017-09-21 17:27 [PATCH v18 1/2] drm/i915: Do not allocate unused PPAT entries Zhi Wang
@ 2017-09-21 17:27 ` Zhi Wang
  2017-09-21 17:29   ` Wang, Zhi A
  0 siblings, 1 reply; 5+ messages in thread
From: Zhi Wang @ 2017-09-21 17:27 UTC (permalink / raw)
  To: intel-gfx, intel-gvt-dev; +Cc: Rodrigo Vivi, Ben Widawsky

The cache attribute of the required entry has to be the same with the
existing value. After this requirement is met, the futher comparison
should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
 	};
 
 	/* Cache attribute has to be matched. */
-	if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+	if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
 		return 0;
 
 	score |= CA_MATCH;
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-21 17:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-18 13:36 [PATCH] drm/i915: Return the correct score in i915_ppat_get() Zhi Wang
2017-09-18 15:03 ` Chris Wilson
2017-09-18 15:59   ` Wang, Zhi A
2017-09-21 17:27 [PATCH v18 1/2] drm/i915: Do not allocate unused PPAT entries Zhi Wang
2017-09-21 17:27 ` [PATCH] drm/i915: Return the correct score in i915_ppat_get() Zhi Wang
2017-09-21 17:29   ` Wang, Zhi A

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.