From: <yintang@qti.qualcomm.com> To: <ath10k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org> Subject: [TDLS PATCH V2 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Tue, 19 Sep 2017 10:51:07 +0800 [thread overview] Message-ID: <1505789468-25330-5-git-send-email-yintang@qti.qualcomm.com> (raw) In-Reply-To: <1505789468-25330-1-git-send-email-yintang@qti.qualcomm.com> From: Yingying Tang <yintang@qti.qualcomm.com> TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang <yintang@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 399f9ba..f6702cb 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n", -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: <yintang@qti.qualcomm.com> To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [TDLS PATCH V2 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Tue, 19 Sep 2017 10:51:07 +0800 [thread overview] Message-ID: <1505789468-25330-5-git-send-email-yintang@qti.qualcomm.com> (raw) In-Reply-To: <1505789468-25330-1-git-send-email-yintang@qti.qualcomm.com> From: Yingying Tang <yintang@qti.qualcomm.com> TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang <yintang@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 399f9ba..f6702cb 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n", -- 1.7.9.5 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-09-19 2:50 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <TDLS for ath10k patchset v2> 2017-09-19 2:51 ` [TDLS PATCH V2 0/5] Add TDLS feature for ath10k yintang 2017-09-19 2:51 ` yintang 2017-09-19 2:51 ` [TDLS PATCH V2 1/5] mac80211: Enable TDLS peer buffer STA feature yintang 2017-09-19 2:51 ` yintang 2017-09-19 3:01 ` James Cameron 2017-09-19 3:01 ` James Cameron 2017-09-19 2:51 ` [TDLS PATCH V2 2/5] ath10k: " yintang 2017-09-19 2:51 ` yintang 2017-09-19 2:51 ` [TDLS PATCH V2 3/5] ath10k: Enable TDLS peer inactivity detection yintang 2017-09-19 2:51 ` yintang 2017-09-19 2:51 ` yintang [this message] 2017-09-19 2:51 ` [TDLS PATCH V2 4/5] ath10k: Avoid to set WEP key for TDLS peer yintang 2017-09-19 2:52 ` [TDLS PATCH V2 5/5] " yintang 2017-09-19 2:52 ` yintang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1505789468-25330-5-git-send-email-yintang@qti.qualcomm.com \ --to=yintang@qti.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.