* [PATCH] Bluetooth: 6lowpan: Fix multi-link setup
@ 2017-09-20 9:52 Luiz Augusto von Dentz
2017-09-21 12:19 ` Jukka Rissanen
0 siblings, 1 reply; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2017-09-20 9:52 UTC (permalink / raw)
To: linux-bluetooth; +Cc: jukka.rissanen
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If there are more than one node connected and there isn't any route
information attempt to check if destination address matches any of the
link-local peer addresses.
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 4e2576fc0c59..55370c330386 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -190,7 +190,7 @@ static inline struct lowpan_peer *peer_lookup_dst(struct lowpan_btle_dev *dev,
nexthop = &lowpan_cb(skb)->gw;
if (ipv6_addr_any(nexthop))
- return NULL;
+ nexthop = daddr;
} else {
nexthop = rt6_nexthop(rt, daddr);
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: 6lowpan: Fix multi-link setup
2017-09-20 9:52 [PATCH] Bluetooth: 6lowpan: Fix multi-link setup Luiz Augusto von Dentz
@ 2017-09-21 12:19 ` Jukka Rissanen
0 siblings, 0 replies; 4+ messages in thread
From: Jukka Rissanen @ 2017-09-21 12:19 UTC (permalink / raw)
To: Luiz Augusto von Dentz, linux-bluetooth
Hi Luiz,
On Wed, 2017-09-20 at 12:52 +0300, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If there are more than one node connected and there isn't any route
> information attempt to check if destination address matches any of
> the
> link-local peer addresses.
>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 4e2576fc0c59..55370c330386 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -190,7 +190,7 @@ static inline struct lowpan_peer
> *peer_lookup_dst(struct lowpan_btle_dev *dev,
> nexthop = &lowpan_cb(skb)->gw;
>
> if (ipv6_addr_any(nexthop))
> - return NULL;
> + nexthop = daddr;
> } else {
> nexthop = rt6_nexthop(rt, daddr);
>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cheers,
Jukka
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: 6lowpan: Fix multi-link setup
2017-12-07 18:26 Michael Scott
@ 2017-12-07 18:55 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2017-12-07 18:55 UTC (permalink / raw)
To: Michael Scott; +Cc: Luiz Augusto von Dentz, Jukka Rissanen, linux-bluetooth
Hi Michael,
On Thu, Dec 7, 2017 at 4:26 PM, Michael Scott
<michael@opensourcefoundries.com> wrote:
> Hi Luiz (and linux-bluetooth),
>
> On Wed, 2017-09-20 at 12:52 +0300, Luiz Augusto von Dentz wrote:
>>
>> /From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>> //
>> /If there are more than one node connected and there isn't any route/
>> /information attempt to check if destination address matches any of/
>> /the/
>> /link-local peer addresses./
>> //
>> /Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>> /---/
>> /net/bluetooth/6lowpan.c | 2 +-/
>> /1 file changed, 1 insertion(+), 1 deletion(-)/
>> //
>> /diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c/
>> /index 4e2576fc0c59..55370c330386 100644/
>> /--- a/net/bluetooth/6lowpan.c/
>> /+++ b/net/bluetooth/6lowpan.c/
>> /@@ -190,7 +190,7 @@ static inline struct lowpan_peer/
>> /*peer_lookup_dst(struct lowpan_btle_dev *dev,/
>> /nexthop = &lowpan_cb(skb)->gw;/
>> //
>> /if (ipv6_addr_any(nexthop))/
>> /- return NULL;/
>> /+ nexthop = daddr;/
>> /} else {/
>> /nexthop = rt6_nexthop(rt, daddr);/
>> //
>
>
> Was there any plan to bring this into the longterm 4.14 tree? I saw that
> Jukka ACKed the patch.
>
> Using 4.14, connecting more than 1 node via 6lowpan is completely broken.
> This fairly simple patch restores connectivity for multiple 6lowpan devices.
>
> Question: Are there any hidden downsides to using this patch?
No really, we are just going to deprecated the debugfs interface thus
this got deprioritized, but perhaps we should apply one last fix
before moving on.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: 6lowpan: Fix multi-link setup
@ 2017-12-07 18:26 Michael Scott
2017-12-07 18:55 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 4+ messages in thread
From: Michael Scott @ 2017-12-07 18:26 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: Jukka Rissanen, linux-bluetooth
Hi Luiz (and linux-bluetooth),
On Wed, 2017-09-20 at 12:52 +0300, Luiz Augusto von Dentz wrote:
>/From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>//
>/If there are more than one node connected and there isn't any route/
>/information attempt to check if destination address matches any of/
>/the/
>/link-local peer addresses./
>//
>/Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>/---/
>/net/bluetooth/6lowpan.c | 2 +-/
>/1 file changed, 1 insertion(+), 1 deletion(-)/
>//
>/diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c/
>/index 4e2576fc0c59..55370c330386 100644/
>/--- a/net/bluetooth/6lowpan.c/
>/+++ b/net/bluetooth/6lowpan.c/
>/@@ -190,7 +190,7 @@ static inline struct lowpan_peer/
>/*peer_lookup_dst(struct lowpan_btle_dev *dev,/
>/nexthop = &lowpan_cb(skb)->gw;/
>//
>/if (ipv6_addr_any(nexthop))/
>/- return NULL;/
>/+ nexthop = daddr;/
>/} else {/
>/nexthop = rt6_nexthop(rt, daddr);/
>//
Was there any plan to bring this into the longterm 4.14 tree? I saw
that Jukka ACKed the patch.
Using 4.14, connecting more than 1 node via 6lowpan is completely
broken. This fairly simple patch restores connectivity for multiple
6lowpan devices.
Question: Are there any hidden downsides to using this patch?
- Mike
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-07 18:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 9:52 [PATCH] Bluetooth: 6lowpan: Fix multi-link setup Luiz Augusto von Dentz
2017-09-21 12:19 ` Jukka Rissanen
2017-12-07 18:26 Michael Scott
2017-12-07 18:55 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.