[PATCH 0/3] use setup_timer() helper function.

[PATCH 0/3] use setup_timer() helper function.

[Allen Pais]

This series uses setup_timer() helper function. The series
addresses the files under arch/powerpc/*.


Allen Pais (3):
  powerpc: oprofile: use setup_timer() helper.
  powerpc: use setup_timer() helper.
  powerpc: powermac: use setup_timer() helper.

 arch/powerpc/kernel/tau_6xx.c             | 3 +--
 arch/powerpc/oprofile/op_model_cell.c     | 8 ++------
 arch/powerpc/platforms/powermac/low_i2c.c | 4 +---
 3 files changed, 4 insertions(+), 11 deletions(-)

-- 
2.7.4

[PATCH 1/3] powerpc: oprofile: use setup_timer() helper.

[Allen Pais]

   Use setup_timer function instead of initializing timer with the
   function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 arch/powerpc/oprofile/op_model_cell.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/oprofile/op_model_cell.c b/arch/powerpc/oprofile/op_model_cell.c
index c82497a..264b6ab 100644
--- a/arch/powerpc/oprofile/op_model_cell.c
+++ b/arch/powerpc/oprofile/op_model_cell.c
@@ -555,9 +555,7 @@ static void cell_virtual_cntr(unsigned long data)
 
 static void start_virt_cntrs(void)
 {
-	init_timer(&timer_virt_cntr);
-	timer_virt_cntr.function = cell_virtual_cntr;
-	timer_virt_cntr.data = 0UL;
+	setup_timer(&timer_virt_cntr, cell_virtual_cntr, 0UL);
 	timer_virt_cntr.expires = jiffies + HZ / 10;
 	add_timer(&timer_virt_cntr);
 }
@@ -679,9 +677,7 @@ static void spu_evnt_swap(unsigned long data)
 
 static void start_spu_event_swap(void)
 {
-	init_timer(&timer_spu_event_swap);
-	timer_spu_event_swap.function = spu_evnt_swap;
-	timer_spu_event_swap.data = 0UL;
+	setup_timer(&timer_spu_event_swap, spu_evnt_swap, 0UL);
 	timer_spu_event_swap.expires = jiffies + HZ / 25;
 	add_timer(&timer_spu_event_swap);
 }
-- 
2.7.4

Re: [1/3] powerpc: oprofile: use setup_timer() helper.

[Michael Ellerman]

On Fri, 2017-09-22 at 11:34:58 UTC, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
>    function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

Series applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/83ad1e6a1dc049dd04be4564125a7f

cheers

[PATCH 2/3] powerpc: use setup_timer() helper.

[Allen Pais]

   Use setup_timer function instead of initializing timer with the
   function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 arch/powerpc/kernel/tau_6xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index a753b72..726c2d6 100644
--- a/arch/powerpc/kernel/tau_6xx.c
+++ b/arch/powerpc/kernel/tau_6xx.c
@@ -229,8 +229,7 @@ int __init TAU_init(void)
 
 
 	/* first, set up the window shrinking timer */
-	init_timer(&tau_timer);
-	tau_timer.function = tau_timeout_smp;
+	setup_timer(&tau_timer, tau_timeout_smp, 0UL);
 	tau_timer.expires = jiffies + shrink_timer;
 	add_timer(&tau_timer);
 
-- 
2.7.4

[PATCH 3/3] powerpc: powermac: use setup_timer() helper.

[Allen Pais]

   Use setup_timer function instead of initializing timer with the
   function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 arch/powerpc/platforms/powermac/low_i2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
index 70183eb..39a1d42 100644
--- a/arch/powerpc/platforms/powermac/low_i2c.c
+++ b/arch/powerpc/platforms/powermac/low_i2c.c
@@ -513,9 +513,7 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np)
 	mutex_init(&host->mutex);
 	init_completion(&host->complete);
 	spin_lock_init(&host->lock);
-	init_timer(&host->timeout_timer);
-	host->timeout_timer.function = kw_i2c_timeout;
-	host->timeout_timer.data = (unsigned long)host;
+	setup_timer(&host->timeout_timer, kw_i2c_timeout, (unsigned long)host);
 
 	psteps = of_get_property(np, "AAPL,address-step", NULL);
 	steps = psteps ? (*psteps) : 0x10;
-- 
2.7.4

[PATCH 0/3] use setup_timer() helper function.

[Allen Pais]

This series uses setup_timer() helper function. The series
addresses the files under drivers/block/*.


Allen Pais (3):
  ia64: bte: use setup_timer() helper.
  ia64: mca: use setup_timer() helper.
  ia64: salinfo: use setup_timer() helper.

 arch/ia64/kernel/salinfo.c | 3 +--
 arch/ia64/sn/kernel/bte.c  | 5 ++---
 arch/ia64/sn/kernel/mca.c  | 3 +--
 3 files changed, 4 insertions(+), 7 deletions(-)

-- 
2.7.4

Re: [PATCH 0/3] use setup_timer() helper function.

[Allen]

> This series uses setup_timer() helper function. The series
> addresses the files under drivers/block/*.
my bad, this should have been arch/ia64/*

- Allen

>
> Allen Pais (3):
>   ia64: bte: use setup_timer() helper.
>   ia64: mca: use setup_timer() helper.
>   ia64: salinfo: use setup_timer() helper.
>
>  arch/ia64/kernel/salinfo.c | 3 +--
>  arch/ia64/sn/kernel/bte.c  | 5 ++---
>  arch/ia64/sn/kernel/mca.c  | 3 +--
>  3 files changed, 4 insertions(+), 7 deletions(-)
>
> --
> 2.7.4
>



-- 
       - Allen