* [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-21 1:52 ` Chaotian Jing
0 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-21 1:52 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Mark Rutland, Matthias Brugger, Catalin Marinas,
Will Deacon, Chaotian Jing, yong mao, Linus Walleij,
Javier Martinez Canillas, Heiner Kallweit, Phong LE, linux-mmc,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
srv_heupstream
Change the comptiable for support of multi-platform
Add description for reg
Add description for source_cg
Add description for mediatek,latch-ck
Note that source_cg and mediatek,latch-ck are optional for some projects,
eg, MT2701 do not have source_cg, and MT2712 do not need
mediatek,latch-ck
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 4182ea3..405cd06 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt
and the properties used by the msdc driver.
Required properties:
-- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc"
+- compatible: value should be either of the following.
+ "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
+ "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
+ "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
+ "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
+- reg: physical base address of the controller and length
- interrupts: Should contain MSDC interrupt number
-- clocks: MSDC source clock, HCLK
-- clock-names: "source", "hclk"
+- clocks: MSDC source clock, HCLK, source_cg
+- clock-names: "source", "hclk", "source_cg"
- pinctrl-names: should be "default", "state_uhs"
- pinctrl-0: should contain default/high speed pin ctrl
- pinctrl-1: should contain uhs mode pin ctrl
@@ -30,6 +35,8 @@ Optional properties:
- mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection
If present,HS400 command responses are sampled on rising edges.
If not present,HS400 command responses are sampled on falling edges.
+- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
+ error caused by stop clock(fifo full)
Examples:
mmc0: mmc@11230000 {
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-21 1:52 ` Chaotian Jing
0 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-21 1:52 UTC (permalink / raw)
To: Rob Herring
Cc: Ulf Hansson, Mark Rutland, Matthias Brugger, Catalin Marinas,
Will Deacon, Chaotian Jing, yong mao, Linus Walleij,
Javier Martinez Canillas, Heiner Kallweit, Phong LE, linux-mmc,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
srv_heupstream
Change the comptiable for support of multi-platform
Add description for reg
Add description for source_cg
Add description for mediatek,latch-ck
Note that source_cg and mediatek,latch-ck are optional for some projects,
eg, MT2701 do not have source_cg, and MT2712 do not need
mediatek,latch-ck
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 4182ea3..405cd06 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt
and the properties used by the msdc driver.
Required properties:
-- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc"
+- compatible: value should be either of the following.
+ "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
+ "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
+ "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
+ "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
+- reg: physical base address of the controller and length
- interrupts: Should contain MSDC interrupt number
-- clocks: MSDC source clock, HCLK
-- clock-names: "source", "hclk"
+- clocks: MSDC source clock, HCLK, source_cg
+- clock-names: "source", "hclk", "source_cg"
- pinctrl-names: should be "default", "state_uhs"
- pinctrl-0: should contain default/high speed pin ctrl
- pinctrl-1: should contain uhs mode pin ctrl
@@ -30,6 +35,8 @@ Optional properties:
- mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection
If present,HS400 command responses are sampled on rising edges.
If not present,HS400 command responses are sampled on falling edges.
+- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
+ error caused by stop clock(fifo full)
Examples:
mmc0: mmc@11230000 {
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-21 1:52 ` Chaotian Jing
0 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-21 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Change the comptiable for support of multi-platform
Add description for reg
Add description for source_cg
Add description for mediatek,latch-ck
Note that source_cg and mediatek,latch-ck are optional for some projects,
eg, MT2701 do not have source_cg, and MT2712 do not need
mediatek,latch-ck
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.txt | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 4182ea3..405cd06 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -7,10 +7,15 @@ This file documents differences between the core properties in mmc.txt
and the properties used by the msdc driver.
Required properties:
-- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc"
+- compatible: value should be either of the following.
+ "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
+ "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
+ "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
+ "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
+- reg: physical base address of the controller and length
- interrupts: Should contain MSDC interrupt number
-- clocks: MSDC source clock, HCLK
-- clock-names: "source", "hclk"
+- clocks: MSDC source clock, HCLK, source_cg
+- clock-names: "source", "hclk", "source_cg"
- pinctrl-names: should be "default", "state_uhs"
- pinctrl-0: should contain default/high speed pin ctrl
- pinctrl-1: should contain uhs mode pin ctrl
@@ -30,6 +35,8 @@ Optional properties:
- mediatek,hs400-cmd-resp-sel-rising: HS400 command response sample selection
If present,HS400 command responses are sampled on rising edges.
If not present,HS400 command responses are sampled on falling edges.
+- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
+ error caused by stop clock(fifo full)
Examples:
mmc0: mmc at 11230000 {
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
2017-09-21 1:52 ` Chaotian Jing
(?)
@ 2017-09-22 11:25 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-09-22 11:25 UTC (permalink / raw)
To: Chaotian Jing
Cc: Rob Herring, Ulf Hansson, Mark Rutland, Matthias Brugger,
Catalin Marinas, Will Deacon, yong mao, Javier Martinez Canillas,
Heiner Kallweit, Phong LE, linux-mmc, devicetree,
linux-arm-kernel, moderated list:ARM/Mediatek SoC support,
linux-kernel, srv_heupstream
On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
<chaotian.jing@mediatek.com> wrote:
> +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> + error caused by stop clock(fifo full)
I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-22 11:25 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-09-22 11:25 UTC (permalink / raw)
To: Chaotian Jing
Cc: Rob Herring, Ulf Hansson, Mark Rutland, Matthias Brugger,
Catalin Marinas, Will Deacon, yong mao, Javier Martinez Canillas,
Heiner Kallweit, Phong LE, linux-mmc, devicetree,
linux-arm-kernel, moderated list:ARM/Mediatek SoC support,
linux-kernel, srv_heupstream
On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
<chaotian.jing@mediatek.com> wrote:
> +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> + error caused by stop clock(fifo full)
I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-22 11:25 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-09-22 11:25 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
<chaotian.jing@mediatek.com> wrote:
> +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> + error caused by stop clock(fifo full)
I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
2017-09-22 11:25 ` Linus Walleij
(?)
@ 2017-09-22 11:59 ` Chaotian Jing
-1 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-22 11:59 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Ulf Hansson, Mark Rutland, Matthias Brugger,
Catalin Marinas, Will Deacon, yong mao, Javier Martinez Canillas,
Heiner Kallweit, Phong LE, linux-mmc, devicetree,
linux-arm-kernel, moderated list:ARM/Mediatek SoC support,
linux-kernel, srv_heupstream
On Fri, 2017-09-22 at 13:25 +0200, Linus Walleij wrote:
> On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
> <chaotian.jing@mediatek.com> wrote:
>
> > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> > + error caused by stop clock(fifo full)
>
> I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Sorry about that, will change to SoCs at v3.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-22 11:59 ` Chaotian Jing
0 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-22 11:59 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Ulf Hansson, Mark Rutland, Matthias Brugger,
Catalin Marinas, Will Deacon, yong mao, Javier Martinez Canillas,
Heiner Kallweit, Phong LE, linux-mmc, devicetree,
linux-arm-kernel, moderated list:ARM/Mediatek SoC support,
linux-kernel, srv_heupstream
On Fri, 2017-09-22 at 13:25 +0200, Linus Walleij wrote:
> On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
> <chaotian.jing@mediatek.com> wrote:
>
> > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> > + error caused by stop clock(fifo full)
>
> I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Sorry about that, will change to SoCs at v3.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings
@ 2017-09-22 11:59 ` Chaotian Jing
0 siblings, 0 replies; 9+ messages in thread
From: Chaotian Jing @ 2017-09-22 11:59 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2017-09-22 at 13:25 +0200, Linus Walleij wrote:
> On Thu, Sep 21, 2017 at 3:52 AM, Chaotian Jing
> <chaotian.jing@mediatek.com> wrote:
>
> > +- mediatek,latch-ck: Some projects do not support enhance_rx, need set correct latch-ck to avoid data crc
> > + error caused by stop clock(fifo full)
>
> I think I wrote elsewhere: replace "projects" with "systems" or "SoCs".
Sorry about that, will change to SoCs at v3.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-09-22 11:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 1:52 [PATCH v2] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings Chaotian Jing
2017-09-21 1:52 ` Chaotian Jing
2017-09-21 1:52 ` Chaotian Jing
2017-09-22 11:25 ` Linus Walleij
2017-09-22 11:25 ` Linus Walleij
2017-09-22 11:25 ` Linus Walleij
2017-09-22 11:59 ` Chaotian Jing
2017-09-22 11:59 ` Chaotian Jing
2017-09-22 11:59 ` Chaotian Jing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.