All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] doc: Fix statements on case sensitivity for regulator prefix
@ 2017-09-22 12:27 Felix Brack
  2017-10-07 13:08 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Brack @ 2017-09-22 12:27 UTC (permalink / raw)
  To: u-boot

The regulator bindings state that regulator prefixes are allowd to be
in upper or lower case. However pmic_bind_children from pmic_uclass uses
strncmp to compare DT node name against prefix. This comparison is case
sensitive hence the regulator driver prefix case matters.

Signed-off-by: Felix Brack <fb@ltec.ch>
---

 doc/device-tree-bindings/regulator/regulator.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/device-tree-bindings/regulator/regulator.txt b/doc/device-tree-bindings/regulator/regulator.txt
index 2cf4b9d..918711e 100644
--- a/doc/device-tree-bindings/regulator/regulator.txt
+++ b/doc/device-tree-bindings/regulator/regulator.txt
@@ -10,10 +10,10 @@ pmic: drivers/power/pmic/max77686.c
 regulator: drivers/power/regulator/max77686.c
 
 For the node name e.g.: "prefix[:alpha:]num { ... }":
-- the driver prefix should be: "prefix" or "PREFIX" - case insensitive
+- the driver prefix should be: "prefix" - case sensitive
 - the node name's "num" is set as "dev->driver_data" on bind
 
-Example the prefix "ldo" will pass for: "ldo1", "ldo at 1", "LDO1", "LDOREG at 1"...
+Example the prefix "ldo" will pass for: "ldo1", "ldo at 1", "ldoreg at 1, ...
 
 Optional properties:
 - regulator-name: a string, required by the regulator uclass
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] doc: Fix statements on case sensitivity for regulator prefix
  2017-09-22 12:27 [U-Boot] [PATCH] doc: Fix statements on case sensitivity for regulator prefix Felix Brack
@ 2017-10-07 13:08 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2017-10-07 13:08 UTC (permalink / raw)
  To: u-boot

On Fri, Sep 22, 2017 at 02:27:28PM +0200, Felix Brack wrote:

> The regulator bindings state that regulator prefixes are allowd to be
> in upper or lower case. However pmic_bind_children from pmic_uclass uses
> strncmp to compare DT node name against prefix. This comparison is case
> sensitive hence the regulator driver prefix case matters.
> 
> Signed-off-by: Felix Brack <fb@ltec.ch>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171007/95506a37/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-07 13:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 12:27 [U-Boot] [PATCH] doc: Fix statements on case sensitivity for regulator prefix Felix Brack
2017-10-07 13:08 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.