* [PATCH 0/2] This patchset is for fixes reported by checkpatch.pl
@ 2017-09-23 20:56 Harinath Nampally
2017-09-23 20:56 ` [PATCH 1/2] iio: accel: mma8452: Fix code style warning Harinath Nampally
2017-09-23 20:56 ` [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations Harinath Nampally
0 siblings, 2 replies; 5+ messages in thread
From: Harinath Nampally @ 2017-09-23 20:56 UTC (permalink / raw)
To: jic23
Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, linux-kernel,
amsfield22, martink
Please find the following patches:
iio: accel: mma8452: Fix code style warning for symbolic permissions
iio: accel: mma8452: Fix code style warning for unsigned int
declarations
drivers/iio/accel/mma8452.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] iio: accel: mma8452: Fix code style warning 2017-09-23 20:56 [PATCH 0/2] This patchset is for fixes reported by checkpatch.pl Harinath Nampally @ 2017-09-23 20:56 ` Harinath Nampally 2017-09-24 13:12 ` Jonathan Cameron 2017-09-23 20:56 ` [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations Harinath Nampally 1 sibling, 1 reply; 5+ messages in thread From: Harinath Nampally @ 2017-09-23 20:56 UTC (permalink / raw) To: jic23 Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, linux-kernel, amsfield22, martink Replace symbolic permissions with octal permissions to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally <harinath922@gmail.com> --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index c352555..4a33a26 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -418,11 +418,11 @@ static ssize_t mma8452_show_os_ratio_avail(struct device *dev, } static IIO_DEV_ATTR_SAMP_FREQ_AVAIL(mma8452_show_samp_freq_avail); -static IIO_DEVICE_ATTR(in_accel_scale_available, S_IRUGO, +static IIO_DEVICE_ATTR(in_accel_scale_available, 0444, mma8452_show_scale_avail, NULL, 0); static IIO_DEVICE_ATTR(in_accel_filter_high_pass_3db_frequency_available, - S_IRUGO, mma8452_show_hp_cutoff_avail, NULL, 0); -static IIO_DEVICE_ATTR(in_accel_oversampling_ratio_available, S_IRUGO, + 0444, mma8452_show_hp_cutoff_avail, NULL, 0); +static IIO_DEVICE_ATTR(in_accel_oversampling_ratio_available, 0444, mma8452_show_os_ratio_avail, NULL, 0); static int mma8452_get_samp_freq_index(struct mma8452_data *data, -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iio: accel: mma8452: Fix code style warning 2017-09-23 20:56 ` [PATCH 1/2] iio: accel: mma8452: Fix code style warning Harinath Nampally @ 2017-09-24 13:12 ` Jonathan Cameron 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Cameron @ 2017-09-24 13:12 UTC (permalink / raw) To: Harinath Nampally Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, linux-kernel, amsfield22, martink On Sat, 23 Sep 2017 16:56:29 -0400 Harinath Nampally <harinath922@gmail.com> wrote: > Replace symbolic permissions with octal permissions > to improve code readability. > > Issue found by checkpatch. > > Signed-off-by: Harinath Nampally <harinath922@gmail.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/mma8452.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index c352555..4a33a26 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -418,11 +418,11 @@ static ssize_t mma8452_show_os_ratio_avail(struct device *dev, > } > > static IIO_DEV_ATTR_SAMP_FREQ_AVAIL(mma8452_show_samp_freq_avail); > -static IIO_DEVICE_ATTR(in_accel_scale_available, S_IRUGO, > +static IIO_DEVICE_ATTR(in_accel_scale_available, 0444, > mma8452_show_scale_avail, NULL, 0); > static IIO_DEVICE_ATTR(in_accel_filter_high_pass_3db_frequency_available, > - S_IRUGO, mma8452_show_hp_cutoff_avail, NULL, 0); > -static IIO_DEVICE_ATTR(in_accel_oversampling_ratio_available, S_IRUGO, > + 0444, mma8452_show_hp_cutoff_avail, NULL, 0); > +static IIO_DEVICE_ATTR(in_accel_oversampling_ratio_available, 0444, > mma8452_show_os_ratio_avail, NULL, 0); > > static int mma8452_get_samp_freq_index(struct mma8452_data *data, ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations 2017-09-23 20:56 [PATCH 0/2] This patchset is for fixes reported by checkpatch.pl Harinath Nampally 2017-09-23 20:56 ` [PATCH 1/2] iio: accel: mma8452: Fix code style warning Harinath Nampally @ 2017-09-23 20:56 ` Harinath Nampally 2017-09-24 13:12 ` Jonathan Cameron 1 sibling, 1 reply; 5+ messages in thread From: Harinath Nampally @ 2017-09-23 20:56 UTC (permalink / raw) To: jic23 Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, linux-kernel, amsfield22, martink Replace 'unsigned' with 'unsigned int' to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally <harinath922@gmail.com> --- drivers/iio/accel/mma8452.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 4a33a26..6194169 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1088,8 +1088,8 @@ static irqreturn_t mma8452_trigger_handler(int irq, void *p) } static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, - unsigned reg, unsigned writeval, - unsigned *readval) + unsigned int reg, unsigned int writeval, + unsigned int *readval) { int ret; struct mma8452_data *data = iio_priv(indio_dev); -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations 2017-09-23 20:56 ` [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations Harinath Nampally @ 2017-09-24 13:12 ` Jonathan Cameron 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Cameron @ 2017-09-24 13:12 UTC (permalink / raw) To: Harinath Nampally Cc: knaack.h, lars, pmeerw, gregkh, linux-iio, linux-kernel, amsfield22, martink On Sat, 23 Sep 2017 16:56:30 -0400 Harinath Nampally <harinath922@gmail.com> wrote: > Replace 'unsigned' with 'unsigned int' > to improve code readability. > > Issue found by checkpatch. > > Signed-off-by: Harinath Nampally <harinath922@gmail.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/mma8452.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 4a33a26..6194169 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -1088,8 +1088,8 @@ static irqreturn_t mma8452_trigger_handler(int irq, void *p) > } > > static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, > - unsigned reg, unsigned writeval, > - unsigned *readval) > + unsigned int reg, unsigned int writeval, > + unsigned int *readval) > { > int ret; > struct mma8452_data *data = iio_priv(indio_dev); ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-24 13:12 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-23 20:56 [PATCH 0/2] This patchset is for fixes reported by checkpatch.pl Harinath Nampally 2017-09-23 20:56 ` [PATCH 1/2] iio: accel: mma8452: Fix code style warning Harinath Nampally 2017-09-24 13:12 ` Jonathan Cameron 2017-09-23 20:56 ` [PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations Harinath Nampally 2017-09-24 13:12 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.