* [PATCH v4 00/10] drm: Add GEM backed framebuffer library
@ 2017-09-24 12:26 Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 01/10] drm/tinydrm: Use drm_gem_framebuffer_helper Noralf Trønnes
` (10 more replies)
0 siblings, 11 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
This adds helpers for drivers that don't subclass drm_framebuffer and
are backed by drm_gem_object(s). drm_fb_cma_helper is converted to use
the helpers.
Ack's have been trickling in the last month but seem to have stopped
now, so these are the ones left plus a new one: tve200
Noralf.
Changes since version 3:
- Added tve200
Changes since version 2:
- Expanded docs (Daniel)
- Add drm_gem_fbdev_fb_create() instead of exporting drm_gem_fb_alloc().
This function is used by drivers/helpers to create a drm_framebuffer for
use with fbdev emulation.
- drm_gem_object_put_unlocked() is NULL tolerant (Joe Kniss)
- Rebase tinydrm patch on new st7586 driver
- Rebase arc and pl111 patches on 'drm: make drm_mode_config_func const'
Changes since version 1:
- Pushed the new functions out to the cma drivers, so I could clean up
the cma library.
Noralf Trønnes (10):
drm/tinydrm: Use drm_gem_framebuffer_helper
drm/fsl-dcu: Use drm_gem_fb_create()
drm/hisilicon/kirin: Use drm_gem_fb_create()
drm/meson: Use drm_gem_fb_create()
drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()
drm/rcar-du: Use drm_gem_fb_create()
drm/shmobile: Use drm_gem_fb_create()
drm/sun4i: Use drm_gem_fb_create()
drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()
drm/fb-cma-helper: Remove unused functions
drivers/gpu/drm/drm_fb_cma_helper.c | 77 +------------------------
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 3 +-
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 +-
drivers/gpu/drm/meson/meson_drv.c | 3 +-
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 +-
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 3 +-
drivers/gpu/drm/shmobile/shmob_drm_kms.c | 3 +-
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 3 +-
drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +-
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 5 +-
drivers/gpu/drm/tinydrm/mipi-dbi.c | 5 +-
drivers/gpu/drm/tinydrm/repaper.c | 5 +-
drivers/gpu/drm/tinydrm/st7586.c | 5 +-
drivers/gpu/drm/tve200/tve200_display.c | 3 +-
drivers/gpu/drm/tve200/tve200_drv.c | 3 +-
include/drm/drm_fb_cma_helper.h | 13 -----
16 files changed, 36 insertions(+), 106 deletions(-)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v4 01/10] drm/tinydrm: Use drm_gem_framebuffer_helper
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 02/10] drm/fsl-dcu: Use drm_gem_fb_create() Noralf Trønnes
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
Use drm_gem_framebuffer_helper directly instead of the cma
library wrappers.
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 ++-
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 5 +++--
drivers/gpu/drm/tinydrm/mipi-dbi.c | 5 +++--
drivers/gpu/drm/tinydrm/repaper.c | 5 +++--
drivers/gpu/drm/tinydrm/st7586.c | 5 +++--
5 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
index 551709e..1a8a57c 100644
--- a/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
+++ b/drivers/gpu/drm/tinydrm/core/tinydrm-core.c
@@ -10,6 +10,7 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/tinydrm/tinydrm.h>
#include <linux/device.h>
#include <linux/dma-buf.h>
@@ -128,7 +129,7 @@ tinydrm_fb_create(struct drm_device *drm, struct drm_file *file_priv,
{
struct tinydrm_device *tdev = drm->dev_private;
- return drm_fb_cma_create_with_funcs(drm, file_priv, mode_cmd,
+ return drm_gem_fb_create_with_funcs(drm, file_priv, mode_cmd,
tdev->fb_funcs);
}
diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
index 177e9d8..fc447c9 100644
--- a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
+++ b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
@@ -9,6 +9,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_modes.h>
#include <drm/tinydrm/tinydrm.h>
@@ -144,7 +145,7 @@ EXPORT_SYMBOL(tinydrm_display_pipe_update);
* @pipe: Simple display pipe
* @plane_state: Plane state
*
- * This function uses drm_fb_cma_prepare_fb() to check if the plane FB has an
+ * This function uses drm_gem_fb_prepare_fb() to check if the plane FB has an
* dma-buf attached, extracts the exclusive fence and attaches it to plane
* state for the atomic helper to wait on. Drivers can use this as their
* &drm_simple_display_pipe_funcs->prepare_fb callback.
@@ -152,7 +153,7 @@ EXPORT_SYMBOL(tinydrm_display_pipe_update);
int tinydrm_display_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
struct drm_plane_state *plane_state)
{
- return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
+ return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);
}
EXPORT_SYMBOL(tinydrm_display_pipe_prepare_fb);
diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
index f0dedc2..d43e992 100644
--- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
+++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
@@ -9,6 +9,7 @@
* (at your option) any later version.
*/
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/tinydrm/mipi-dbi.h>
#include <drm/tinydrm/tinydrm-helpers.h>
#include <linux/debugfs.h>
@@ -253,8 +254,8 @@ static int mipi_dbi_fb_dirty(struct drm_framebuffer *fb,
}
static const struct drm_framebuffer_funcs mipi_dbi_fb_funcs = {
- .destroy = drm_fb_cma_destroy,
- .create_handle = drm_fb_cma_create_handle,
+ .destroy = drm_gem_fb_destroy,
+ .create_handle = drm_gem_fb_create_handle,
.dirty = mipi_dbi_fb_dirty,
};
diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tinydrm/repaper.c
index 5fbe147..340198f 100644
--- a/drivers/gpu/drm/tinydrm/repaper.c
+++ b/drivers/gpu/drm/tinydrm/repaper.c
@@ -26,6 +26,7 @@
#include <linux/spi/spi.h>
#include <linux/thermal.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/tinydrm/tinydrm.h>
#include <drm/tinydrm/tinydrm-helpers.h>
@@ -636,8 +637,8 @@ static int repaper_fb_dirty(struct drm_framebuffer *fb,
}
static const struct drm_framebuffer_funcs repaper_fb_funcs = {
- .destroy = drm_fb_cma_destroy,
- .create_handle = drm_fb_cma_create_handle,
+ .destroy = drm_gem_fb_destroy,
+ .create_handle = drm_gem_fb_create_handle,
.dirty = repaper_fb_dirty,
};
diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c
index 07b4d31..da9c0d8 100644
--- a/drivers/gpu/drm/tinydrm/st7586.c
+++ b/drivers/gpu/drm/tinydrm/st7586.c
@@ -17,6 +17,7 @@
#include <linux/spi/spi.h>
#include <video/mipi_display.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/tinydrm/mipi-dbi.h>
#include <drm/tinydrm/tinydrm-helpers.h>
@@ -167,8 +168,8 @@ static int st7586_fb_dirty(struct drm_framebuffer *fb,
}
static const struct drm_framebuffer_funcs st7586_fb_funcs = {
- .destroy = drm_fb_cma_destroy,
- .create_handle = drm_fb_cma_create_handle,
+ .destroy = drm_gem_fb_destroy,
+ .create_handle = drm_gem_fb_create_handle,
.dirty = st7586_fb_dirty,
};
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 02/10] drm/fsl-dcu: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 01/10] drm/tinydrm: Use drm_gem_framebuffer_helper Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 03/10] drm/hisilicon/kirin: " Noralf Trønnes
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Stefan Agner <stefan@agner.ch>
Cc: Alison Wang <alison.wang@freescale.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
index d9d6cc1..ddc68e4 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
@@ -13,6 +13,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include "fsl_dcu_drm_crtc.h"
#include "fsl_dcu_drm_drv.h"
@@ -20,7 +21,7 @@
static const struct drm_mode_config_funcs fsl_dcu_drm_mode_config_funcs = {
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
};
int fsl_dcu_drm_modeset_init(struct fsl_dcu_drm_device *fsl_dev)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 03/10] drm/hisilicon/kirin: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 01/10] drm/tinydrm: Use drm_gem_framebuffer_helper Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 02/10] drm/fsl-dcu: Use drm_gem_fb_create() Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-28 3:12 ` Xinliang Liu
2017-09-24 12:26 ` [PATCH v4 04/10] drm/meson: " Noralf Trønnes
` (7 subsequent siblings)
10 siblings, 1 reply; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index e27352c..c19ab4f 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -22,6 +22,7 @@
#include <drm/drmP.h>
#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_fb_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_of.h>
@@ -56,7 +57,7 @@ static void kirin_fbdev_output_poll_changed(struct drm_device *dev)
}
static const struct drm_mode_config_funcs kirin_drm_mode_config_funcs = {
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
.output_poll_changed = kirin_fbdev_output_poll_changed,
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 04/10] drm/meson: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (2 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 03/10] drm/hisilicon/kirin: " Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 05/10] drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
` (6 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/meson/meson_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 7742c7d..3b804fd 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -34,6 +34,7 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_plane_helper.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_rect.h>
#include <drm/drm_fb_helper.h>
@@ -78,7 +79,7 @@ static const struct drm_mode_config_funcs meson_mode_config_funcs = {
.output_poll_changed = meson_fb_output_poll_changed,
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
};
static irqreturn_t meson_irq(int irq, void *arg)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 05/10] drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (3 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 04/10] drm/meson: " Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 06/10] drm/rcar-du: Use drm_gem_fb_create() Noralf Trønnes
` (5 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() and drm_fb_cma_prepare_fb() are just wrappers now,
use drm_gem_fb_create() and drm_gem_fb_prepare_fb() directly.
Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 7fbad9c..1207ffe 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -35,6 +35,7 @@
#include <drm/drm_fb_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_of.h>
#include <drm/drm_panel.h>
#include <drm/drm_simple_kms_helper.h>
@@ -92,7 +93,7 @@ void mxsfb_disable_axi_clk(struct mxsfb_drm_private *mxsfb)
}
static const struct drm_mode_config_funcs mxsfb_mode_config_funcs = {
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
};
@@ -127,7 +128,7 @@ static void mxsfb_pipe_update(struct drm_simple_display_pipe *pipe,
static int mxsfb_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
struct drm_plane_state *plane_state)
{
- return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
+ return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);
}
static struct drm_simple_display_pipe_funcs mxsfb_funcs = {
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 06/10] drm/rcar-du: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (4 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 05/10] drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 07/10] drm/shmobile: " Noralf Trønnes
` (4 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 7278b97..566d1a9 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -18,6 +18,7 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <linux/of_graph.h>
#include <linux/wait.h>
@@ -213,7 +214,7 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
}
}
- return drm_fb_cma_create(dev, file_priv, mode_cmd);
+ return drm_gem_fb_create(dev, file_priv, mode_cmd);
}
static void rcar_du_output_poll_changed(struct drm_device *dev)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 07/10] drm/shmobile: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (5 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 06/10] drm/rcar-du: Use drm_gem_fb_create() Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 08/10] drm/sun4i: " Noralf Trønnes
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/shmobile/shmob_drm_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/shmobile/shmob_drm_kms.c
index 388a0fc..d36919b 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_kms.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_kms.c
@@ -16,6 +16,7 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <video/sh_mobile_meram.h>
@@ -131,7 +132,7 @@ shmob_drm_fb_create(struct drm_device *dev, struct drm_file *file_priv,
}
}
- return drm_fb_cma_create(dev, file_priv, mode_cmd);
+ return drm_gem_fb_create(dev, file_priv, mode_cmd);
}
static const struct drm_mode_config_funcs shmob_drm_mode_config_funcs = {
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 08/10] drm/sun4i: Use drm_gem_fb_create()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (6 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 07/10] drm/shmobile: " Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-24 19:22 ` Maxime Ripard
2017-09-24 12:26 ` [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
` (2 subsequent siblings)
10 siblings, 1 reply; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
so use the function directly.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
index 9872e0f..2992f0a 100644
--- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
@@ -12,6 +12,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_fb_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drmP.h>
#include "sun4i_drv.h"
@@ -28,7 +29,7 @@ static const struct drm_mode_config_funcs sun4i_de_mode_config_funcs = {
.output_poll_changed = sun4i_de_output_poll_changed,
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
};
struct drm_fbdev_cma *sun4i_framebuffer_init(struct drm_device *drm)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (7 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 08/10] drm/sun4i: " Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-25 15:37 ` Linus Walleij
2017-09-24 12:26 ` [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions Noralf Trønnes
2017-09-25 16:25 ` [PATCH v4 00/10] drm: Add GEM backed framebuffer library Eric Anholt
10 siblings, 1 reply; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
drm_fb_cma_create() and drm_fb_cma_prepare_fb() are just wrappers now,
use drm_gem_fb_create() and drm_gem_fb_prepare_fb() directly.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
drivers/gpu/drm/tve200/tve200_display.c | 3 ++-
drivers/gpu/drm/tve200/tve200_drv.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tve200/tve200_display.c b/drivers/gpu/drm/tve200/tve200_display.c
index 18457de..82221d5 100644
--- a/drivers/gpu/drm/tve200/tve200_display.c
+++ b/drivers/gpu/drm/tve200/tve200_display.c
@@ -21,6 +21,7 @@
#include <drm/drmP.h>
#include <drm/drm_panel.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include "tve200_drm.h"
@@ -290,7 +291,7 @@ void tve200_disable_vblank(struct drm_device *drm, unsigned int crtc)
static int tve200_display_prepare_fb(struct drm_simple_display_pipe *pipe,
struct drm_plane_state *plane_state)
{
- return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
+ return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);
}
const struct drm_simple_display_pipe_funcs tve200_display_funcs = {
diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
index eae38b6..18a07d6 100644
--- a/drivers/gpu/drm/tve200/tve200_drv.c
+++ b/drivers/gpu/drm/tve200/tve200_drv.c
@@ -45,6 +45,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_panel.h>
#include <drm/drm_of.h>
@@ -55,7 +56,7 @@
#define DRIVER_DESC "DRM module for Faraday TVE200"
static const struct drm_mode_config_funcs mode_config_funcs = {
- .fb_create = drm_fb_cma_create,
+ .fb_create = drm_gem_fb_create,
.atomic_check = drm_atomic_helper_check,
.atomic_commit = drm_atomic_helper_commit,
};
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (8 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
@ 2017-09-24 12:26 ` Noralf Trønnes
2017-09-25 15:43 ` Linus Walleij
2017-09-25 16:25 ` [PATCH v4 00/10] drm: Add GEM backed framebuffer library Eric Anholt
10 siblings, 1 reply; 17+ messages in thread
From: Noralf Trønnes @ 2017-09-24 12:26 UTC (permalink / raw)
To: dri-devel
Cc: marex, alison.wang, puck.chen, narmstrong, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
The cma drivers use the drm_gem_framebuffer_helper functions now,
so remove drm_fb_cma_destroy, drm_fb_cma_create_handle,
drm_fb_cma_create_with_funcs, drm_fb_cma_create and
drm_fb_cma_prepare_fb.
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 77 ++-----------------------------------
include/drm/drm_fb_cma_helper.h | 13 -------
2 files changed, 3 insertions(+), 87 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index f2ee883..0e3c141 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -38,7 +38,7 @@ struct drm_fbdev_cma {
* Provides helper functions for creating a cma (contiguous memory allocator)
* backed framebuffer.
*
- * drm_fb_cma_create() is used in the &drm_mode_config_funcs.fb_create
+ * drm_gem_fb_create() is used in the &drm_mode_config_funcs.fb_create
* callback function to create a cma backed framebuffer.
*
* An fbdev framebuffer backed by cma is also available by calling
@@ -61,8 +61,8 @@ struct drm_fbdev_cma {
* }
*
* static struct drm_framebuffer_funcs driver_fb_funcs = {
- * .destroy = drm_fb_cma_destroy,
- * .create_handle = drm_fb_cma_create_handle,
+ * .destroy = drm_gem_fb_destroy,
+ * .create_handle = drm_gem_fb_create_handle,
* .dirty = driver_fb_dirty,
* };
*
@@ -80,57 +80,6 @@ static inline struct drm_fbdev_cma *to_fbdev_cma(struct drm_fb_helper *helper)
return container_of(helper, struct drm_fbdev_cma, fb_helper);
}
-void drm_fb_cma_destroy(struct drm_framebuffer *fb)
-{
- drm_gem_fb_destroy(fb);
-}
-EXPORT_SYMBOL(drm_fb_cma_destroy);
-
-int drm_fb_cma_create_handle(struct drm_framebuffer *fb,
- struct drm_file *file_priv, unsigned int *handle)
-{
- return drm_gem_fb_create_handle(fb, file_priv, handle);
-}
-EXPORT_SYMBOL(drm_fb_cma_create_handle);
-
-/**
- * drm_fb_cma_create_with_funcs() - helper function for the
- * &drm_mode_config_funcs.fb_create
- * callback
- * @dev: DRM device
- * @file_priv: drm file for the ioctl call
- * @mode_cmd: metadata from the userspace fb creation request
- * @funcs: vtable to be used for the new framebuffer object
- *
- * This can be used to set &drm_framebuffer_funcs for drivers that need the
- * &drm_framebuffer_funcs.dirty callback. Use drm_fb_cma_create() if you don't
- * need to change &drm_framebuffer_funcs.
- */
-struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device *dev,
- struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd,
- const struct drm_framebuffer_funcs *funcs)
-{
- return drm_gem_fb_create_with_funcs(dev, file_priv, mode_cmd, funcs);
-}
-EXPORT_SYMBOL_GPL(drm_fb_cma_create_with_funcs);
-
-/**
- * drm_fb_cma_create() - &drm_mode_config_funcs.fb_create callback function
- * @dev: DRM device
- * @file_priv: drm file for the ioctl call
- * @mode_cmd: metadata from the userspace fb creation request
- *
- * If your hardware has special alignment or pitch requirements these should be
- * checked before calling this function. Use drm_fb_cma_create_with_funcs() if
- * you need to set &drm_framebuffer_funcs.dirty.
- */
-struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev,
- struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd)
-{
- return drm_gem_fb_create(dev, file_priv, mode_cmd);
-}
-EXPORT_SYMBOL_GPL(drm_fb_cma_create);
-
/**
* drm_fb_cma_get_gem_obj() - Get CMA GEM object for framebuffer
* @fb: The framebuffer
@@ -181,26 +130,6 @@ dma_addr_t drm_fb_cma_get_gem_addr(struct drm_framebuffer *fb,
}
EXPORT_SYMBOL_GPL(drm_fb_cma_get_gem_addr);
-/**
- * drm_fb_cma_prepare_fb() - Prepare CMA framebuffer
- * @plane: Which plane
- * @state: Plane state attach fence to
- *
- * This should be set as the &struct drm_plane_helper_funcs.prepare_fb hook.
- *
- * This function checks if the plane FB has an dma-buf attached, extracts
- * the exclusive fence and attaches it to plane state for the atomic helper
- * to wait on.
- *
- * There is no need for cleanup_fb for CMA based framebuffer drivers.
- */
-int drm_fb_cma_prepare_fb(struct drm_plane *plane,
- struct drm_plane_state *state)
-{
- return drm_gem_fb_prepare_fb(plane, state);
-}
-EXPORT_SYMBOL_GPL(drm_fb_cma_prepare_fb);
-
#ifdef CONFIG_DEBUG_FS
static void drm_fb_cma_describe(struct drm_framebuffer *fb, struct seq_file *m)
{
diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
index a323781..023f052 100644
--- a/include/drm/drm_fb_cma_helper.h
+++ b/include/drm/drm_fb_cma_helper.h
@@ -28,16 +28,6 @@ void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);
void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
bool state);
-void drm_fb_cma_destroy(struct drm_framebuffer *fb);
-int drm_fb_cma_create_handle(struct drm_framebuffer *fb,
- struct drm_file *file_priv, unsigned int *handle);
-
-struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device *dev,
- struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd,
- const struct drm_framebuffer_funcs *funcs);
-struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev,
- struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd);
-
struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct drm_framebuffer *fb,
unsigned int plane);
@@ -45,9 +35,6 @@ dma_addr_t drm_fb_cma_get_gem_addr(struct drm_framebuffer *fb,
struct drm_plane_state *state,
unsigned int plane);
-int drm_fb_cma_prepare_fb(struct drm_plane *plane,
- struct drm_plane_state *state);
-
#ifdef CONFIG_DEBUG_FS
struct seq_file;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v4 08/10] drm/sun4i: Use drm_gem_fb_create()
2017-09-24 12:26 ` [PATCH v4 08/10] drm/sun4i: " Noralf Trønnes
@ 2017-09-24 19:22 ` Maxime Ripard
0 siblings, 0 replies; 17+ messages in thread
From: Maxime Ripard @ 2017-09-24 19:22 UTC (permalink / raw)
To: Noralf Trønnes
Cc: marex, alison.wang, puck.chen, narmstrong, dri-devel,
z.liuxinliang, kong.kongxinwei, laurent.pinchart, daniel.vetter,
zourongrong
[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]
On Sun, Sep 24, 2017 at 12:26:23PM +0000, Noralf Trønnes wrote:
> drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
> so use the function directly.
>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()
2017-09-24 12:26 ` [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
@ 2017-09-25 15:37 ` Linus Walleij
0 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2017-09-25 15:37 UTC (permalink / raw)
To: Noralf Trønnes
Cc: Marek Vasut, Huan Wang, Chenfeng (puck),
Neil Armstrong, open list:DRM PANEL DRIVERS, Xinliang Liu,
k00278426, Laurent Pinchart, Daniel Vetter, Rongrong Zou,
Maxime Ripard
On Sun, Sep 24, 2017 at 2:26 PM, Noralf Trønnes <noralf@tronnes.org> wrote:
> drm_fb_cma_create() and drm_fb_cma_prepare_fb() are just wrappers now,
> use drm_gem_fb_create() and drm_gem_fb_prepare_fb() directly.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions
2017-09-24 12:26 ` [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions Noralf Trønnes
@ 2017-09-25 15:43 ` Linus Walleij
0 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2017-09-25 15:43 UTC (permalink / raw)
To: Noralf Trønnes
Cc: Marek Vasut, Huan Wang, Chenfeng (puck),
Neil Armstrong, open list:DRM PANEL DRIVERS, Xinliang Liu,
k00278426, Laurent Pinchart, Daniel Vetter, Rongrong Zou,
Maxime Ripard
On Sun, Sep 24, 2017 at 2:26 PM, Noralf Trønnes <noralf@tronnes.org> wrote:
> The cma drivers use the drm_gem_framebuffer_helper functions now,
> so remove drm_fb_cma_destroy, drm_fb_cma_create_handle,
> drm_fb_cma_create_with_funcs, drm_fb_cma_create and
> drm_fb_cma_prepare_fb.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 00/10] drm: Add GEM backed framebuffer library
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
` (9 preceding siblings ...)
2017-09-24 12:26 ` [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions Noralf Trønnes
@ 2017-09-25 16:25 ` Eric Anholt
2017-10-01 15:13 ` Noralf Trønnes
10 siblings, 1 reply; 17+ messages in thread
From: Eric Anholt @ 2017-09-25 16:25 UTC (permalink / raw)
To: Noralf Trønnes, dri-devel
Cc: marex, narmstrong, puck.chen, alison.wang, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
[-- Attachment #1.1: Type: text/plain, Size: 409 bytes --]
Noralf Trønnes <noralf@tronnes.org> writes:
> This adds helpers for drivers that don't subclass drm_framebuffer and
> are backed by drm_gem_object(s). drm_fb_cma_helper is converted to use
> the helpers.
>
> Ack's have been trickling in the last month but seem to have stopped
> now, so these are the ones left plus a new one: tve200
This series is:
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 03/10] drm/hisilicon/kirin: Use drm_gem_fb_create()
2017-09-24 12:26 ` [PATCH v4 03/10] drm/hisilicon/kirin: " Noralf Trønnes
@ 2017-09-28 3:12 ` Xinliang Liu
0 siblings, 0 replies; 17+ messages in thread
From: Xinliang Liu @ 2017-09-28 3:12 UTC (permalink / raw)
To: Noralf Trønnes
Cc: Marek Vasut, Neil Armstrong, Feng Chen, alison.wang, dri-devel,
Liuxinliang (Matthew Liu),
XinWei Kong, Laurent Pinchart, Daniel Vetter, Rongrong Zou,
Maxime Ripard
On 24 September 2017 at 20:26, Noralf Trønnes <noralf@tronnes.org> wrote:
> drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
> so use the function directly.
>
> Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
> Cc: Rongrong Zou <zourongrong@gmail.com>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Thanks,
Reviewed-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
Best,
Xinliang
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index e27352c..c19ab4f 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -22,6 +22,7 @@
> #include <drm/drmP.h>
> #include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_fb_cma_helper.h>
> +#include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_of.h>
> @@ -56,7 +57,7 @@ static void kirin_fbdev_output_poll_changed(struct drm_device *dev)
> }
>
> static const struct drm_mode_config_funcs kirin_drm_mode_config_funcs = {
> - .fb_create = drm_fb_cma_create,
> + .fb_create = drm_gem_fb_create,
> .output_poll_changed = kirin_fbdev_output_poll_changed,
> .atomic_check = drm_atomic_helper_check,
> .atomic_commit = drm_atomic_helper_commit,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v4 00/10] drm: Add GEM backed framebuffer library
2017-09-25 16:25 ` [PATCH v4 00/10] drm: Add GEM backed framebuffer library Eric Anholt
@ 2017-10-01 15:13 ` Noralf Trønnes
0 siblings, 0 replies; 17+ messages in thread
From: Noralf Trønnes @ 2017-10-01 15:13 UTC (permalink / raw)
To: Eric Anholt, dri-devel
Cc: marex, narmstrong, puck.chen, alison.wang, z.liuxinliang,
kong.kongxinwei, laurent.pinchart, daniel.vetter, zourongrong,
maxime.ripard
Den 25.09.2017 18.25, skrev Eric Anholt:
> Noralf Trønnes <noralf@tronnes.org> writes:
>
>> This adds helpers for drivers that don't subclass drm_framebuffer and
>> are backed by drm_gem_object(s). drm_fb_cma_helper is converted to use
>> the helpers.
>>
>> Ack's have been trickling in the last month but seem to have stopped
>> now, so these are the ones left plus a new one: tve200
> This series is:
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
Thanks! Series applied to drm-misc.
Noralf.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-10-01 15:13 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-24 12:26 [PATCH v4 00/10] drm: Add GEM backed framebuffer library Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 01/10] drm/tinydrm: Use drm_gem_framebuffer_helper Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 02/10] drm/fsl-dcu: Use drm_gem_fb_create() Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 03/10] drm/hisilicon/kirin: " Noralf Trønnes
2017-09-28 3:12 ` Xinliang Liu
2017-09-24 12:26 ` [PATCH v4 04/10] drm/meson: " Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 05/10] drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 06/10] drm/rcar-du: Use drm_gem_fb_create() Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 07/10] drm/shmobile: " Noralf Trønnes
2017-09-24 12:26 ` [PATCH v4 08/10] drm/sun4i: " Noralf Trønnes
2017-09-24 19:22 ` Maxime Ripard
2017-09-24 12:26 ` [PATCH v4 09/10] drm/tve200: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb() Noralf Trønnes
2017-09-25 15:37 ` Linus Walleij
2017-09-24 12:26 ` [PATCH v4 10/10] drm/fb-cma-helper: Remove unused functions Noralf Trønnes
2017-09-25 15:43 ` Linus Walleij
2017-09-25 16:25 ` [PATCH v4 00/10] drm: Add GEM backed framebuffer library Eric Anholt
2017-10-01 15:13 ` Noralf Trønnes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.