From: Johannes Berg <johannes@sipsolutions.net>
To: Xiang Gao <qasdfgtyuiop@gmail.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: aead api to reduce redundancy
Date: Sun, 24 Sep 2017 17:05:31 +0200 [thread overview]
Message-ID: <1506265531.2909.5.camel@sipsolutions.net> (raw)
In-Reply-To: <20170924054015.8958-1-qasdfgtyuiop@gmail.com> (sfid-20170924_074130_810821_889115CC)
On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote:
> Currently, the aes_ccm.c and aes_gcm.c are almost line by line
> copy of each other. This patch reduce code redundancy by moving
> the code in these two files to crypto/aead_api.c to make it a
> higher level aead api. The aes_ccm.c and aes_gcm.c are removed
> and all the functions are now implemented in their headers using
> the newly added aead api.
>
No objection from me, though I'd ask you to respin with the indentation
fixed up a bit.
johannes
next prev parent reply other threads:[~2017-09-24 15:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 5:40 [PATCH] mac80211: aead api to reduce redundancy Xiang Gao
2017-09-24 15:05 ` Johannes Berg [this message]
2017-09-24 17:21 ` Xiang Gao
2017-09-24 17:42 ` Johannes Berg
2017-09-24 18:39 ` Xiang Gao
2017-09-25 4:56 ` Herbert Xu
2017-09-25 5:22 ` Johannes Berg
2017-09-25 6:14 ` Herbert Xu
2017-09-28 8:06 ` [lkp-robot] [mac80211] 31e9170bde: hwsim.sta_dynamic_down_up.fail kernel test robot
2017-09-28 8:06 ` kernel test robot
2017-09-29 2:21 ` Xiang Gao
2017-09-26 13:19 [PATCH] mac80211: aead api to reduce redundancy Xiang Gao
2017-10-02 12:04 ` Johannes Berg
2017-10-08 5:43 ` Xiang Gao
2017-10-09 7:09 ` Johannes Berg
2017-10-11 2:31 ` Xiang Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506265531.2909.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qasdfgtyuiop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.