* [PATCH 0/3] clocksource: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: daniel.lezcano, tglx, heiko, afaerber
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Arvind Yadav (3):
[PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
[PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
[PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
drivers/clocksource/owl-timer.c | 4 ++--
drivers/clocksource/rockchip_timer.c | 2 +-
drivers/clocksource/timer-fttmr010.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 0/3] clocksource: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: linux-arm-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Arvind Yadav (3):
[PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
[PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
[PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
drivers/clocksource/owl-timer.c | 4 ++--
drivers/clocksource/rockchip_timer.c | 2 +-
drivers/clocksource/timer-fttmr010.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
2017-09-25 8:16 ` Arvind Yadav
@ 2017-09-25 8:16 ` Arvind Yadav
-1 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: daniel.lezcano, tglx, heiko, afaerber
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/timer-fttmr010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index 66dd909..32214eb 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -263,14 +263,14 @@ static int __init fttmr010_common_init(struct device_node *np, bool is_aspeed)
fttmr010->base = of_iomap(np, 0);
if (!fttmr010->base) {
- pr_err("Can't remap registers");
+ pr_err("Can't remap registers\n");
ret = -ENXIO;
goto out_free;
}
/* IRQ for timer 1 */
irq = irq_of_parse_and_map(np, 0);
if (irq <= 0) {
- pr_err("Can't parse IRQ");
+ pr_err("Can't parse IRQ\n");
ret = -EINVAL;
goto out_unmap;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: linux-arm-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/timer-fttmr010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index 66dd909..32214eb 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -263,14 +263,14 @@ static int __init fttmr010_common_init(struct device_node *np, bool is_aspeed)
fttmr010->base = of_iomap(np, 0);
if (!fttmr010->base) {
- pr_err("Can't remap registers");
+ pr_err("Can't remap registers\n");
ret = -ENXIO;
goto out_free;
}
/* IRQ for timer 1 */
irq = irq_of_parse_and_map(np, 0);
if (irq <= 0) {
- pr_err("Can't parse IRQ");
+ pr_err("Can't parse IRQ\n");
ret = -EINVAL;
goto out_unmap;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: daniel.lezcano, tglx, heiko, afaerber
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/owl-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/owl-timer.c b/drivers/clocksource/owl-timer.c
index d19c53c..c686305 100644
--- a/drivers/clocksource/owl-timer.c
+++ b/drivers/clocksource/owl-timer.c
@@ -125,7 +125,7 @@ static int __init owl_timer_init(struct device_node *node)
owl_timer_base = of_io_request_and_map(node, 0, "owl-timer");
if (IS_ERR(owl_timer_base)) {
- pr_err("Can't map timer registers");
+ pr_err("Can't map timer registers\n");
return PTR_ERR(owl_timer_base);
}
@@ -134,7 +134,7 @@ static int __init owl_timer_init(struct device_node *node)
timer1_irq = of_irq_get_byname(node, "timer1");
if (timer1_irq <= 0) {
- pr_err("Can't parse timer1 IRQ");
+ pr_err("Can't parse timer1 IRQ\n");
return -EINVAL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
tglx-hfZtesqFncYOwBW4kG4KsQ, heiko-4mtYJXux2i+zQB+pC5nmwQ,
afaerber-l3A5Bk7waGM
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/clocksource/owl-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/owl-timer.c b/drivers/clocksource/owl-timer.c
index d19c53c..c686305 100644
--- a/drivers/clocksource/owl-timer.c
+++ b/drivers/clocksource/owl-timer.c
@@ -125,7 +125,7 @@ static int __init owl_timer_init(struct device_node *node)
owl_timer_base = of_io_request_and_map(node, 0, "owl-timer");
if (IS_ERR(owl_timer_base)) {
- pr_err("Can't map timer registers");
+ pr_err("Can't map timer registers\n");
return PTR_ERR(owl_timer_base);
}
@@ -134,7 +134,7 @@ static int __init owl_timer_init(struct device_node *node)
timer1_irq = of_irq_get_byname(node, "timer1");
if (timer1_irq <= 0) {
- pr_err("Can't parse timer1 IRQ");
+ pr_err("Can't parse timer1 IRQ\n");
return -EINVAL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: linux-arm-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/owl-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/owl-timer.c b/drivers/clocksource/owl-timer.c
index d19c53c..c686305 100644
--- a/drivers/clocksource/owl-timer.c
+++ b/drivers/clocksource/owl-timer.c
@@ -125,7 +125,7 @@ static int __init owl_timer_init(struct device_node *node)
owl_timer_base = of_io_request_and_map(node, 0, "owl-timer");
if (IS_ERR(owl_timer_base)) {
- pr_err("Can't map timer registers");
+ pr_err("Can't map timer registers\n");
return PTR_ERR(owl_timer_base);
}
@@ -134,7 +134,7 @@ static int __init owl_timer_init(struct device_node *node)
timer1_irq = of_irq_get_byname(node, "timer1");
if (timer1_irq <= 0) {
- pr_err("Can't parse timer1 IRQ");
+ pr_err("Can't parse timer1 IRQ\n");
return -EINVAL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
2017-09-25 8:16 ` Arvind Yadav
@ 2017-09-25 8:16 ` Arvind Yadav
-1 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: daniel.lezcano, tglx, heiko, afaerber
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/rockchip_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index c27f4c8..33f370d 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -274,7 +274,7 @@ static int __init rk_clksrc_init(struct device_node *np)
TIMER_NAME, rk_clksrc->freq, 250, 32,
clocksource_mmio_readl_down);
if (ret) {
- pr_err("Failed to register clocksource");
+ pr_err("Failed to register clocksource\n");
goto out_clocksource;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
@ 2017-09-25 8:16 ` Arvind Yadav
0 siblings, 0 replies; 13+ messages in thread
From: Arvind Yadav @ 2017-09-25 8:16 UTC (permalink / raw)
To: linux-arm-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/rockchip_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index c27f4c8..33f370d 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -274,7 +274,7 @@ static int __init rk_clksrc_init(struct device_node *np)
TIMER_NAME, rk_clksrc->freq, 250, 32,
clocksource_mmio_readl_down);
if (ret) {
- pr_err("Failed to register clocksource");
+ pr_err("Failed to register clocksource\n");
goto out_clocksource;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
2017-09-25 8:16 ` Arvind Yadav
@ 2017-09-25 8:45 ` Andreas Färber
-1 siblings, 0 replies; 13+ messages in thread
From: Andreas Färber @ 2017-09-25 8:45 UTC (permalink / raw)
To: Arvind Yadav, daniel.lezcano, tglx, heiko
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
Am 25.09.2017 um 10:16 schrieb Arvind Yadav:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/clocksource/owl-timer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
@ 2017-09-25 8:45 ` Andreas Färber
0 siblings, 0 replies; 13+ messages in thread
From: Andreas Färber @ 2017-09-25 8:45 UTC (permalink / raw)
To: linux-arm-kernel
Am 25.09.2017 um 10:16 schrieb Arvind Yadav:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/clocksource/owl-timer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Andreas F?rber <afaerber@suse.de>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/3] clocksource: pr_err() strings should end with newlines
2017-09-25 8:16 ` Arvind Yadav
@ 2017-09-25 23:35 ` Daniel Lezcano
-1 siblings, 0 replies; 13+ messages in thread
From: Daniel Lezcano @ 2017-09-25 23:35 UTC (permalink / raw)
To: Arvind Yadav, tglx, heiko, afaerber
Cc: linux-kernel, linux-arm-kernel, linux-rockchip
On 25/09/2017 10:16, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Arvind Yadav (3):
> [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
> [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
> [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
>
> drivers/clocksource/owl-timer.c | 4 ++--
> drivers/clocksource/rockchip_timer.c | 2 +-
> drivers/clocksource/timer-fttmr010.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
Applied and slightly changed the commit log to:
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
In the future, please use the subject subsystem format to:
clocksource/drivers/<timer>: ....
Thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 0/3] clocksource: pr_err() strings should end with newlines
@ 2017-09-25 23:35 ` Daniel Lezcano
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Lezcano @ 2017-09-25 23:35 UTC (permalink / raw)
To: linux-arm-kernel
On 25/09/2017 10:16, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Arvind Yadav (3):
> [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
> [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
> [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
>
> drivers/clocksource/owl-timer.c | 4 ++--
> drivers/clocksource/rockchip_timer.c | 2 +-
> drivers/clocksource/timer-fttmr010.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
Applied and slightly changed the commit log to:
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
In the future, please use the subject subsystem format to:
clocksource/drivers/<timer>: ....
Thanks.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-09-25 23:35 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 8:16 [PATCH 0/3] clocksource: pr_err() strings should end with newlines Arvind Yadav
2017-09-25 8:16 ` Arvind Yadav
2017-09-25 8:16 ` [PATCH 1/3] clocksource: fttmr010: " Arvind Yadav
2017-09-25 8:16 ` Arvind Yadav
2017-09-25 8:16 ` [PATCH 2/3] clocksource: owl: " Arvind Yadav
2017-09-25 8:16 ` Arvind Yadav
2017-09-25 8:16 ` Arvind Yadav
2017-09-25 8:45 ` Andreas Färber
2017-09-25 8:45 ` Andreas Färber
2017-09-25 8:16 ` [PATCH 3/3] clocksource: rockchip: " Arvind Yadav
2017-09-25 8:16 ` Arvind Yadav
2017-09-25 23:35 ` [PATCH 0/3] clocksource: " Daniel Lezcano
2017-09-25 23:35 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.