All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] rockchip: rk322x: fix pd_bus hclk/pclk
@ 2017-09-28 10:24 Kever Yang
  2017-09-29 16:15 ` [U-Boot] " Philipp Tomsich
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kever Yang @ 2017-09-28 10:24 UTC (permalink / raw)
  To: u-boot

The pd_bus hclk/pclk source is pd_bus aclk, not the PLL.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 drivers/clk/rockchip/clk_rk322x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/rockchip/clk_rk322x.c b/drivers/clk/rockchip/clk_rk322x.c
index 6bbfde4..9e7e047 100644
--- a/drivers/clk/rockchip/clk_rk322x.c
+++ b/drivers/clk/rockchip/clk_rk322x.c
@@ -117,16 +117,16 @@ static void rkclk_init(struct rk322x_cru *cru)
 		     pclk_div << CORE_PERI_DIV_SHIFT);
 
 	/*
-	 * select apll as pd_bus bus clock source and
+	 * select gpll as pd_bus bus clock source and
 	 * set up dependent divisors for PCLK/HCLK and ACLK clocks.
 	 */
 	aclk_div = GPLL_HZ / BUS_ACLK_HZ - 1;
 	assert((aclk_div + 1) * BUS_ACLK_HZ == GPLL_HZ && aclk_div <= 0x1f);
 
-	pclk_div = GPLL_HZ / BUS_PCLK_HZ - 1;
+	pclk_div = BUS_ACLK_HZ / BUS_PCLK_HZ - 1;
 	assert((pclk_div + 1) * BUS_PCLK_HZ == GPLL_HZ && pclk_div <= 0x7);
 
-	hclk_div = GPLL_HZ / BUS_HCLK_HZ - 1;
+	hclk_div = BUS_ACLK_HZ / BUS_HCLK_HZ - 1;
 	assert((hclk_div + 1) * BUS_HCLK_HZ == GPLL_HZ && hclk_div <= 0x3);
 
 	rk_clrsetreg(&cru->cru_clksel_con[0],
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] rockchip: rk322x: fix pd_bus hclk/pclk
  2017-09-28 10:24 [U-Boot] [PATCH] rockchip: rk322x: fix pd_bus hclk/pclk Kever Yang
@ 2017-09-29 16:15 ` Philipp Tomsich
  2017-09-29 16:15 ` Philipp Tomsich
  2017-09-29 16:44 ` Philipp Tomsich
  2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:15 UTC (permalink / raw)
  To: u-boot

> The pd_bus hclk/pclk source is pd_bus aclk, not the PLL.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  drivers/clk/rockchip/clk_rk322x.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] rockchip: rk322x: fix pd_bus hclk/pclk
  2017-09-28 10:24 [U-Boot] [PATCH] rockchip: rk322x: fix pd_bus hclk/pclk Kever Yang
  2017-09-29 16:15 ` [U-Boot] " Philipp Tomsich
@ 2017-09-29 16:15 ` Philipp Tomsich
  2017-09-29 16:44 ` Philipp Tomsich
  2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:15 UTC (permalink / raw)
  To: u-boot

> The pd_bus hclk/pclk source is pd_bus aclk, not the PLL.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  drivers/clk/rockchip/clk_rk322x.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] rockchip: rk322x: fix pd_bus hclk/pclk
  2017-09-28 10:24 [U-Boot] [PATCH] rockchip: rk322x: fix pd_bus hclk/pclk Kever Yang
  2017-09-29 16:15 ` [U-Boot] " Philipp Tomsich
  2017-09-29 16:15 ` Philipp Tomsich
@ 2017-09-29 16:44 ` Philipp Tomsich
  2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:44 UTC (permalink / raw)
  To: u-boot

> The pd_bus hclk/pclk source is pd_bus aclk, not the PLL.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  drivers/clk/rockchip/clk_rk322x.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-09-29 16:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 10:24 [U-Boot] [PATCH] rockchip: rk322x: fix pd_bus hclk/pclk Kever Yang
2017-09-29 16:15 ` [U-Boot] " Philipp Tomsich
2017-09-29 16:15 ` Philipp Tomsich
2017-09-29 16:44 ` Philipp Tomsich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.