All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH ethtool 0/2] Documentation fixes and additions for advertise bitmask
@ 2017-09-28 12:08 Gal Pressman
  2017-09-28 12:08 ` [PATCH ethtool 1/2] ethtool.8: Fix formatting of " Gal Pressman
  2017-09-28 12:08 ` [PATCH ethtool 2/2] ethtool.8: Document 56000 advertise link modes Gal Pressman
  0 siblings, 2 replies; 3+ messages in thread
From: Gal Pressman @ 2017-09-28 12:08 UTC (permalink / raw)
  To: netdev, John W . Linville; +Cc: Tariq Toukan, Pavel Belous, Gal Pressman

Hi John,

The next two patches will fix bad formatting in the advertise modes bitmask and
document four missing 56000 modes.

Regards,
Gal.

Gal Pressman (2):
  ethtool.8: Fix formatting of advertise bitmask
  ethtool.8: Document 56000 advertise link modes

 ethtool.8.in | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH ethtool 1/2] ethtool.8: Fix formatting of advertise bitmask
  2017-09-28 12:08 [PATCH ethtool 0/2] Documentation fixes and additions for advertise bitmask Gal Pressman
@ 2017-09-28 12:08 ` Gal Pressman
  2017-09-28 12:08 ` [PATCH ethtool 2/2] ethtool.8: Document 56000 advertise link modes Gal Pressman
  1 sibling, 0 replies; 3+ messages in thread
From: Gal Pressman @ 2017-09-28 12:08 UTC (permalink / raw)
  To: netdev, John W . Linville; +Cc: Tariq Toukan, Pavel Belous, Gal Pressman

Fields should be separated with a tab instead of spaces.
Also, remove an accidental ' character from 2500baseX Full mode.

Fixes: 64dfc5e2f046 ("ethtool: Add support for 2500baseT/5000baseT link modes")
Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
---
 ethtool.8.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ethtool.8.in b/ethtool.8.in
index 7224b04..de2abc8 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -590,9 +590,9 @@ lB	l	lB.
 0x020	1000baseT Full
 0x20000	1000baseKX Full
 0x20000000000	1000baseX Full
-0x800000000000  2500baseT Full
-0x8000	2500baseX Full	(not supported by IEEE standards)'
-0x1000000000000  5000baseT Full
+0x800000000000	2500baseT Full
+0x8000	2500baseX Full	(not supported by IEEE standards)
+0x1000000000000	5000baseT Full
 0x1000	10000baseT Full
 0x40000	10000baseKX4 Full
 0x80000	10000baseKR Full
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH ethtool 2/2] ethtool.8: Document 56000 advertise link modes
  2017-09-28 12:08 [PATCH ethtool 0/2] Documentation fixes and additions for advertise bitmask Gal Pressman
  2017-09-28 12:08 ` [PATCH ethtool 1/2] ethtool.8: Fix formatting of " Gal Pressman
@ 2017-09-28 12:08 ` Gal Pressman
  1 sibling, 0 replies; 3+ messages in thread
From: Gal Pressman @ 2017-09-28 12:08 UTC (permalink / raw)
  To: netdev, John W . Linville; +Cc: Tariq Toukan, Pavel Belous, Gal Pressman

Add the following advertise modes to the manual:
56000baseKR4 Full
56000baseCR4 Full
56000baseSR4 Full
56000baseLR4 Full

Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
---
 ethtool.8.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ethtool.8.in b/ethtool.8.in
index de2abc8..1654c73 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -613,6 +613,10 @@ lB	l	lB.
 0x400000000	50000baseCR2 Full
 0x800000000	50000baseKR2 Full
 0x10000000000	50000baseSR2 Full
+0x8000000	56000baseKR4 Full
+0x10000000	56000baseCR4 Full
+0x20000000	56000baseSR4 Full
+0x40000000	56000baseLR4 Full
 0x1000000000	100000baseKR4 Full
 0x2000000000	100000baseSR4 Full
 0x4000000000	100000baseCR4 Full
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-28 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 12:08 [PATCH ethtool 0/2] Documentation fixes and additions for advertise bitmask Gal Pressman
2017-09-28 12:08 ` [PATCH ethtool 1/2] ethtool.8: Fix formatting of " Gal Pressman
2017-09-28 12:08 ` [PATCH ethtool 2/2] ethtool.8: Document 56000 advertise link modes Gal Pressman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.