All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: wlan-ng: resolve sparse Endianness issue.
@ 2017-09-28 23:05 Matthew Giassa
  2017-09-29 11:50 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew Giassa @ 2017-09-28 23:05 UTC (permalink / raw)
  To: gregkh; +Cc: sergio.paracuellos, juliana.orod, devel, linux-kernel, matthew

Explicitly converting from __le16 to CPU u16 to resolve sparse error in
prism2sta.c. Original error:

drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in
assignment (different base types)
drivers/staging//wlan-ng/prism2sta.c:1450:29:    expected unsigned short
[unsigned] [usertype] link_status_new
drivers/staging//wlan-ng/prism2sta.c:1450:29:    got restricted __le16
[usertype] linkstatus

Error no longer present.

Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
 drivers/staging/wlan-ng/prism2sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index c9df450..070a237 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -1447,7 +1447,7 @@ static void prism2sta_inf_linkstatus(struct wlandevice *wlandev,
 {
 	struct hfa384x *hw = wlandev->priv;
 
-	hw->link_status_new = inf->info.linkstatus.linkstatus;
+	hw->link_status_new = le16_to_cpu(inf->info.linkstatus.linkstatus);
 
 	schedule_work(&hw->link_bh);
 }
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: wlan-ng: resolve sparse Endianness issue.
  2017-09-28 23:05 [PATCH] staging: wlan-ng: resolve sparse Endianness issue Matthew Giassa
@ 2017-09-29 11:50 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-09-29 11:50 UTC (permalink / raw)
  To: Matthew Giassa
  Cc: gregkh, devel, sergio.paracuellos, linux-kernel, juliana.orod

Someone already sent this.  Work against linux-next or staging-next.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-29 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 23:05 [PATCH] staging: wlan-ng: resolve sparse Endianness issue Matthew Giassa
2017-09-29 11:50 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.