* [PATCH] fs: make fiemap work from compat_ioctl
@ 2017-09-29 19:24 Josef Bacik
2017-10-01 8:22 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Josef Bacik @ 2017-09-29 19:24 UTC (permalink / raw)
To: viro, kernel-team, linux-fsdevel
We don't need to do anything special with fiemap to make it work with a
64bit kernel from 32bit userspace, so just go down to do_vfs_ioctl().
Without this patch we were incorrectly failing to do fiemap with a 32bit
userspace on a 64bit kernel.
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
fs/compat_ioctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index d27b326d96f4..480f9366b4e3 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1579,6 +1579,7 @@ COMPAT_SYSCALL_DEFINE3(ioctl, unsigned int, fd, unsigned int, cmd,
case FICLONE:
case FICLONERANGE:
case FIDEDUPERANGE:
+ case FS_IOC_FIEMAP:
goto do_ioctl;
case FIBMAP:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: make fiemap work from compat_ioctl
2017-09-29 19:24 [PATCH] fs: make fiemap work from compat_ioctl Josef Bacik
@ 2017-10-01 8:22 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-10-01 8:22 UTC (permalink / raw)
To: Josef Bacik; +Cc: viro, kernel-team, linux-fsdevel
On Fri, Sep 29, 2017 at 03:24:06PM -0400, Josef Bacik wrote:
> We don't need to do anything special with fiemap to make it work with a
> 64bit kernel from 32bit userspace, so just go down to do_vfs_ioctl().
> Without this patch we were incorrectly failing to do fiemap with a 32bit
> userspace on a 64bit kernel.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-01 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 19:24 [PATCH] fs: make fiemap work from compat_ioctl Josef Bacik
2017-10-01 8:22 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.