All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 1721744] [NEW] Help content missing for newly added machine properties
@ 2017-10-06 10:29 Satheesh Rajendran
  2017-10-06 11:21 ` [Qemu-devel] [Bug 1721744] " Greg Kurz
  2017-10-06 12:25 ` Greg Kurz
  0 siblings, 2 replies; 4+ messages in thread
From: Satheesh Rajendran @ 2017-10-06 10:29 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:


Help content missing for newly added machine properties, it would be needed by libvirt and other management layers to query to add support, Thanks.

max-cpu-compat,vsmt,modern-hotplug-events,resize-hpt

Steps:
1. Compile qemu @below commit
2. ./ppc64-softmmu/qemu-system-ppc64 -h
....
-machine [type=]name[,prop[=value][,...]]
                selects emulated machine ('-machine help' for list)
                property accel=accel1[:accel2[:...]] selects accelerator
                supported accelerators are kvm, xen, hax or tcg (default: tcg)
                kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)
                vmport=on|off|auto controls emulation of vmport (default: auto)
                kvm_shadow_mem=size of KVM shadow MMU in bytes
                dump-guest-core=on|off include guest memory in a core dump (default=on)
                mem-merge=on|off controls memory merge support (default: on)
                igd-passthru=on|off controls IGD GFX passthrough support (default=off)
                aes-key-wrap=on|off controls support for AES key wrapping (default=on)
                dea-key-wrap=on|off controls support for DEA key wrapping (default=on)
                suppress-vmdesc=on|off disables self-describing migration (default=off)
                nvdimm=on|off controls NVDIMM support (default=off)
                enforce-config-section=on|off enforce configuration section migration (default=off)
                s390-squash-mcss=on|off controls support for squashing into default css (default=off)
....

===> Not showing help of mentioned properties.


Verified at todays below commit
#git show
commit d8f932cc696250cb740240d668b39df5fbb2d5a0
Merge: 67caeea 4504273
Author: Peter Maydell <peter.maydell@linaro.org>
Date:   Thu Oct 5 16:54:29 2017 +0100

    Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging
    
    # gpg: Signature made Thu 05 Oct 2017 15:25:21 BST
    # gpg:                using RSA key 0x9CA4ABB381AB73C8
    # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
    # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
    # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
    
    * remotes/stefanha/tags/tracing-pull-request:
      checkpatch: fix incompatibility with old perl
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1721744

Title:
  Help content missing for newly added machine properties

Status in QEMU:
  New

Bug description:
  
  Help content missing for newly added machine properties, it would be needed by libvirt and other management layers to query to add support, Thanks.

  max-cpu-compat,vsmt,modern-hotplug-events,resize-hpt

  Steps:
  1. Compile qemu @below commit
  2. ./ppc64-softmmu/qemu-system-ppc64 -h
  ....
  -machine [type=]name[,prop[=value][,...]]
                  selects emulated machine ('-machine help' for list)
                  property accel=accel1[:accel2[:...]] selects accelerator
                  supported accelerators are kvm, xen, hax or tcg (default: tcg)
                  kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)
                  vmport=on|off|auto controls emulation of vmport (default: auto)
                  kvm_shadow_mem=size of KVM shadow MMU in bytes
                  dump-guest-core=on|off include guest memory in a core dump (default=on)
                  mem-merge=on|off controls memory merge support (default: on)
                  igd-passthru=on|off controls IGD GFX passthrough support (default=off)
                  aes-key-wrap=on|off controls support for AES key wrapping (default=on)
                  dea-key-wrap=on|off controls support for DEA key wrapping (default=on)
                  suppress-vmdesc=on|off disables self-describing migration (default=off)
                  nvdimm=on|off controls NVDIMM support (default=off)
                  enforce-config-section=on|off enforce configuration section migration (default=off)
                  s390-squash-mcss=on|off controls support for squashing into default css (default=off)
  ....

  ===> Not showing help of mentioned properties.


  Verified at todays below commit
  #git show
  commit d8f932cc696250cb740240d668b39df5fbb2d5a0
  Merge: 67caeea 4504273
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   Thu Oct 5 16:54:29 2017 +0100

      Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging
      
      # gpg: Signature made Thu 05 Oct 2017 15:25:21 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/tracing-pull-request:
        checkpatch: fix incompatibility with old perl
      
      Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1721744/+subscriptions

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Qemu-devel] [Bug 1721744] Re: Help content missing for newly added machine properties
  2017-10-06 10:29 [Qemu-devel] [Bug 1721744] [NEW] Help content missing for newly added machine properties Satheesh Rajendran
@ 2017-10-06 11:21 ` Greg Kurz
  2017-10-06 11:49   ` Cornelia Huck
  2017-10-06 12:25 ` Greg Kurz
  1 sibling, 1 reply; 4+ messages in thread
From: Greg Kurz @ 2017-10-06 11:21 UTC (permalink / raw)
  To: qemu-devel

Hmm... -h is common to all targets, ie, you should only find properties
that can be passed to -machine for all qemu-system-* binaries (I don't
know how s390-squash-mcss landed there but it looks wrong).

The right way to query properties supported by a pseries machine type
is:

$ ./ppc64-softmmu/qemu-system-ppc64 -machine pseries,help
pseries-2.11.kvm-type=string (Specifies the KVM virtualization mode (HV, PR))
pseries-2.11.vsmt=uint32 (Virtual SMT: KVM behaves as if this were the host's SMT mode)
pseries-2.11.modern-hotplug-events=bool (Use dedicated hotplug event mechanism in place of standard EPOW events when possible (required for memory hot-unplug support))
pseries-2.11.max-cpu-compat=string (Maximum permitted CPU compatibility mode. Valid values are power6, power7, power7+, power8, power9.)
pseries-2.11.resize-hpt=string (Resizing of the Hash Page Table (enabled, disabled, required))
pseries-2.11.kvm-shadow-mem=int (KVM shadow MMU size)
pseries-2.11.enforce-config-section=bool (Set on to enforce configuration section migration)
pseries-2.11.initrd=string (Linux initial ramdisk file)
pseries-2.11.mem-merge=bool (Enable/disable memory merge support)
pseries-2.11.firmware=string (Firmware image)
pseries-2.11.dtb=string (Linux kernel device tree file)
pseries-2.11.suppress-vmdesc=bool (Set on to disable self-describing migration)
pseries-2.11.usb=bool (Set on/off to enable/disable usb)
pseries-2.11.kernel=string (Linux kernel image file)
pseries-2.11.dt-compatible=string (Overrides the "compatible" property of the dt root node)
pseries-2.11.igd-passthru=bool (Set on/off to enable/disable igd passthrou)
pseries-2.11.dumpdtb=string (Dump current dtb to a file and quit)
pseries-2.11.append=string (Linux kernel command line)
pseries-2.11.accel=string (Accelerator list)
pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
pseries-2.11.dump-guest-core=bool (Include guest memory in  a core dump)
pseries-2.11.phandle-start=int (The first phandle ID we may generate dynamically)
pseries-2.11.graphics=bool (Set on/off to enable/disable graphics emulation)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1721744

Title:
  Help content missing for newly added machine properties

Status in QEMU:
  New

Bug description:
  
  Help content missing for newly added machine properties, it would be needed by libvirt and other management layers to query to add support, Thanks.

  max-cpu-compat,vsmt,modern-hotplug-events,resize-hpt

  Steps:
  1. Compile qemu @below commit
  2. ./ppc64-softmmu/qemu-system-ppc64 -h
  ....
  -machine [type=]name[,prop[=value][,...]]
                  selects emulated machine ('-machine help' for list)
                  property accel=accel1[:accel2[:...]] selects accelerator
                  supported accelerators are kvm, xen, hax or tcg (default: tcg)
                  kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)
                  vmport=on|off|auto controls emulation of vmport (default: auto)
                  kvm_shadow_mem=size of KVM shadow MMU in bytes
                  dump-guest-core=on|off include guest memory in a core dump (default=on)
                  mem-merge=on|off controls memory merge support (default: on)
                  igd-passthru=on|off controls IGD GFX passthrough support (default=off)
                  aes-key-wrap=on|off controls support for AES key wrapping (default=on)
                  dea-key-wrap=on|off controls support for DEA key wrapping (default=on)
                  suppress-vmdesc=on|off disables self-describing migration (default=off)
                  nvdimm=on|off controls NVDIMM support (default=off)
                  enforce-config-section=on|off enforce configuration section migration (default=off)
                  s390-squash-mcss=on|off controls support for squashing into default css (default=off)
  ....

  ===> Not showing help of mentioned properties.


  Verified at todays below commit
  #git show
  commit d8f932cc696250cb740240d668b39df5fbb2d5a0
  Merge: 67caeea 4504273
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   Thu Oct 5 16:54:29 2017 +0100

      Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging
      
      # gpg: Signature made Thu 05 Oct 2017 15:25:21 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/tracing-pull-request:
        checkpatch: fix incompatibility with old perl
      
      Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1721744/+subscriptions

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [Bug 1721744] Re: Help content missing for newly added machine properties
  2017-10-06 11:21 ` [Qemu-devel] [Bug 1721744] " Greg Kurz
@ 2017-10-06 11:49   ` Cornelia Huck
  0 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2017-10-06 11:49 UTC (permalink / raw)
  To: Greg Kurz; +Cc: Bug 1721744, qemu-devel

On Fri, 06 Oct 2017 11:21:08 -0000
Greg Kurz <groug@kaod.org> wrote:

> Hmm... -h is common to all targets, ie, you should only find properties
> that can be passed to -machine for all qemu-system-* binaries (I don't
> know how s390-squash-mcss landed there but it looks wrong).

That output comes from qemu-options.hx, which contains information
added by hand. That means that some machine options end up there, some
don't. If this is only supposed to contain common options, we should
remove s390-squash-mcss (and the -key-wrap ones are s390-specific as
well).

> 
> The right way to query properties supported by a pseries machine type
> is:
> 
> $ ./ppc64-softmmu/qemu-system-ppc64 -machine pseries,help

Indeed. This contains the real set of properties and does not depend on
whether a developer added some extra help text.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Qemu-devel] [Bug 1721744] Re: Help content missing for newly added machine properties
  2017-10-06 10:29 [Qemu-devel] [Bug 1721744] [NEW] Help content missing for newly added machine properties Satheesh Rajendran
  2017-10-06 11:21 ` [Qemu-devel] [Bug 1721744] " Greg Kurz
@ 2017-10-06 12:25 ` Greg Kurz
  1 sibling, 0 replies; 4+ messages in thread
From: Greg Kurz @ 2017-10-06 12:25 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
       Status: New => Invalid

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1721744

Title:
  Help content missing for newly added machine properties

Status in QEMU:
  Invalid

Bug description:
  
  Help content missing for newly added machine properties, it would be needed by libvirt and other management layers to query to add support, Thanks.

  max-cpu-compat,vsmt,modern-hotplug-events,resize-hpt

  Steps:
  1. Compile qemu @below commit
  2. ./ppc64-softmmu/qemu-system-ppc64 -h
  ....
  -machine [type=]name[,prop[=value][,...]]
                  selects emulated machine ('-machine help' for list)
                  property accel=accel1[:accel2[:...]] selects accelerator
                  supported accelerators are kvm, xen, hax or tcg (default: tcg)
                  kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)
                  vmport=on|off|auto controls emulation of vmport (default: auto)
                  kvm_shadow_mem=size of KVM shadow MMU in bytes
                  dump-guest-core=on|off include guest memory in a core dump (default=on)
                  mem-merge=on|off controls memory merge support (default: on)
                  igd-passthru=on|off controls IGD GFX passthrough support (default=off)
                  aes-key-wrap=on|off controls support for AES key wrapping (default=on)
                  dea-key-wrap=on|off controls support for DEA key wrapping (default=on)
                  suppress-vmdesc=on|off disables self-describing migration (default=off)
                  nvdimm=on|off controls NVDIMM support (default=off)
                  enforce-config-section=on|off enforce configuration section migration (default=off)
                  s390-squash-mcss=on|off controls support for squashing into default css (default=off)
  ....

  ===> Not showing help of mentioned properties.


  Verified at todays below commit
  #git show
  commit d8f932cc696250cb740240d668b39df5fbb2d5a0
  Merge: 67caeea 4504273
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   Thu Oct 5 16:54:29 2017 +0100

      Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging
      
      # gpg: Signature made Thu 05 Oct 2017 15:25:21 BST
      # gpg:                using RSA key 0x9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>"
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>"
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha/tags/tracing-pull-request:
        checkpatch: fix incompatibility with old perl
      
      Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1721744/+subscriptions

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-06 12:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-06 10:29 [Qemu-devel] [Bug 1721744] [NEW] Help content missing for newly added machine properties Satheesh Rajendran
2017-10-06 11:21 ` [Qemu-devel] [Bug 1721744] " Greg Kurz
2017-10-06 11:49   ` Cornelia Huck
2017-10-06 12:25 ` Greg Kurz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.