From: Madalin Bucur <madalin.bucur@nxp.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <f.fainelli@gmail.com>, <andrew@lunn.ch>,
<vivien.didelot@savoirfairelinux.com>, <junote@outlook.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 1/4] fsl/fman: remove of_node
Date: Tue, 10 Oct 2017 17:10:15 +0300 [thread overview]
Message-ID: <1507644618-32006-2-git-send-email-madalin.bucur@nxp.com> (raw)
In-Reply-To: <1507644618-32006-1-git-send-email-madalin.bucur@nxp.com>
The FMan MAC driver allocates a platform device for the Ethernet
driver to probe on. Setting pdev->dev.of_node with the MAC node
triggers the MAC driver probing of the new platform device. While
this fails quickly and does not affect the functionality of the
drivers, it is incorrect and must be removed. This was added to
address a report that DSA code using of_find_net_device_by_node()
is unable to use the DPAA interfaces. Error message seen before
this fix:
fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed
fsl_mac: probe of dpaa-ethernet.0 failed with error -16
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
drivers/net/ethernet/freescale/fman/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 387eb4a..9a265f8 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id,
goto no_mem;
}
- pdev->dev.of_node = node;
pdev->dev.parent = priv->dev;
set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
--
2.1.0
next prev parent reply other threads:[~2017-10-10 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 14:10 [PATCH 0/4] adapt DPAA drivers for DSA Madalin Bucur
2017-10-10 14:10 ` Madalin Bucur [this message]
2017-10-10 14:10 ` [PATCH 2/4] dpaa_eth: move of_phy_connect() to the eth driver Madalin Bucur
2017-10-10 14:10 ` [PATCH 3/4] dpaa_eth: change device used Madalin Bucur
2017-10-11 21:02 ` David Miller
2017-10-12 9:11 ` Madalin-cristian Bucur
2017-10-12 9:11 ` Madalin-cristian Bucur
2017-10-10 14:10 ` [PATCH 4/4] fsl/fman: add dpaa in module names Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507644618-32006-2-git-send-email-madalin.bucur@nxp.com \
--to=madalin.bucur@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=junote@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.