All of lore.kernel.org
 help / color / mirror / Atom feed
* regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
@ 2017-10-04  8:36 ` Lothar Waßmann
  0 siblings, 0 replies; 8+ messages in thread
From: Lothar Waßmann @ 2017-10-04  8:36 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, linux-arm-kernel, Lucas Stach

Hi,

the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
introduced a regression on the Ka-Ro TX series modules (and possibly
other hardware as well).

The problem is, that this commit restricts the supported sound formats
to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
patch. Therefore aplay fails with the following error messages, when
trying to play a sound file with S16_LE format:
|ALSA lib alsa-lib-1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave PCM not usable
|aplay: set_params:1204: Broken configuration for this PCM: no configurations available

This is with the simple-sound-card driver as well as the imx-sgtl5000
driver.

Can someone tell me on what hardware and with what software has this
patch been tested?


Lothar Waßmann
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
@ 2017-10-04  8:36 ` Lothar Waßmann
  0 siblings, 0 replies; 8+ messages in thread
From: Lothar Waßmann @ 2017-10-04  8:36 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
introduced a regression on the Ka-Ro TX series modules (and possibly
other hardware as well).

The problem is, that this commit restricts the supported sound formats
to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
patch. Therefore aplay fails with the following error messages, when
trying to play a sound file with S16_LE format:
|ALSA lib alsa-lib-1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave PCM not usable
|aplay: set_params:1204: Broken configuration for this PCM: no configurations available

This is with the simple-sound-card driver as well as the imx-sgtl5000
driver.

Can someone tell me on what hardware and with what software has this
patch been tested?


Lothar Wa?mann

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
  2017-10-04  8:36 ` Lothar Waßmann
@ 2017-10-10 14:49   ` Lucas Stach
  -1 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2017-10-10 14:49 UTC (permalink / raw)
  To: Lothar Waßmann, alsa-devel; +Cc: Mark Brown, linux-arm-kernel

Hi Lothar,

Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Waßmann:
> Hi,
> 
> the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> introduced a regression on the Ka-Ro TX series modules (and possibly
> other hardware as well).
> 
> The problem is, that this commit restricts the supported sound
> formats
> to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
> patch. Therefore aplay fails with the following error messages, when
> trying to play a sound file with S16_LE format:
> > ALSA lib alsa-lib-
> > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave
> > PCM not usable
> > aplay: set_params:1204: Broken configuration for this PCM: no
> > configurations available
> 
> This is with the simple-sound-card driver as well as the imx-sgtl5000
> driver.
> 
> Can someone tell me on what hardware and with what software has this
> patch been tested?

My primary test hardware was the zii-rdu2 board, the DTS for this board
can be found in recent mainline kernels.

Userspace is based on pulseaudio, which may mask the regression by
resampling to the supported format. Sorry about that.

From my understanding of the code, it should be possible to fix the
regression without reverting this patch by setting
SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in
fsl_ssi.

Regards,
Lucas
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
@ 2017-10-10 14:49   ` Lucas Stach
  0 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2017-10-10 14:49 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Lothar,

Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Wa?mann:
> Hi,
> 
> the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> introduced a regression on the Ka-Ro TX series modules (and possibly
> other hardware as well).
> 
> The problem is, that this commit restricts the supported sound
> formats
> to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
> patch. Therefore aplay fails with the following error messages, when
> trying to play a sound file with S16_LE format:
> > ALSA lib alsa-lib-
> > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave
> > PCM not usable
> > aplay: set_params:1204: Broken configuration for this PCM: no
> > configurations available
> 
> This is with the simple-sound-card driver as well as the imx-sgtl5000
> driver.
> 
> Can someone tell me on what hardware and with what software has this
> patch been tested?

My primary test hardware was the zii-rdu2 board, the DTS for this board
can be found in recent mainline kernels.

Userspace is based on pulseaudio, which may mask the regression by
resampling to the supported format. Sorry about that.

>From my understanding of the code, it should be possible to fix the
regression without reverting this patch by setting
SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in
fsl_ssi.

Regards,
Lucas

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
  2017-10-10 14:49   ` Lucas Stach
@ 2017-10-10 15:18     ` Lothar Waßmann
  -1 siblings, 0 replies; 8+ messages in thread
From: Lothar Waßmann @ 2017-10-10 15:18 UTC (permalink / raw)
  To: Lucas Stach; +Cc: alsa-devel, Mark Brown, linux-arm-kernel

Hi,

On Tue, 10 Oct 2017 16:49:04 +0200 Lucas Stach wrote:
> Hi Lothar,
> 
> Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Waßmann:
> > Hi,
> > 
> > the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> > introduced a regression on the Ka-Ro TX series modules (and possibly
> > other hardware as well).
> > 
> > The problem is, that this commit restricts the supported sound
> > formats
> > to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
> > patch. Therefore aplay fails with the following error messages, when
> > trying to play a sound file with S16_LE format:
> > > ALSA lib alsa-lib-
> > > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave
> > > PCM not usable
> > > aplay: set_params:1204: Broken configuration for this PCM: no
> > > configurations available
> > 
> > This is with the simple-sound-card driver as well as the imx-sgtl5000
> > driver.
> > 
> > Can someone tell me on what hardware and with what software has this
> > patch been tested?
> 
> My primary test hardware was the zii-rdu2 board, the DTS for this board
> can be found in recent mainline kernels.
> 
> Userspace is based on pulseaudio, which may mask the regression by
> resampling to the supported format. Sorry about that.
> 
> From my understanding of the code, it should be possible to fix the
> regression without reverting this patch by setting
> SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in
> fsl_ssi.
> 
I tried that, but then I get DMA timeouts.

I circumvented the problem by changing my /etc/asound.conf to use the
only supported sample format. So, if nobody else has a problem, there
is no need to revert the patch or apply additional modifications to the
driver.


Lothar Waßmann
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
@ 2017-10-10 15:18     ` Lothar Waßmann
  0 siblings, 0 replies; 8+ messages in thread
From: Lothar Waßmann @ 2017-10-10 15:18 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Tue, 10 Oct 2017 16:49:04 +0200 Lucas Stach wrote:
> Hi Lothar,
> 
> Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Wa?mann:
> > Hi,
> > 
> > the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> > introduced a regression on the Ka-Ro TX series modules (and possibly
> > other hardware as well).
> > 
> > The problem is, that this commit restricts the supported sound
> > formats
> > to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
> > patch. Therefore aplay fails with the following error messages, when
> > trying to play a sound file with S16_LE format:
> > > ALSA lib alsa-lib-
> > > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave
> > > PCM not usable
> > > aplay: set_params:1204: Broken configuration for this PCM: no
> > > configurations available
> > 
> > This is with the simple-sound-card driver as well as the imx-sgtl5000
> > driver.
> > 
> > Can someone tell me on what hardware and with what software has this
> > patch been tested?
> 
> My primary test hardware was the zii-rdu2 board, the DTS for this board
> can be found in recent mainline kernels.
> 
> Userspace is based on pulseaudio, which may mask the regression by
> resampling to the supported format. Sorry about that.
> 
> From my understanding of the code, it should be possible to fix the
> regression without reverting this patch by setting
> SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in
> fsl_ssi.
> 
I tried that, but then I get DMA timeouts.

I circumvented the problem by changing my /etc/asound.conf to use the
only supported sample format. So, if nobody else has a problem, there
is no need to revert the patch or apply additional modifications to the
driver.


Lothar Wa?mann

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
  2017-10-10 15:18     ` Lothar Waßmann
@ 2017-10-12 15:51       ` Mark Brown
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2017-10-12 15:51 UTC (permalink / raw)
  To: Lothar Waßmann; +Cc: alsa-devel, linux-arm-kernel, Lucas Stach


[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]

On Tue, Oct 10, 2017 at 05:18:46PM +0200, Lothar Waßmann wrote:

> I circumvented the problem by changing my /etc/asound.conf to use the
> only supported sample format. So, if nobody else has a problem, there
> is no need to revert the patch or apply additional modifications to the
> driver.

I've not seen any other reports.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 8+ messages in thread

* regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
@ 2017-10-12 15:51       ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2017-10-12 15:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Oct 10, 2017 at 05:18:46PM +0200, Lothar Wa?mann wrote:

> I circumvented the problem by changing my /etc/asound.conf to use the
> only supported sample format. So, if nobody else has a problem, there
> is no need to revert the patch or apply additional modifications to the
> driver.

I've not seen any other reports.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171012/5441e7eb/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-10-12 15:51 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04  8:36 regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") Lothar Waßmann
2017-10-04  8:36 ` Lothar Waßmann
2017-10-10 14:49 ` Lucas Stach
2017-10-10 14:49   ` Lucas Stach
2017-10-10 15:18   ` Lothar Waßmann
2017-10-10 15:18     ` Lothar Waßmann
2017-10-12 15:51     ` Mark Brown
2017-10-12 15:51       ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.