All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] [mm]: cma: change pr_info to pr_err for cma_alloc fail log
@ 2017-10-10 15:50 ` Pintu Agarwal
  0 siblings, 0 replies; 2+ messages in thread
From: Pintu Agarwal @ 2017-10-10 15:50 UTC (permalink / raw)
  To: linux-kernel, linux-mm, akpm, labbott, gregkh, jaewon31.kim,
	opendmb, pintu.ping

It was observed that under cma_alloc fail log, pr_info was
used instead of pr_err.
This will lead to problem if printk debug level is set to
below 7. In this case the cma_alloc failure log will not
be captured in the log and it will be difficult to debug.

Simply replace the pr_info with pr_err to capture failure log.

Signed-off-by: Pintu Agarwal <pintu.ping@gmail.com>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index c0da318..e0d1393 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -461,7 +461,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
 	trace_cma_alloc(pfn, page, count, align);
 
 	if (ret) {
-		pr_info("%s: alloc failed, req-size: %zu pages, ret: %d\n",
+		pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n",
 			__func__, count, ret);
 		cma_debug_show_areas(cma);
 	}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/1] [mm]: cma: change pr_info to pr_err for cma_alloc fail log
@ 2017-10-10 15:50 ` Pintu Agarwal
  0 siblings, 0 replies; 2+ messages in thread
From: Pintu Agarwal @ 2017-10-10 15:50 UTC (permalink / raw)
  To: linux-kernel, linux-mm, akpm, labbott, gregkh, jaewon31.kim,
	opendmb, pintu.ping

It was observed that under cma_alloc fail log, pr_info was
used instead of pr_err.
This will lead to problem if printk debug level is set to
below 7. In this case the cma_alloc failure log will not
be captured in the log and it will be difficult to debug.

Simply replace the pr_info with pr_err to capture failure log.

Signed-off-by: Pintu Agarwal <pintu.ping@gmail.com>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index c0da318..e0d1393 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -461,7 +461,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
 	trace_cma_alloc(pfn, page, count, align);
 
 	if (ret) {
-		pr_info("%s: alloc failed, req-size: %zu pages, ret: %d\n",
+		pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n",
 			__func__, count, ret);
 		cma_debug_show_areas(cma);
 	}
-- 
2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-10 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 15:50 [PATCH 1/1] [mm]: cma: change pr_info to pr_err for cma_alloc fail log Pintu Agarwal
2017-10-10 15:50 ` Pintu Agarwal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.