* [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD
@ 2017-10-11 12:59 Stefan Berger
2017-10-11 13:00 ` Peter Maydell
2017-10-11 13:38 ` no-reply
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Berger @ 2017-10-11 12:59 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, amarnath.valluri, marcandre.lureau, Stefan Berger
EMSGSIZE was only added to OpenBSD very recently. To make QEMU
compileable on older OpenBSD versions use EMSGSIZE instead when
a mismatch between number of received bytes and message size in-
dicated in the header was found.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
hw/tpm/tpm_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_util.c b/hw/tpm/tpm_util.c
index fb929f6..1129155 100644
--- a/hw/tpm/tpm_util.c
+++ b/hw/tpm/tpm_util.c
@@ -91,7 +91,7 @@ static int tpm_util_test(int fd,
resp = (struct tpm_resp_hdr *)buf;
/* check the header */
if (be32_to_cpu(resp->len) != n) {
- return EBADMSG;
+ return EMSGSIZE;
}
*return_tag = be16_to_cpu(resp->tag);
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD
2017-10-11 12:59 [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD Stefan Berger
@ 2017-10-11 13:00 ` Peter Maydell
2017-10-11 13:38 ` no-reply
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2017-10-11 13:00 UTC (permalink / raw)
To: Stefan Berger; +Cc: QEMU Developers, amarnath.valluri, Marc-André Lureau
On 11 October 2017 at 13:59, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> EMSGSIZE was only added to OpenBSD very recently. To make QEMU
Do you mean "EBADMSG" in this line?
> compileable on older OpenBSD versions use EMSGSIZE instead when
> a mismatch between number of received bytes and message size in-
> dicated in the header was found.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
> hw/tpm/tpm_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_util.c b/hw/tpm/tpm_util.c
> index fb929f6..1129155 100644
> --- a/hw/tpm/tpm_util.c
> +++ b/hw/tpm/tpm_util.c
> @@ -91,7 +91,7 @@ static int tpm_util_test(int fd,
> resp = (struct tpm_resp_hdr *)buf;
> /* check the header */
> if (be32_to_cpu(resp->len) != n) {
> - return EBADMSG;
> + return EMSGSIZE;
> }
>
> *return_tag = be16_to_cpu(resp->tag);
> --
> 2.5.5
>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD
2017-10-11 12:59 [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD Stefan Berger
2017-10-11 13:00 ` Peter Maydell
@ 2017-10-11 13:38 ` no-reply
1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2017-10-11 13:38 UTC (permalink / raw)
To: stefanb
Cc: famz, qemu-devel, peter.maydell, amarnath.valluri, marcandre.lureau
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1507726772-16661-1-git-send-email-stefanb@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1507728290-6062-1-git-send-email-thomas.venries@gmail.com -> patchew/1507728290-6062-1-git-send-email-thomas.venries@gmail.com
Switched to a new branch 'test'
5af50e4c64 tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD
=== OUTPUT BEGIN ===
Checking PATCH 1/1: tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD...
ERROR: return of an errno should typically be -ve (return -EMSGSIZE)
#23: FILE: hw/tpm/tpm_util.c:69:
+ return EMSGSIZE;
total: 1 errors, 0 warnings, 8 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 13:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 12:59 [Qemu-devel] [PATCH] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD Stefan Berger
2017-10-11 13:00 ` Peter Maydell
2017-10-11 13:38 ` no-reply
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.