All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] lib/igt_gt: Allow non-default contexts to hang non-render rings
@ 2017-10-11 17:16 Vinay Belgaumkar
  2017-10-11 17:24 ` Chris Wilson
  2017-10-11 20:14 ` ✗ Fi.CI.BAT: failure for lib/igt_gt: Allow non-default contexts to hang non-render rings (rev2) Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Vinay Belgaumkar @ 2017-10-11 17:16 UTC (permalink / raw)
  To: intel-gfx

This limitation does not exist for gen8+. It was removed by this patch-

commit f7978a0c581a8a840a28306f8da43e06e7fef3bf

v2: Added commit id that removes the limitation(Chris Wilson)

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 lib/igt_gt.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index b3f3b38..abf789d 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -214,6 +214,7 @@ void igt_disallow_hang(int fd, igt_hang_t arg)
  * @ctx: the contxt specifier
  * @ring: execbuf ring flag
  * @flags: set of flags to control execution
+ * @offset: The resultant gtt offset of the exec obj
  *
  * This helper function injects a hanging batch associated with @ctx into @ring.
  * It returns a #igt_hang_t structure which must be passed to
@@ -239,8 +240,11 @@ igt_hang_t igt_hang_ctx(int fd,
 
 	igt_require_hang_ring(fd, ring);
 
-	/* One day the kernel ABI will be fixed! */
-	igt_require(ctx == 0 || ring == I915_EXEC_RENDER);
+	if (!(intel_gen(intel_get_drm_devid(fd)) >= 8))
+	{
+		/* One day the kernel ABI will be fixed! */
+		igt_require(ctx == 0 || ring == I915_EXEC_RENDER);
+	}
 
 	param.context = ctx;
 	param.size = 0;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t v2] lib/igt_gt: Allow non-default contexts to hang non-render rings
  2017-10-11 17:16 [PATCH i-g-t v2] lib/igt_gt: Allow non-default contexts to hang non-render rings Vinay Belgaumkar
@ 2017-10-11 17:24 ` Chris Wilson
  2017-10-11 20:14 ` ✗ Fi.CI.BAT: failure for lib/igt_gt: Allow non-default contexts to hang non-render rings (rev2) Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2017-10-11 17:24 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx

Quoting Vinay Belgaumkar (2017-10-11 18:16:23)
> This limitation does not exist for gen8+. It was removed by this patch-
> 
> commit f7978a0c581a8a840a28306f8da43e06e7fef3bf

So where is the mention of gen8 there? And where is the compatibility
test to determine the age of the kernel?

As a hint,

bool has_ctx_exec(int fd, unsigned ring) {
        struct drm_i915_gem_execbuffer2 execbuf;
        struct drm_i915_gem_exec_object2 exec;
	bool supported;

        /* silly ABI, the kernel thinks everyone who has BSD also has BSD2 */
        if ((ring & ~(3<<13)) == I915_EXEC_BSD) {
                if (ring & (3 << 13) && !gem_has_bsd2(fd))
                        return false;
        }

        memset(&exec, 0, sizeof(exec));
        memset(&execbuf, 0, sizeof(execbuf));
        execbuf.buffers_ptr = to_user_pointer(&exec);
        execbuf.buffer_count = 1;
        execbuf.flags = ring;
        execbuf.rsvd1 = gem_context_crate(fd);
        supported = __gem_execbuf(fd, &execbuf) == -ENOENT;
	gem_context_destroy(execbuf.rsvd1);

	return supported;
}
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for lib/igt_gt: Allow non-default contexts to hang non-render rings (rev2)
  2017-10-11 17:16 [PATCH i-g-t v2] lib/igt_gt: Allow non-default contexts to hang non-render rings Vinay Belgaumkar
  2017-10-11 17:24 ` Chris Wilson
@ 2017-10-11 20:14 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-10-11 20:14 UTC (permalink / raw)
  To: Vinay Belgaumkar; +Cc: intel-gfx

== Series Details ==

Series: lib/igt_gt: Allow non-default contexts to hang non-render rings (rev2)
URL   : https://patchwork.freedesktop.org/series/31693/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build
136100c2f00b590bc9485100cce012282c1217cf igt/syncobj_wait: Don't close the timeline early in wait_snapshot

with latest DRM-Tip kernel build CI_DRM_3220
6a96415ec560 drm-tip: 2017y-10m-11d-19h-08m-29s UTC integration manifest

No testlist changes.

Test gem_close_race:
        Subgroup basic-threads:
                dmesg-warn -> PASS       (fi-snb-2520m)
Test gem_exec_reloc:
        Subgroup basic-gtt-active:
                pass       -> FAIL       (fi-gdg-551) fdo#102582 +4
        Subgroup basic-write-cpu-active:
                pass       -> FAIL       (fi-gdg-551)
        Subgroup basic-write-gtt-active:
                pass       -> FAIL       (fi-gdg-551)
Test gem_ringfill:
        Subgroup basic-default-hang:
                incomplete -> DMESG-WARN (fi-blb-e6850) fdo#101600
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                pass       -> SKIP       (fi-hsw-4770r)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                incomplete -> PASS       (fi-kbl-7567u)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-byt-n2820) fdo#101705

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:463s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:470s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:393s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:567s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:285s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:526s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:522s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:540s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:532s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:570s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:438s
fi-gdg-551       total:289  pass:171  dwarn:1   dfail:0   fail:8   skip:109 time:274s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:601s
fi-hsw-4770r     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:422s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:465s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:508s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:473s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:505s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:582s
fi-kbl-7567u     total:289  pass:265  dwarn:4   dfail:0   fail:0   skip:20  time:490s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:590s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:661s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:482s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:657s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:538s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:512s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:477s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:578s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:436s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_330/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 20:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 17:16 [PATCH i-g-t v2] lib/igt_gt: Allow non-default contexts to hang non-render rings Vinay Belgaumkar
2017-10-11 17:24 ` Chris Wilson
2017-10-11 20:14 ` ✗ Fi.CI.BAT: failure for lib/igt_gt: Allow non-default contexts to hang non-render rings (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.