* [CI i-g-t] tests: Drop gem_bad_length as redundant
@ 2017-10-10 12:28 Joonas Lahtinen
2017-10-10 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2017-10-10 12:28 UTC (permalink / raw)
To: Intel graphics driver community testing & development
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Most of the gem_bad_length code is compiled out because creating
a zero-length object is not allowed anymore by i915 and thus it is
not possible to execute it. The remaining part checks that creation of
a zero-length object does indeed fail, which is also checked by
gem_create/create-invalid-size.
The only difference between the 2 tests is that gem_bad_length checks
specifically for EINVAL while create-invalid-size only looks for
failure, so after adding the EINVAL check to create-invalid-size it is
safe to drop gem_bad_length.
v2 (Joonas):
- Clarify header line, split the patch, fix Meson build and add Cc:
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/Makefile.sources | 1 -
tests/gem_bad_length.c | 133 -------------------------------------------------
tests/meson.build | 1 -
3 files changed, 135 deletions(-)
delete mode 100644 tests/gem_bad_length.c
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index bb6652e2..9c9fb316 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -40,7 +40,6 @@ TESTS_progs = \
drv_module_reload \
drv_selftest \
drv_suspend \
- gem_bad_length \
gem_bad_reloc \
gem_basic \
gem_busy \
diff --git a/tests/gem_bad_length.c b/tests/gem_bad_length.c
deleted file mode 100644
index cca0145e..00000000
--- a/tests/gem_bad_length.c
+++ /dev/null
@@ -1,133 +0,0 @@
-/*
- * Copyright © 2011 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- * Authors:
- * Chris Wilson <chris@chris-wilson.co.uk>
- *
- */
-
-#include "igt.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include "drm.h"
-
-IGT_TEST_DESCRIPTION("Test minimal bo_create and batchbuffer exec.");
-
-/*
- * Testcase: Minimal bo_create and batchbuffer exec
- *
- * Originally this caught an kernel oops due to the unchecked assumption that
- * objects have size > 0.
- */
-
-static uint32_t do_gem_create(int fd, int size, int *retval)
-{
- struct drm_i915_gem_create create;
- int ret;
-
- create.handle = 0;
- create.size = (size + 4095) & -4096;
- ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_CREATE, &create);
- igt_assert(retval || ret == 0);
- if (retval)
- *retval = errno;
-
- return create.handle;
-}
-
-#if 0
-static int gem_exec(int fd, struct drm_i915_gem_execbuffer2 *execbuf)
-{
- return drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, execbuf);
-}
-#endif
-
-static void create0(int fd)
-{
- int retval = 0;
- igt_info("trying to create a zero-length gem object\n");
- do_gem_create(fd, 0, &retval);
- igt_assert(retval == EINVAL);
-}
-
-#if 0
-static void exec0(int fd)
-{
- struct drm_i915_gem_execbuffer2 execbuf;
- struct drm_i915_gem_exec_object2 exec[1];
- uint32_t buf[2] = { MI_BATCH_BUFFER_END, 0 };
-
- /* Just try executing with a zero-length bo.
- * We expect the kernel to either accept the nop batch, or reject it
- * for the zero-length buffer, but never crash.
- */
-
- exec[0].handle = gem_create(fd, 4096);
- gem_write(fd, exec[0].handle, 0, buf, sizeof(buf));
- exec[0].relocation_count = 0;
- exec[0].relocs_ptr = 0;
- exec[0].alignment = 0;
- exec[0].offset = 0;
- exec[0].flags = 0;
- exec[0].rsvd1 = 0;
- exec[0].rsvd2 = 0;
-
- execbuf.buffers_ptr = (uintptr_t)exec;
- execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = sizeof(buf);
- execbuf.cliprects_ptr = 0;
- execbuf.num_cliprects = 0;
- execbuf.DR1 = 0;
- execbuf.DR4 = 0;
- execbuf.flags = 0;
- i915_execbuffer2_set_context_id(execbuf, 0);
- execbuf.rsvd2 = 0;
-
- igt_info("trying to run an empty batchbuffer\n");
- gem_exec(fd, &execbuf);
-
- gem_close(fd, exec[0].handle);
-}
-#endif
-
-igt_simple_main
-{
- int fd;
-
- igt_skip_on_simulation();
-
- fd = drm_open_driver(DRIVER_INTEL);
-
- create0(fd);
-
- //exec0(fd);
-
- close(fd);
-}
diff --git a/tests/meson.build b/tests/meson.build
index 6cb3584a..85666f6d 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -20,7 +20,6 @@ test_progs = [
'drv_module_reload',
'drv_selftest',
'drv_suspend',
- 'gem_bad_length',
'gem_bad_reloc',
'gem_basic',
'gem_busy',
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for tests: Drop gem_bad_length as redundant
2017-10-10 12:28 [CI i-g-t] tests: Drop gem_bad_length as redundant Joonas Lahtinen
@ 2017-10-10 18:23 ` Patchwork
2017-10-11 1:24 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-12 8:37 ` [CI i-g-t] " Joonas Lahtinen
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-10-10 18:23 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: tests: Drop gem_bad_length as redundant
URL : https://patchwork.freedesktop.org/series/31655/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d7c88290ab6a8393dc341b30c7fb5e27d2952901 syncobj: Add a test for SYNCOBJ_CREATE_SIGNALED
with latest DRM-Tip kernel build CI_DRM_3206
cc58e6d2bc38 drm-tip: 2017y-10m-10d-15h-40m-22s UTC integration manifest
Testlist changes:
-igt@gem_bad_length
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-kbl-7560u) fdo#102846
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:455s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:393s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:581s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:286s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:526s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:523s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:542s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:517s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:562s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:633s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:599s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:436s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:425s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:465s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:476s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:505s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:492s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:663s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:472s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:661s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:535s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:508s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:474s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:583s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:433s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_313/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.IGT: warning for tests: Drop gem_bad_length as redundant
2017-10-10 12:28 [CI i-g-t] tests: Drop gem_bad_length as redundant Joonas Lahtinen
2017-10-10 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-11 1:24 ` Patchwork
2017-10-12 8:37 ` [CI i-g-t] " Joonas Lahtinen
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-10-11 1:24 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
== Series Details ==
Series: tests: Drop gem_bad_length as redundant
URL : https://patchwork.freedesktop.org/series/31655/
State : warning
== Summary ==
Test gem_eio:
Subgroup wait:
pass -> DMESG-WARN (shard-hsw) fdo#102886 +4
Test kms_universal_plane:
Subgroup cursor-fb-leak-pipe-A:
pass -> SKIP (shard-hsw)
Test kms_flip:
Subgroup modeset-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#102919
Test kms_plane:
Subgroup plane-position-hole-pipe-C-planes:
pass -> DMESG-WARN (shard-hsw)
fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#102919 https://bugs.freedesktop.org/show_bug.cgi?id=102919
shard-hsw total:2551 pass:1428 dwarn:5 dfail:0 fail:14 skip:1104 time:9567s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_313/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [CI i-g-t] tests: Drop gem_bad_length as redundant
2017-10-10 12:28 [CI i-g-t] tests: Drop gem_bad_length as redundant Joonas Lahtinen
2017-10-10 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-11 1:24 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-10-12 8:37 ` Joonas Lahtinen
2 siblings, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2017-10-12 8:37 UTC (permalink / raw)
To: Intel graphics driver community testing & development
On Tue, 2017-10-10 at 15:28 +0300, Joonas Lahtinen wrote:
> From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
> Most of the gem_bad_length code is compiled out because creating
> a zero-length object is not allowed anymore by i915 and thus it is
> not possible to execute it. The remaining part checks that creation of
> a zero-length object does indeed fail, which is also checked by
> gem_create/create-invalid-size.
> The only difference between the 2 tests is that gem_bad_length checks
> specifically for EINVAL while create-invalid-size only looks for
> failure, so after adding the EINVAL check to create-invalid-size it is
> safe to drop gem_bad_length.
>
> v2 (Joonas):
> - Clarify header line, split the patch, fix Meson build and add Cc:
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Merged the patch.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-12 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 12:28 [CI i-g-t] tests: Drop gem_bad_length as redundant Joonas Lahtinen
2017-10-10 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-11 1:24 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-12 8:37 ` [CI i-g-t] " Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.