All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: salvator-common: add dr_mode property for USB2.0 channel 0
@ 2017-10-12  9:23 Yoshihiro Shimoda
  2017-10-19  4:36 ` Yoshihiro Shimoda
  0 siblings, 1 reply; 2+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-12  9:23 UTC (permalink / raw)
  To: horms, magnus.damm, robh+dt, mark.rutland
  Cc: devicetree, linux-renesas-soc, Yoshihiro Shimoda

Since Salvator-X[S] have a USB2.0 dual-role channel (CN9), this patch
adds dr_mode property for USB2.0 channel 0 (EHCI/OHCI and HS-USB)
as "otg".

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 This patch based on the renesas.git / renesas-devel-20171011-v4.14-rc4 tag.

 Using dual-role channel (or not) is related to the type of USB receptor on
 board specification. So, I added the property into the salvator-common.dtsi.

 This property will be used by phy-rcar-gen3-usb2 driver in the future [1].
 However, adding this property without the [1] patch will not cause any
 side-effects.

 [1] : https://patchwork.kernel.org/patch/10001113/


 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 3dcb26b..9bd409b 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -282,6 +282,7 @@
 };
 
 &ehci0 {
+	dr_mode = "otg";
 	status = "okay";
 };
 
@@ -294,6 +295,7 @@
 };
 
 &hsusb {
+	dr_mode = "otg";
 	status = "okay";
 };
 
@@ -356,6 +358,7 @@
 };
 
 &ohci0 {
+	dr_mode = "otg";
 	status = "okay";
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] arm64: dts: renesas: salvator-common: add dr_mode property for USB2.0 channel 0
  2017-10-12  9:23 [PATCH] arm64: dts: renesas: salvator-common: add dr_mode property for USB2.0 channel 0 Yoshihiro Shimoda
@ 2017-10-19  4:36 ` Yoshihiro Shimoda
  0 siblings, 0 replies; 2+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-19  4:36 UTC (permalink / raw)
  To: horms, magnus.damm, robh+dt, mark.rutland; +Cc: devicetree, linux-renesas-soc

Hi Simon-san,

> From: Yoshihiro Shimoda, Sent: Thursday, October 12, 2017 6:24 PM
> 
> Since Salvator-X[S] have a USB2.0 dual-role channel (CN9), this patch
> adds dr_mode property for USB2.0 channel 0 (EHCI/OHCI and HS-USB)
> as "otg".
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  This patch based on the renesas.git / renesas-devel-20171011-v4.14-rc4 tag.
> 
>  Using dual-role channel (or not) is related to the type of USB receptor on
>  board specification. So, I added the property into the salvator-common.dtsi.
> 
>  This property will be used by phy-rcar-gen3-usb2 driver in the future [1].
>  However, adding this property without the [1] patch will not cause any
>  side-effects.
> 
>  [1] : https://patchwork.kernel.org/patch/10001113/

Would you apply this patch for v4.15?
I got ack from the PHY maintainer:

https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg19494.html

Best regards,
Yoshihiro Shimoda

> 
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 3dcb26b..9bd409b 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -282,6 +282,7 @@
>  };
> 
>  &ehci0 {
> +	dr_mode = "otg";
>  	status = "okay";
>  };
> 
> @@ -294,6 +295,7 @@
>  };
> 
>  &hsusb {
> +	dr_mode = "otg";
>  	status = "okay";
>  };
> 
> @@ -356,6 +358,7 @@
>  };
> 
>  &ohci0 {
> +	dr_mode = "otg";
>  	status = "okay";
>  };
> 
> --
> 1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-19  4:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12  9:23 [PATCH] arm64: dts: renesas: salvator-common: add dr_mode property for USB2.0 channel 0 Yoshihiro Shimoda
2017-10-19  4:36 ` Yoshihiro Shimoda

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.