All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make
@ 2017-10-13 10:43 Luca Ceresoli
  2017-10-15 14:00 ` Thomas Petazzoni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Luca Ceresoli @ 2017-10-13 10:43 UTC (permalink / raw)
  To: buildroot

TARGET_MAKE_ENV is not passed to make because it is on a different
line without a backslash.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/bzip2/bzip2.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/bzip2/bzip2.mk b/package/bzip2/bzip2.mk
index 62571ed5a3a6..e43533072b2d 100644
--- a/package/bzip2/bzip2.mk
+++ b/package/bzip2/bzip2.mk
@@ -12,13 +12,13 @@ BZIP2_LICENSE_FILES = LICENSE
 
 ifeq ($(BR2_STATIC_LIBS),)
 define BZIP2_BUILD_SHARED_CMDS
-	$(TARGET_MAKE_ENV)
+	$(TARGET_MAKE_ENV) \
 		$(MAKE) -C $(@D) -f Makefile-libbz2_so $(TARGET_CONFIGURE_OPTS)
 endef
 endif
 
 define BZIP2_BUILD_CMDS
-	$(TARGET_MAKE_ENV)
+	$(TARGET_MAKE_ENV) \
 		$(MAKE) -C $(@D) libbz2.a bzip2 bzip2recover $(TARGET_CONFIGURE_OPTS)
 	$(BZIP2_BUILD_SHARED_CMDS)
 endef
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make
  2017-10-13 10:43 [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make Luca Ceresoli
@ 2017-10-15 14:00 ` Thomas Petazzoni
  2017-10-15 21:08 ` Peter Korsgaard
  2017-10-17  9:10 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-10-15 14:00 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 13 Oct 2017 12:43:24 +0200, Luca Ceresoli wrote:
> TARGET_MAKE_ENV is not passed to make because it is on a different
> line without a backslash.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  package/bzip2/bzip2.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make
  2017-10-13 10:43 [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make Luca Ceresoli
  2017-10-15 14:00 ` Thomas Petazzoni
@ 2017-10-15 21:08 ` Peter Korsgaard
  2017-10-17  9:10 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-10-15 21:08 UTC (permalink / raw)
  To: buildroot

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 > TARGET_MAKE_ENV is not passed to make because it is on a different
 > line without a backslash.

 > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make
  2017-10-13 10:43 [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make Luca Ceresoli
  2017-10-15 14:00 ` Thomas Petazzoni
  2017-10-15 21:08 ` Peter Korsgaard
@ 2017-10-17  9:10 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-10-17  9:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 > TARGET_MAKE_ENV is not passed to make because it is on a different
 > line without a backslash.

 > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Committed to 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-17  9:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 10:43 [Buildroot] [PATCH] bzip2: fix passing of TARGET_MAKE_ENV to make Luca Ceresoli
2017-10-15 14:00 ` Thomas Petazzoni
2017-10-15 21:08 ` Peter Korsgaard
2017-10-17  9:10 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.