* [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
@ 2017-10-17 20:27 Oscar Mateo
2017-10-17 21:26 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oscar Mateo @ 2017-10-17 20:27 UTC (permalink / raw)
To: intel-gfx
Now that we write RING_FORCE_TO_NONPRIV registers directly to hardware,
[commit 32ced39 ("drm/i915: Transform whitelisting WAs into a simple reg
write")] there is no need to save space for them in the list of context
workarounds.
v2: Refer to previous commit in commit message (Michel)
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index dd141b2..d31addb 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1964,13 +1964,7 @@ struct i915_wa_reg {
u32 mask;
};
-/*
- * RING_MAX_NONPRIV_SLOTS is per-engine but at this point we are only
- * allowing it for RCS as we don't foresee any requirement of having
- * a whitelist for other engines. When it is really required for
- * other engines then the limit need to be increased.
- */
-#define I915_MAX_WA_REGS (16 + RING_MAX_NONPRIV_SLOTS)
+#define I915_MAX_WA_REGS 16
struct i915_workarounds {
struct i915_wa_reg reg[I915_MAX_WA_REGS];
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
2017-10-17 20:27 [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space Oscar Mateo
@ 2017-10-17 21:26 ` Patchwork
2017-10-18 8:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-18 8:50 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-10-17 21:26 UTC (permalink / raw)
To: Oscar Mateo; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
URL : https://patchwork.freedesktop.org/series/32159/
State : success
== Summary ==
Series 32159v1 drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
https://patchwork.freedesktop.org/api/1.0/series/32159/revisions/1/mbox/
Test chamelium:
Subgroup dp-edid-read:
incomplete -> SKIP (fi-hsw-4770r)
Subgroup dp-crc-fast:
dmesg-fail -> FAIL (fi-kbl-7500u) fdo#102514
Test drv_module_reload:
Subgroup basic-reload-inject:
dmesg-warn -> INCOMPLETE (fi-cfl-s) fdo#103206
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103206 https://bugs.freedesktop.org/show_bug.cgi?id=103206
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:443s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:374s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:531s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:263s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:490s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:494s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:489s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:478s
fi-cfl-s total:288 pass:253 dwarn:3 dfail:0 fail:0 skip:31
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:414s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:249s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:564s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:424s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:433s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:487s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:475s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:572s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:581s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:556s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:642s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:514s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:491s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:461s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:573s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:428s
17972293741c44cf70b30bb740bc3d4f2333403c drm-tip: 2017y-10m-17d-18h-04m-07s UTC integration manifest
4a491ff6570e drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6082/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
2017-10-17 20:27 [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space Oscar Mateo
2017-10-17 21:26 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-18 8:29 ` Patchwork
2017-10-18 8:50 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-10-18 8:29 UTC (permalink / raw)
To: Oscar Mateo; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
URL : https://patchwork.freedesktop.org/series/32159/
State : failure
== Summary ==
Test drv_suspend:
Subgroup sysfs-reader-hibernate:
fail -> DMESG-FAIL (shard-hsw) k.org#196691
Test kms_chv_cursor_fail:
Subgroup pipe-B-256x256-top-edge:
pass -> DMESG-FAIL (shard-hsw)
k.org#196691 https://bugzilla.kernel.org/show_bug.cgi?id=196691
shard-hsw total:2551 pass:1440 dwarn:0 dfail:2 fail:8 skip:1101 time:9334s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6082/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
2017-10-17 20:27 [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space Oscar Mateo
2017-10-17 21:26 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-18 8:29 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2017-10-18 8:50 ` Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-10-18 8:50 UTC (permalink / raw)
To: Oscar Mateo, intel-gfx
Quoting Oscar Mateo (2017-10-17 21:27:51)
> Now that we write RING_FORCE_TO_NONPRIV registers directly to hardware,
> [commit 32ced39 ("drm/i915: Transform whitelisting WAs into a simple reg
> write")] there is no need to save space for them in the list of context
> workarounds.
>
> v2: Refer to previous commit in commit message (Michel)
>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Michel Thierry <michel.thierry@intel.com>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
And pushed, thanks for the patch.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-18 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 20:27 [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space Oscar Mateo
2017-10-17 21:26 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-18 8:29 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-18 8:50 ` [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.