* [PATCH] Input: stmfts: Fix bug of ABS_MT_POSITION_* maximum size
[not found] <CGME20171018103835epcas1p13ca5f794456313f91c427efdb17f8396@epcas1p1.samsung.com>
@ 2017-10-18 10:38 ` Chanwoo Choi
2017-10-19 0:34 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Chanwoo Choi @ 2017-10-18 10:38 UTC (permalink / raw)
To: dmitry.torokhov
Cc: rydberg, andi.shyti, robh, arnd, cw00.choi, chanwoo, inki.dae,
sw0312.kim, linux-input, linux-kernel, linux-samsung-soc, stable
The commit 78bcac7b2ae1e ("Input: add support for the STMicroelectronics
FingerTip touchscreen) used the 'touchscreen_parse_properties()' helper
function in order to get the value of common properties.
But, commit 78bcac7b2ae1e didn't set the capability of ABS_MT_POSITION_*
before calling touchscreen_parse_properties(). In result, the max_x and max_y
of 'struct touchscreen_propeties' were not set. So, this patch fixes the bug
to get the ABS_MT_POSITION_* maximum size.
Fixes: 78bcac7b2ae1e ("Input: add support for the STMicroelectronics FingerTip touchscreen")
Cc: stable@vger.kernel.org
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/input/touchscreen/stmfts.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 157fdb4bb2e8..8c6c6178ec12 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -663,12 +663,10 @@ static int stmfts_probe(struct i2c_client *client,
sdata->input->open = stmfts_input_open;
sdata->input->close = stmfts_input_close;
+ input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_X);
+ input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_Y);
touchscreen_parse_properties(sdata->input, true, &sdata->prop);
- input_set_abs_params(sdata->input, ABS_MT_POSITION_X, 0,
- sdata->prop.max_x, 0, 0);
- input_set_abs_params(sdata->input, ABS_MT_POSITION_Y, 0,
- sdata->prop.max_y, 0, 0);
input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: stmfts: Fix bug of ABS_MT_POSITION_* maximum size
2017-10-18 10:38 ` [PATCH] Input: stmfts: Fix bug of ABS_MT_POSITION_* maximum size Chanwoo Choi
@ 2017-10-19 0:34 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-10-19 0:34 UTC (permalink / raw)
To: Chanwoo Choi
Cc: rydberg, andi.shyti, robh, arnd, chanwoo, inki.dae, sw0312.kim,
linux-input, linux-kernel, linux-samsung-soc, stable
On Wed, Oct 18, 2017 at 07:38:30PM +0900, Chanwoo Choi wrote:
> The commit 78bcac7b2ae1e ("Input: add support for the STMicroelectronics
> FingerTip touchscreen) used the 'touchscreen_parse_properties()' helper
> function in order to get the value of common properties.
>
> But, commit 78bcac7b2ae1e didn't set the capability of ABS_MT_POSITION_*
> before calling touchscreen_parse_properties(). In result, the max_x and max_y
> of 'struct touchscreen_propeties' were not set. So, this patch fixes the bug
> to get the ABS_MT_POSITION_* maximum size.
>
> Fixes: 78bcac7b2ae1e ("Input: add support for the STMicroelectronics FingerTip touchscreen")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/stmfts.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..8c6c6178ec12 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -663,12 +663,10 @@ static int stmfts_probe(struct i2c_client *client,
> sdata->input->open = stmfts_input_open;
> sdata->input->close = stmfts_input_close;
>
> + input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_X);
> + input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_Y);
> touchscreen_parse_properties(sdata->input, true, &sdata->prop);
>
> - input_set_abs_params(sdata->input, ABS_MT_POSITION_X, 0,
> - sdata->prop.max_x, 0, 0);
> - input_set_abs_params(sdata->input, ABS_MT_POSITION_Y, 0,
> - sdata->prop.max_y, 0, 0);
> input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
> input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
> input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-19 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171018103835epcas1p13ca5f794456313f91c427efdb17f8396@epcas1p1.samsung.com>
2017-10-18 10:38 ` [PATCH] Input: stmfts: Fix bug of ABS_MT_POSITION_* maximum size Chanwoo Choi
2017-10-19 0:34 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.