All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization
@ 2017-10-20 11:19 Lothar Felten
  2017-10-21  8:13 ` Thomas Petazzoni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lothar Felten @ 2017-10-20 11:19 UTC (permalink / raw)
  To: buildroot

The default for is set to BR2_OPTIMIZE_S, the help comment designated
BR2_OPTIMIZE_0 as default.
Changed the help comment to show that BR2_OPTIMIZE_S is the default.

Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
---
 Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Config.in b/Config.in
index 814dc02..9bdb0b8 100644
--- a/Config.in
+++ b/Config.in
@@ -458,7 +458,7 @@ choice
 config BR2_OPTIMIZE_0
 	bool "optimization level 0"
 	help
-	  Do not optimize. This is the default.
+	  Do not optimize.
 
 config BR2_OPTIMIZE_1
 	bool "optimization level 1"
@@ -525,6 +525,7 @@ config BR2_OPTIMIZE_S
 	  -falign-loops -falign-labels -freorder-blocks
 	  -freorder-blocks-and-partition -fprefetch-loop-arrays
 	  -ftree-vect-loop-version
+	  This is the default.
 
 endchoice
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization
  2017-10-20 11:19 [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization Lothar Felten
@ 2017-10-21  8:13 ` Thomas Petazzoni
  2017-10-22 22:47 ` Peter Korsgaard
  2017-10-24  6:36 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-10-21  8:13 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 20 Oct 2017 13:19:17 +0200, Lothar Felten wrote:
> The default for is set to BR2_OPTIMIZE_S, the help comment designated
> BR2_OPTIMIZE_0 as default.
> Changed the help comment to show that BR2_OPTIMIZE_S is the default.
> 
> Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
> ---
>  Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Impressive that this has been wrong for so long without being noticed.
Applied your patch, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization
  2017-10-20 11:19 [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization Lothar Felten
  2017-10-21  8:13 ` Thomas Petazzoni
@ 2017-10-22 22:47 ` Peter Korsgaard
  2017-10-24  6:36 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-10-22 22:47 UTC (permalink / raw)
  To: buildroot

>>>>> "Lothar" == Lothar Felten <lothar.felten@gmail.com> writes:

 > The default for is set to BR2_OPTIMIZE_S, the help comment designated
 > BR2_OPTIMIZE_0 as default.
 > Changed the help comment to show that BR2_OPTIMIZE_S is the default.

 > Signed-off-by: Lothar Felten <lothar.felten@gmail.com>

Committed to 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization
  2017-10-20 11:19 [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization Lothar Felten
  2017-10-21  8:13 ` Thomas Petazzoni
  2017-10-22 22:47 ` Peter Korsgaard
@ 2017-10-24  6:36 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2017-10-24  6:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Lothar" == Lothar Felten <lothar.felten@gmail.com> writes:

 > The default for is set to BR2_OPTIMIZE_S, the help comment designated
 > BR2_OPTIMIZE_0 as default.
 > Changed the help comment to show that BR2_OPTIMIZE_S is the default.

 > Signed-off-by: Lothar Felten <lothar.felten@gmail.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-24  6:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 11:19 [Buildroot] [PATCH 1/1] Config.in: fix help comment for gcc optimization Lothar Felten
2017-10-21  8:13 ` Thomas Petazzoni
2017-10-22 22:47 ` Peter Korsgaard
2017-10-24  6:36 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.