* [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)"
@ 2017-10-10 12:27 Cédric Le Goater
2017-10-11 5:38 ` Andrew Jeffery
2017-10-20 13:58 ` Andrew Jeffery
0 siblings, 2 replies; 4+ messages in thread
From: Cédric Le Goater @ 2017-10-10 12:27 UTC (permalink / raw)
To: openbmc; +Cc: Joel Stanley, Cédric Le Goater
This reverts commit a0ca4ecbeae4ae9632ebc67bf5318dd2ea09c94f.
Support was added to QEMU in :
commit 91db4642f868 ("target-arm: Add VBAR support to ARM1176 CPUs")
The work around happens to crash the guest when the vector relocation
is done, with ignore_memory_transaction_failures=false which is
now the default in QEMU.
---
arch/arm/lib/relocate.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S
index 33bcff41ac30..475d503dd9df 100644
--- a/arch/arm/lib/relocate.S
+++ b/arch/arm/lib/relocate.S
@@ -35,7 +35,7 @@ ENTRY(relocate_vectors)
ldr r1, =V7M_SCB_BASE
str r0, [r1, V7M_SCB_VTOR]
#else
-#if defined(CONFIG_HAS_VBAR) && !defined(CONFIG_ARCH_AST2500)
+#ifdef CONFIG_HAS_VBAR
/*
* If the ARM processor has the security extensions,
* use VBAR to relocate the exception vectors.
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)"
2017-10-10 12:27 [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)" Cédric Le Goater
@ 2017-10-11 5:38 ` Andrew Jeffery
2017-10-11 7:21 ` Cédric Le Goater
2017-10-20 13:58 ` Andrew Jeffery
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Jeffery @ 2017-10-11 5:38 UTC (permalink / raw)
To: Cédric Le Goater, openbmc
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On Tue, 2017-10-10 at 14:27 +0200, Cédric Le Goater wrote:
> This reverts commit a0ca4ecbeae4ae9632ebc67bf5318dd2ea09c94f.
>
> Support was added to QEMU in :
>
> commit 91db4642f868 ("target-arm: Add VBAR support to ARM1176 CPUs")
>
> The work around happens to crash the guest when the vector relocation
> is done, with ignore_memory_transaction_failures=false which is
> now the default in QEMU.
You need a Signed-off-by here. Can you reply with one? Hopefully patchwork will
pick it up.
Cheers,
Andrew
> ---
> arch/arm/lib/relocate.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S
> index 33bcff41ac30..475d503dd9df 100644
> --- a/arch/arm/lib/relocate.S
> +++ b/arch/arm/lib/relocate.S
> @@ -35,7 +35,7 @@ ENTRY(relocate_vectors)
> ldr r1, =V7M_SCB_BASE
> str r0, [r1, V7M_SCB_VTOR]
> #else
> -#if defined(CONFIG_HAS_VBAR) && !defined(CONFIG_ARCH_AST2500)
> +#ifdef CONFIG_HAS_VBAR
> /*
> * If the ARM processor has the security extensions,
> * use VBAR to relocate the exception vectors.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)"
2017-10-11 5:38 ` Andrew Jeffery
@ 2017-10-11 7:21 ` Cédric Le Goater
0 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2017-10-11 7:21 UTC (permalink / raw)
To: Andrew Jeffery, openbmc
On 10/11/2017 07:38 AM, Andrew Jeffery wrote:
> On Tue, 2017-10-10 at 14:27 +0200, Cédric Le Goater wrote:
>> This reverts commit a0ca4ecbeae4ae9632ebc67bf5318dd2ea09c94f.
>>
>> Support was added to QEMU in :
>>
>> commit 91db4642f868 ("target-arm: Add VBAR support to ARM1176 CPUs")
>>
>> The work around happens to crash the guest when the vector relocation
>> is done, with ignore_memory_transaction_failures=false which is
>> now the default in QEMU.
>
> You need a Signed-off-by here. Can you reply with one? Hopefully patchwork will
> pick it up.
Ah I missed that doing the revert.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
C.
> Cheers,
>
> Andrew
>
>> ---
>> arch/arm/lib/relocate.S | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S
>> index 33bcff41ac30..475d503dd9df 100644
>> --- a/arch/arm/lib/relocate.S
>> +++ b/arch/arm/lib/relocate.S
>> @@ -35,7 +35,7 @@ ENTRY(relocate_vectors)
>> ldr r1, =V7M_SCB_BASE
>> str r0, [r1, V7M_SCB_VTOR]
>> #else
>> -#if defined(CONFIG_HAS_VBAR) && !defined(CONFIG_ARCH_AST2500)
>> +#ifdef CONFIG_HAS_VBAR
>> /*
>> * If the ARM processor has the security extensions,
>> * use VBAR to relocate the exception vectors.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)"
2017-10-10 12:27 [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)" Cédric Le Goater
2017-10-11 5:38 ` Andrew Jeffery
@ 2017-10-20 13:58 ` Andrew Jeffery
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2017-10-20 13:58 UTC (permalink / raw)
To: Cédric Le Goater, openbmc
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On Tue, 2017-10-10 at 14:27 +0200, Cédric Le Goater wrote:
> This reverts commit a0ca4ecbeae4ae9632ebc67bf5318dd2ea09c94f.
>
> Support was added to QEMU in :
>
> commit 91db4642f868 ("target-arm: Add VBAR support to ARM1176 CPUs")
>
> The work around happens to crash the guest when the vector relocation
> is done, with ignore_memory_transaction_failures=false which is
> now the default in QEMU.
Applied to v2016.07-aspeed-openbmc with the Signed-off-by.
Cheers,
Andrew
> ---
> arch/arm/lib/relocate.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S
> index 33bcff41ac30..475d503dd9df 100644
> --- a/arch/arm/lib/relocate.S
> +++ b/arch/arm/lib/relocate.S
> @@ -35,7 +35,7 @@ ENTRY(relocate_vectors)
> > > ldr r1, =V7M_SCB_BASE
> > > str r0, [r1, V7M_SCB_VTOR]
> #else
> -#if defined(CONFIG_HAS_VBAR) && !defined(CONFIG_ARCH_AST2500)
> +#ifdef CONFIG_HAS_VBAR
> > /*
> > * If the ARM processor has the security extensions,
> > * use VBAR to relocate the exception vectors.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-20 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 12:27 [PATCH u-boot] Revert "ast-g5: deactivate vbar (for qemu)" Cédric Le Goater
2017-10-11 5:38 ` Andrew Jeffery
2017-10-11 7:21 ` Cédric Le Goater
2017-10-20 13:58 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.