All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] soc: mediatek: pwrap: fix compiler errors
@ 2017-10-21  8:25 ` Matthias Brugger
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-21  8:25 UTC (permalink / raw)
  To: sean.wang, chenglin.xu, chen.zhong, arvind.yadav.cs,
	christophe.jaillet, robh
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, Matthias Brugger

When compiling using sparse, we got the following error:
drivers/soc/mediatek/mtk-pmic-wrap.c:686:25: error: dubious one-bit signed bitfield

Changing the data type to unsigned fixes this.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 5d61d127e1d7..912edf93c192 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -683,7 +683,7 @@ struct pmic_wrapper_type {
 	u32 int_en_all;
 	u32 spi_w;
 	u32 wdt_src;
-	int has_bridge:1;
+	unsigned int has_bridge:1;
 	int (*init_reg_clock)(struct pmic_wrapper *wrp);
 	int (*init_soc_specific)(struct pmic_wrapper *wrp);
 };
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] soc: mediatek: pwrap: fix compiler errors
@ 2017-10-21  8:25 ` Matthias Brugger
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-21  8:25 UTC (permalink / raw)
  To: linux-arm-kernel

When compiling using sparse, we got the following error:
drivers/soc/mediatek/mtk-pmic-wrap.c:686:25: error: dubious one-bit signed bitfield

Changing the data type to unsigned fixes this.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 5d61d127e1d7..912edf93c192 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -683,7 +683,7 @@ struct pmic_wrapper_type {
 	u32 int_en_all;
 	u32 spi_w;
 	u32 wdt_src;
-	int has_bridge:1;
+	unsigned int has_bridge:1;
 	int (*init_reg_clock)(struct pmic_wrapper *wrp);
 	int (*init_soc_specific)(struct pmic_wrapper *wrp);
 };
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
  2017-10-21  8:25 ` Matthias Brugger
@ 2017-10-21  8:25   ` Matthias Brugger
  -1 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-21  8:25 UTC (permalink / raw)
  To: sean.wang, chenglin.xu, chen.zhong, arvind.yadav.cs,
	christophe.jaillet, robh
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, Matthias Brugger

When adding the MT6380 compatible, the sentinel for of_device_id was
deleted, which leades to the following compiler error:
FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!

Fix this by adding the sentinel again.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 912edf93c192..e9e054a15b7d 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
 	}, {
 		.compatible = "mediatek,mt6397",
 		.data = &pmic_mt6397,
+	}, {
 		/* sentinel */
 	}
 };
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-21  8:25   ` Matthias Brugger
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-21  8:25 UTC (permalink / raw)
  To: linux-arm-kernel

When adding the MT6380 compatible, the sentinel for of_device_id was
deleted, which leades to the following compiler error:
FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!

Fix this by adding the sentinel again.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 912edf93c192..e9e054a15b7d 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
 	}, {
 		.compatible = "mediatek,mt6397",
 		.data = &pmic_mt6397,
+	}, {
 		/* sentinel */
 	}
 };
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-22  4:23     ` Sean Wang
  0 siblings, 0 replies; 10+ messages in thread
From: Sean Wang @ 2017-10-22  4:23 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: chenglin.xu, chen.zhong, arvind.yadav.cs, christophe.jaillet,
	robh, linux-arm-kernel, linux-mediatek, linux-kernel

On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
> When adding the MT6380 compatible, the sentinel for of_device_id was
> deleted, which leades to the following compiler error:
> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
> 
> Fix this by adding the sentinel again.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 912edf93c192..e9e054a15b7d 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>  	}, {
>  		.compatible = "mediatek,mt6397",
>  		.data = &pmic_mt6397,
> +	}, {
>  		/* sentinel */
>  	}
>  };

Thanks for patching the mistaken edit I made.

Acked-by: Sean Wang <sean.wang@mediatek.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-22  4:23     ` Sean Wang
  0 siblings, 0 replies; 10+ messages in thread
From: Sean Wang @ 2017-10-22  4:23 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: robh-DgEjT+Ai2ygdnm+yROfE0A, chenglin.xu-NuS5LvNUpcJWk0Htik3J/w,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	christophe.jaillet-39ZsbGIQGT5GWvitb5QawA,
	arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w,
	chen.zhong-NuS5LvNUpcJWk0Htik3J/w,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
> When adding the MT6380 compatible, the sentinel for of_device_id was
> deleted, which leades to the following compiler error:
> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
> 
> Fix this by adding the sentinel again.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 912edf93c192..e9e054a15b7d 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>  	}, {
>  		.compatible = "mediatek,mt6397",
>  		.data = &pmic_mt6397,
> +	}, {
>  		/* sentinel */
>  	}
>  };

Thanks for patching the mistaken edit I made.

Acked-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-22  4:23     ` Sean Wang
  0 siblings, 0 replies; 10+ messages in thread
From: Sean Wang @ 2017-10-22  4:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
> When adding the MT6380 compatible, the sentinel for of_device_id was
> deleted, which leades to the following compiler error:
> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
> 
> Fix this by adding the sentinel again.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 912edf93c192..e9e054a15b7d 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>  	}, {
>  		.compatible = "mediatek,mt6397",
>  		.data = &pmic_mt6397,
> +	}, {
>  		/* sentinel */
>  	}
>  };

Thanks for patching the mistaken edit I made.

Acked-by: Sean Wang <sean.wang@mediatek.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
  2017-10-22  4:23     ` Sean Wang
  (?)
@ 2017-10-22 10:02       ` Matthias Brugger
  -1 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-22 10:02 UTC (permalink / raw)
  To: Sean Wang
  Cc: chenglin.xu, chen.zhong, arvind.yadav.cs, christophe.jaillet,
	robh, linux-arm-kernel, linux-mediatek, linux-kernel



On 10/22/2017 06:23 AM, Sean Wang wrote:
> On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
>> When adding the MT6380 compatible, the sentinel for of_device_id was
>> deleted, which leades to the following compiler error:
>> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
>>
>> Fix this by adding the sentinel again.
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>   drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index 912edf93c192..e9e054a15b7d 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>>   	}, {
>>   		.compatible = "mediatek,mt6397",
>>   		.data = &pmic_mt6397,
>> +	}, {
>>   		/* sentinel */
>>   	}
>>   };
> 
> Thanks for patching the mistaken edit I made.
> 
> Acked-by: Sean Wang <sean.wang@mediatek.com>
> 
> 

Thanks, both patches pushed to v4.14-next/soc

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-22 10:02       ` Matthias Brugger
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-22 10:02 UTC (permalink / raw)
  To: Sean Wang
  Cc: robh, chenglin.xu, linux-mediatek, linux-kernel,
	christophe.jaillet, arvind.yadav.cs, chen.zhong,
	linux-arm-kernel



On 10/22/2017 06:23 AM, Sean Wang wrote:
> On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
>> When adding the MT6380 compatible, the sentinel for of_device_id was
>> deleted, which leades to the following compiler error:
>> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
>>
>> Fix this by adding the sentinel again.
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>   drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index 912edf93c192..e9e054a15b7d 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>>   	}, {
>>   		.compatible = "mediatek,mt6397",
>>   		.data = &pmic_mt6397,
>> +	}, {
>>   		/* sentinel */
>>   	}
>>   };
> 
> Thanks for patching the mistaken edit I made.
> 
> Acked-by: Sean Wang <sean.wang@mediatek.com>
> 
> 

Thanks, both patches pushed to v4.14-next/soc

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
@ 2017-10-22 10:02       ` Matthias Brugger
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2017-10-22 10:02 UTC (permalink / raw)
  To: linux-arm-kernel



On 10/22/2017 06:23 AM, Sean Wang wrote:
> On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
>> When adding the MT6380 compatible, the sentinel for of_device_id was
>> deleted, which leades to the following compiler error:
>> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
>>
>> Fix this by adding the sentinel again.
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>   drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index 912edf93c192..e9e054a15b7d 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>>   	}, {
>>   		.compatible = "mediatek,mt6397",
>>   		.data = &pmic_mt6397,
>> +	}, {
>>   		/* sentinel */
>>   	}
>>   };
> 
> Thanks for patching the mistaken edit I made.
> 
> Acked-by: Sean Wang <sean.wang@mediatek.com>
> 
> 

Thanks, both patches pushed to v4.14-next/soc

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-10-22 10:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-21  8:25 [PATCH 1/2] soc: mediatek: pwrap: fix compiler errors Matthias Brugger
2017-10-21  8:25 ` Matthias Brugger
2017-10-21  8:25 ` [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error Matthias Brugger
2017-10-21  8:25   ` Matthias Brugger
2017-10-22  4:23   ` Sean Wang
2017-10-22  4:23     ` Sean Wang
2017-10-22  4:23     ` Sean Wang
2017-10-22 10:02     ` Matthias Brugger
2017-10-22 10:02       ` Matthias Brugger
2017-10-22 10:02       ` Matthias Brugger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.