All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhc@lemote.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Fuxin Zhang <zhangfx@lemote.com>,
	linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <james.hogan@imgtec.com>,
	linux-mips@linux-mips.org,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, Huacai Chen <chenhc@lemote.com>,
	stable@vger.kernel.org
Subject: [PATCH V9 3/4] scsi: Align block queue to dma_get_cache_alignment()
Date: Mon, 23 Oct 2017 15:12:46 +0800	[thread overview]
Message-ID: <1508742767-28366-3-git-send-email-chenhc@lemote.com> (raw)
In-Reply-To: <1508742767-28366-1-git-send-email-chenhc@lemote.com>

In non-coherent DMA mode, kernel uses cache flushing operations to
maintain I/O coherency, so scsi's block queue should be aligned to
ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer and a kernel structure
share a same cache line, and if the kernel structure has dirty data,
cache_invalidate (no writeback) will cause data corruption.

Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 drivers/scsi/scsi_lib.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 9cf6a80..19abc2e 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -2132,11 +2132,11 @@ void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)
 		q->limits.cluster = 0;
 
 	/*
-	 * set a reasonable default alignment on word boundaries: the
-	 * host and device may alter it using
+	 * set a reasonable default alignment on word/cacheline boundaries:
+	 * the host and device may alter it using
 	 * blk_queue_update_dma_alignment() later.
 	 */
-	blk_queue_dma_alignment(q, 0x03);
+	blk_queue_dma_alignment(q, max(4, dma_get_cache_alignment(dev)) - 1);
 }
 EXPORT_SYMBOL_GPL(__scsi_init_queue);
 
-- 
2.7.0

  parent reply	other threads:[~2017-10-23  7:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171023071025epcas4p3e9b9c0af7c0a34561f0d57a20a4f9946@epcas4p3.samsung.com>
2017-10-23  7:12 ` [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment() Huacai Chen
2017-10-23  7:12   ` Huacai Chen
2017-10-23  7:12   ` [PATCH V9 2/4] MIPS: Implement dma_map_ops::get_cache_alignment() Huacai Chen
2017-11-06 18:21     ` Christoph Hellwig
2017-10-23  7:12   ` Huacai Chen [this message]
2017-11-05  2:39     ` [PATCH V9 3/4] scsi: Align block queue to dma_get_cache_alignment() kbuild test robot
2017-11-05  2:39       ` kbuild test robot
2017-11-05  2:39       ` kbuild test robot
2017-10-23  7:12   ` [PATCH V9 4/4] libsas: Align sata_device's rps_resp on a cacheline Huacai Chen
2017-10-24 13:30   ` [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment() Marek Szyprowski
2017-10-24 13:30     ` Marek Szyprowski
2017-10-25  1:22     ` 陈华才
2017-10-25  1:22       ` 陈华才
2017-10-25  7:21       ` Marek Szyprowski
2017-10-25  7:21         ` Marek Szyprowski
2017-10-26  6:33         ` 陈华才
2017-10-26  6:33           ` 陈华才
2017-11-03  4:48           ` 陈华才
2017-11-03  4:48             ` 陈华才
2017-11-03  5:14             ` Christoph Hellwig
2017-11-03  5:14               ` Christoph Hellwig
2017-11-03  6:15               ` 陈华才
2017-11-03  6:15                 ` 陈华才
2017-10-24 19:11   ` Mark Greer
2017-10-24 19:11     ` Mark Greer
2017-11-06 18:18   ` Christoph Hellwig
2017-11-06 18:18     ` Christoph Hellwig
2017-11-10 12:30   ` Christoph Hellwig
2017-11-10 12:30     ` Christoph Hellwig
2017-11-13  8:37     ` 陈华才
2017-11-13  8:37       ` 陈华才

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508742767-28366-3-git-send-email-chenhc@lemote.com \
    --to=chenhc@lemote.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=james.hogan@imgtec.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.petersen@oracle.com \
    --cc=ralf@linux-mips.org \
    --cc=robin.murphy@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.