* [PATCH] ACPICA: Clean up whitespace of indentation
@ 2017-10-28 1:34 Baoquan He
2017-11-07 10:43 ` Baoquan He
0 siblings, 1 reply; 4+ messages in thread
From: Baoquan He @ 2017-10-28 1:34 UTC (permalink / raw)
To: linux-kernel, linux-acpi; +Cc: rjw, lenb, robert.moore, lv.zheng, Baoquan He
Use tabs (not spaces) for indentation.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
include/acpi/actbl1.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index 6b8714a428b6..d8a4fc066abe 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
u16 reserved; /* Reserved, must be zero */
u64 base_address;
u64 length;
- u32 reserved1;
+ u32 reserved1;
u32 flags;
- u64 reserved2; /* Reserved, must be zero */
+ u64 reserved2; /* Reserved, must be zero */
};
/* Flags */
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPICA: Clean up whitespace of indentation
2017-10-28 1:34 [PATCH] ACPICA: Clean up whitespace of indentation Baoquan He
@ 2017-11-07 10:43 ` Baoquan He
2017-11-07 15:09 ` Moore, Robert
0 siblings, 1 reply; 4+ messages in thread
From: Baoquan He @ 2017-11-07 10:43 UTC (permalink / raw)
To: linux-kernel, linux-acpi; +Cc: rjw, lenb, robert.moore, lv.zheng
PING!
On 10/28/17 at 09:34am, Baoquan He wrote:
> Use tabs (not spaces) for indentation.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> include/acpi/actbl1.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 6b8714a428b6..d8a4fc066abe 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> u16 reserved; /* Reserved, must be zero */
> u64 base_address;
> u64 length;
> - u32 reserved1;
> + u32 reserved1;
> u32 flags;
> - u64 reserved2; /* Reserved, must be zero */
> + u64 reserved2; /* Reserved, must be zero */
> };
>
> /* Flags */
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ACPICA: Clean up whitespace of indentation
2017-11-07 10:43 ` Baoquan He
@ 2017-11-07 15:09 ` Moore, Robert
2017-11-08 2:10 ` Baoquan He
0 siblings, 1 reply; 4+ messages in thread
From: Moore, Robert @ 2017-11-07 15:09 UTC (permalink / raw)
To: Baoquan He, linux-kernel, linux-acpi; +Cc: rjw, lenb, Schmauss, Erik
Anything like this probably happens during the conversion of ACPICA code to Linux-style code. This conversion happens after every release (monthly) of ACPICA.
Specifically indent/lindent seems to do things like this, if I remember correctly.
> -----Original Message-----
> From: Baoquan He [mailto:bhe@redhat.com]
> Sent: Tuesday, November 7, 2017 2:43 AM
> To: linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org
> Cc: rjw@rjwysocki.net; lenb@kernel.org; Moore, Robert
> <robert.moore@intel.com>; Zheng, Lv <lv.zheng@intel.com>
> Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation
>
> PING!
>
> On 10/28/17 at 09:34am, Baoquan He wrote:
> > Use tabs (not spaces) for indentation.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > include/acpi/actbl1.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > 6b8714a428b6..d8a4fc066abe 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> > u16 reserved; /* Reserved, must be zero */
> > u64 base_address;
> > u64 length;
> > - u32 reserved1;
> > + u32 reserved1;
> > u32 flags;
> > - u64 reserved2; /* Reserved, must be zero */
> > + u64 reserved2; /* Reserved, must be zero */
> > };
> >
> > /* Flags */
> > --
> > 2.5.5
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPICA: Clean up whitespace of indentation
2017-11-07 15:09 ` Moore, Robert
@ 2017-11-08 2:10 ` Baoquan He
0 siblings, 0 replies; 4+ messages in thread
From: Baoquan He @ 2017-11-08 2:10 UTC (permalink / raw)
To: Moore, Robert; +Cc: linux-kernel, linux-acpi, rjw, lenb, Schmauss, Erik
On 11/07/17 at 03:09pm, Moore, Robert wrote:
> Anything like this probably happens during the conversion of ACPICA code to Linux-style code. This conversion happens after every release (monthly) of ACPICA.
>
> Specifically indent/lindent seems to do things like this, if I remember correctly.
I found it when went through system init code, it was introduced in this
commit and looks very obvious:
commit 19d0cfe9ddfdf7afa8d1765ab0bd2a7dd30e47c9
Author: Bob Moore <robert.moore@intel.com>
Date: Tue Jun 10 15:54:40 2008 +0800
ACPICA: Update DMAR and SRAT table definitions
If there has been a mechanism to check them, I am fine to leave it as is
or the tools like lindent to deal with it.
Thanks
Baoquan
>
> > -----Original Message-----
> > From: Baoquan He [mailto:bhe@redhat.com]
> > Sent: Tuesday, November 7, 2017 2:43 AM
> > To: linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org
> > Cc: rjw@rjwysocki.net; lenb@kernel.org; Moore, Robert
> > <robert.moore@intel.com>; Zheng, Lv <lv.zheng@intel.com>
> > Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation
> >
> > PING!
> >
> > On 10/28/17 at 09:34am, Baoquan He wrote:
> > > Use tabs (not spaces) for indentation.
> > >
> > > Signed-off-by: Baoquan He <bhe@redhat.com>
> > > ---
> > > include/acpi/actbl1.h | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > > 6b8714a428b6..d8a4fc066abe 100644
> > > --- a/include/acpi/actbl1.h
> > > +++ b/include/acpi/actbl1.h
> > > @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> > > u16 reserved; /* Reserved, must be zero */
> > > u64 base_address;
> > > u64 length;
> > > - u32 reserved1;
> > > + u32 reserved1;
> > > u32 flags;
> > > - u64 reserved2; /* Reserved, must be zero */
> > > + u64 reserved2; /* Reserved, must be zero */
> > > };
> > >
> > > /* Flags */
> > > --
> > > 2.5.5
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 2:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-28 1:34 [PATCH] ACPICA: Clean up whitespace of indentation Baoquan He
2017-11-07 10:43 ` Baoquan He
2017-11-07 15:09 ` Moore, Robert
2017-11-08 2:10 ` Baoquan He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.