All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next v4 0/3] Completed requested changes
@ 2017-10-31 18:14 Manish Kurup
  2017-11-01  2:02 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Manish Kurup @ 2017-10-31 18:14 UTC (permalink / raw)
  To: jhs, xiyou.wangcong, jiri, jakub.kicinski, simon.horman,
	pieter.jansenvanvuuren, john.hurley, oss-drivers, davem, netdev
  Cc: aring, mrv, kurup.manish, Manish Kurup

Hi everyone,

Modified the netronome drivers (flower action) to use the VLAN helper functions
instead of dereferencing the structure directly. This is required for the VLAN
action patch.

Could you please review?

Here're the changes:
v2: Fixed all helper functions to use RCU (rtnl_dereference) - Eric, Jamal
v2: Fixed indentation, extra line nits - Jamal, Jiri
v2: Moved rcu_head to the end of the struct - Jiri
v2: Re-formatted locals to reverse-christmas-tree - Jiri
v2: Removed mismatched spin_lock() - Cong
v2: Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should
    suffice - Cong, Jiri
v4: Modified the nfp flower action code to use the VLAN helper functions
    instead of referencing the structure directly. Isolated this into a
    separate patch - Pieter Jansen

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Manish Kurup <manish.kurup@verizon.com>

Manish Kurup (3):
  net sched act_vlan: Change stats update to use per-core stats
  drivers net ethernet netronome nfp flower: netronome nfp flower action
  net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and
    update

 drivers/net/ethernet/netronome/nfp/flower/action.c |  5 +-
 include/net/tc_act/tc_vlan.h                       | 46 +++++++++++---
 net/sched/act_vlan.c                               | 71 ++++++++++++++--------
 3 files changed, 84 insertions(+), 38 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next v4 0/3] Completed requested changes
  2017-10-31 18:14 [PATCH net-next v4 0/3] Completed requested changes Manish Kurup
@ 2017-11-01  2:02 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-01  2:02 UTC (permalink / raw)
  To: kurup.manish
  Cc: jhs, xiyou.wangcong, jiri, jakub.kicinski, simon.horman,
	pieter.jansenvanvuuren, john.hurley, oss-drivers, netdev, aring,
	mrv, manish.kurup

From: Manish Kurup <kurup.manish@gmail.com>
Date: Tue, 31 Oct 2017 14:14:28 -0400

> Modified the netronome drivers (flower action) to use the VLAN helper functions
> instead of dereferencing the structure directly. This is required for the VLAN
> action patch.
> 
> Could you please review?

Please simplify the subsystem prefixes in your Subject lines, they are
very long.

"act_vlan: " and "nfp: " are more than sufficient.

Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-01  2:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 18:14 [PATCH net-next v4 0/3] Completed requested changes Manish Kurup
2017-11-01  2:02 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.