All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] USB: serial: option: add Novatel USB730L enterprise mode
       [not found] ` <20171030142309.GI7223@localhost>
@ 2017-10-31 16:54   ` Gal Shalif
  2017-10-31 18:54     ` Johan Hovold
  0 siblings, 1 reply; 3+ messages in thread
From: Gal Shalif @ 2017-10-31 16:54 UTC (permalink / raw)
  To: Johan Hovold, Gal Shalif
  Cc: Bjørn Mork, Oliver Neukum, linux-usb, Gal Shalif, stable

>From 436a7eb28215081d34c386a92213bd6932d0779a Mon Sep 17 00:00:00 2001
From: Gal Shalif <gals@liveu.tv>
Date: Tue, 31 Oct 2017 18:00:36 +0200
Subject: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode

Add the serial interface of the Novatel USB730L
enterprise mode.
Change is done according to:
  Novatel Linux Integration Guide for USB730L at:
  https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf

Signed-off-by: Gal Shalif <gal@shalif.com>
Cc: Gal Shalif Work <gals@liveu.tv>
Cc: Bjorn Mork <bjorn@mork.no>
Cc: Oliver Neukum <oneukum@suse.com>
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git drivers/usb/serial/option.c drivers/usb/serial/option.c
index ba672cf..5ea9fa5 100644
--- drivers/usb/serial/option.c
+++ drivers/usb/serial/option.c
@@ -162,6 +162,7 @@ static void option_instat_callback(struct urb *urb);
 #define NOVATELWIRELESS_PRODUCT_E362		0x9010
 #define NOVATELWIRELESS_PRODUCT_E371		0x9011
 #define NOVATELWIRELESS_PRODUCT_U620L		0x9022
+#define NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L 0x9032
 #define NOVATELWIRELESS_PRODUCT_G2		0xA010
 #define NOVATELWIRELESS_PRODUCT_MC551		0xB001
 
@@ -1121,6 +1122,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L, 0xff, 0x00, 0x00) },
 
 	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
 	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode
  2017-10-31 16:54   ` [PATCH] USB: serial: option: add Novatel USB730L enterprise mode Gal Shalif
@ 2017-10-31 18:54     ` Johan Hovold
  2017-11-01 18:00       ` Gal Shalif
  0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2017-10-31 18:54 UTC (permalink / raw)
  To: Gal Shalif
  Cc: Johan Hovold, Gal Shalif, Bjørn Mork, Oliver Neukum,
	linux-usb, stable

On Tue, Oct 31, 2017 at 04:54:56PM +0000, Gal Shalif wrote:
> From 436a7eb28215081d34c386a92213bd6932d0779a Mon Sep 17 00:00:00 2001
> From: Gal Shalif <gals@liveu.tv>
> Date: Tue, 31 Oct 2017 18:00:36 +0200
> Subject: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode
> 
> Add the serial interface of the Novatel USB730L
> enterprise mode.
> Change is done according to:
>   Novatel Linux Integration Guide for USB730L at:
>   https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf
> 
> Signed-off-by: Gal Shalif <gal@shalif.com>

Your SoB should match the From: field.

> Cc: Gal Shalif Work <gals@liveu.tv>
> Cc: Bjorn Mork <bjorn@mork.no>
> Cc: Oliver Neukum <oneukum@suse.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>

And you must never add someone else's SoB (I'll add that myself when I
apply the patch).

> ---
>  drivers/usb/serial/option.c | 2 ++

Also this is a p0 patch so fails to apply without some manual
intervention.

You could try using git-format-patch and git-send-email and send the
patch to yourself first to make sure it applies using git-am.

>  1 file changed, 2 insertions(+)
> 
> diff --git drivers/usb/serial/option.c drivers/usb/serial/option.c
> index ba672cf..5ea9fa5 100644
> --- drivers/usb/serial/option.c
> +++ drivers/usb/serial/option.c
> @@ -162,6 +162,7 @@ static void option_instat_callback(struct urb *urb);
>  #define NOVATELWIRELESS_PRODUCT_E362		0x9010
>  #define NOVATELWIRELESS_PRODUCT_E371		0x9011
>  #define NOVATELWIRELESS_PRODUCT_U620L		0x9022
> +#define NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L 0x9032
>  #define NOVATELWIRELESS_PRODUCT_G2		0xA010
>  #define NOVATELWIRELESS_PRODUCT_MC551		0xB001
>  
> @@ -1121,6 +1122,7 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L, 0xff, 0x00, 0x00) },
>  
>  	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
>  	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },

Other than that, this looks to good to me. Perhaps you could include the
output of usb-devices for reference as well.

Care to send a v2 with the right Signed-off-by?

Thanks,
Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] USB: serial: option: add Novatel USB730L enterprise mode
  2017-10-31 18:54     ` Johan Hovold
@ 2017-11-01 18:00       ` Gal Shalif
  0 siblings, 0 replies; 3+ messages in thread
From: Gal Shalif @ 2017-11-01 18:00 UTC (permalink / raw)
  Cc: Gal Shalif, Gal Shalif, Oliver Neukum, stable

From: Gal Shalif <gals@liveu.tv>

Add the serial interface of the Novatel USB730L
enterprise mode.
Change is done according to:
  Novatel Linux Integration Guide for USB730L at:
  https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf
usb-devices after apply of change:
  T:  Bus=01 Lev=03 Prnt=03 Port=01 Cnt=01 Dev#=126 Spd=480 MxCh= 0
  D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
  P:  Vendor=1410 ProdID=9032 Rev=03.10
  S:  Manufacturer=Novatel Wireless
  S:  Product=MiFi USB730L
  S:  SerialNumber=0123456789ABCDEF
  C:  #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=500mA
  I:  If#= 0 Alt= 0 #EPs= 1 Cls=ef(misc ) Sub=04 Prot=01 Driver=rndis_host
  I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host
  I:  If#= 2 Alt= 0 #EPs= 1 Cls=03(HID  ) Sub=00 Prot=00 Driver=(usbhid)
  I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option

Signed-off-by: Gal Shalif <gal@shalif.com>
To: Bjorn Mork <bjorn@mork.no>
Cc: Oliver Neukum <oneukum@suse.com>
Cc: stable@vger.kernel.org
Cc: Gal Shalif Work <gals@liveu.tv>
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git drivers/usb/serial/option.c drivers/usb/serial/option.c
index ba672cf..5ea9fa5 100644
--- drivers/usb/serial/option.c
+++ drivers/usb/serial/option.c
@@ -162,6 +162,7 @@ static void option_instat_callback(struct urb *urb);
 #define NOVATELWIRELESS_PRODUCT_E362		0x9010
 #define NOVATELWIRELESS_PRODUCT_E371		0x9011
 #define NOVATELWIRELESS_PRODUCT_U620L		0x9022
+#define NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L 0x9032
 #define NOVATELWIRELESS_PRODUCT_G2		0xA010
 #define NOVATELWIRELESS_PRODUCT_MC551		0xB001
 
@@ -1121,6 +1122,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L, 0xff, 0x00, 0x00) },
 
 	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) },
 	{ USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) },
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-01 18:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <HE1PR02MB0953509CEB600D5D6ACD57E0AC590@HE1PR02MB0953.eurprd02.prod.outlook.com>
     [not found] ` <20171030142309.GI7223@localhost>
2017-10-31 16:54   ` [PATCH] USB: serial: option: add Novatel USB730L enterprise mode Gal Shalif
2017-10-31 18:54     ` Johan Hovold
2017-11-01 18:00       ` Gal Shalif

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.