[U-Boot] [PATCH v4 1/2] armv8: lsch3: Add imply SCSI for ls1088

[U-Boot] [PATCH v4 1/2] armv8: lsch3: Add imply SCSI for ls1088

[Ashish Kumar]

Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
---

v3: Change SCSI command to imply SCSI
v4: No change

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
index 8bbc981..5daf79e 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
@@ -84,6 +84,7 @@ config ARCH_LS1088A
 	select FSL_TZASC_1
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
+	imply SCSI
 
 config ARCH_LS2080A
 	bool
-- 
2.7.4

[U-Boot] [PATCH v4 2/2] armv8: ls1088: Enable SATA for ls1088

[Ashish Kumar]

Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
---
v2: Rebase to top
v3: Consolidate defines in common file
v4: Protect define using CONFIG_SCSI

 include/configs/ls1088a_common.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/configs/ls1088a_common.h b/include/configs/ls1088a_common.h
index fa058f7..7cfdc96 100644
--- a/include/configs/ls1088a_common.h
+++ b/include/configs/ls1088a_common.h
@@ -148,6 +148,19 @@ unsigned long long get_qixis_addr(void);
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LOAD_ADDR	(CONFIG_SYS_DDR_SDRAM_BASE + 0x10000000)
 
+/* SATA */
+#ifdef CONFIG_SCSI
+#define CONFIG_LIBATA
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+#define CONFIG_SYS_SATA1		AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID	1
+#define CONFIG_SYS_SCSI_MAX_LUN		1
+#define CONFIG_SYS_SCSI_MAX_DEVICE	(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+					CONFIG_SYS_SCSI_MAX_LUN)
+#endif
+
 /* Physical Memory Map */
 #define CONFIG_CHIP_SELECTS_PER_CTRL	4
 
-- 
2.7.4

[U-Boot] [PATCH v4 2/2] armv8: ls1088: Enable SATA for ls1088

[York Sun]

On 11/01/2017 09:20 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
> ---
> v2: Rebase to top
> v3: Consolidate defines in common file
> v4: Protect define using CONFIG_SCSI
> 

Andy,

Does this set represent the latest change you and Ashish agreed on?
Please give your review comment.

York

[U-Boot] [PATCH v4 1/2] armv8: lsch3: Add imply SCSI for ls1088

[York Sun]

On 11/01/2017 09:20 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---
> 
> v3: Change SCSI command to imply SCSI
> v4: No change
> 
>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> index 8bbc981..5daf79e 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> @@ -84,6 +84,7 @@ config ARCH_LS1088A
>  	select FSL_TZASC_1
>  	select ARCH_EARLY_INIT_R
>  	select BOARD_EARLY_INIT_F
> +	imply SCSI
>  
>  config ARCH_LS2080A
>  	bool
> 

Did you test this patch alone? It causes compiling error for all LS1088
boards. You cannot enable CONFIG_SCSI without adding proper macros as
you did in your patch #2. I will squash these two patches for you. No
action required.

York

[U-Boot] [PATCH v4 2/2] armv8: ls1088: Enable SATA for ls1088

[York Sun]

On 11/01/2017 09:20 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> Signed-off-by: Amrita Kumari <amrita.kumari@nxp.com>
> ---
> v2: Rebase to top
> v3: Consolidate defines in common file
> v4: Protect define using CONFIG_SCSI

Squashed with patch #1.
Applied to fsl-qoriq master. Thanks.

York