* [PATCH net-next] phylink: make local function phylink_phy_change() static
@ 2017-11-02 11:14 Wei Yongjun
2017-11-04 13:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-11-02 11:14 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli; +Cc: Wei Yongjun, netdev
Fixes the following sparse warnings:
drivers/net/phy/phylink.c:570:6: warning:
symbol 'phylink_phy_change' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/phy/phylink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 05c8f1c..e3bbc70 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -567,7 +567,8 @@ void phylink_destroy(struct phylink *pl)
}
EXPORT_SYMBOL_GPL(phylink_destroy);
-void phylink_phy_change(struct phy_device *phydev, bool up, bool do_carrier)
+static void phylink_phy_change(struct phy_device *phydev, bool up,
+ bool do_carrier)
{
struct phylink *pl = phydev->phylink;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] phylink: make local function phylink_phy_change() static
2017-11-02 11:14 [PATCH net-next] phylink: make local function phylink_phy_change() static Wei Yongjun
@ 2017-11-04 13:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-04 13:32 UTC (permalink / raw)
To: weiyongjun1; +Cc: andrew, f.fainelli, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Thu, 2 Nov 2017 11:14:48 +0000
> Fixes the following sparse warnings:
>
> drivers/net/phy/phylink.c:570:6: warning:
> symbol 'phylink_phy_change' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you Wei.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-04 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 11:14 [PATCH net-next] phylink: make local function phylink_phy_change() static Wei Yongjun
2017-11-04 13:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.