* Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree
@ 2017-11-05 14:44 gregkh
2017-11-07 0:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: gregkh @ 2017-11-05 14:44 UTC (permalink / raw)
To: t-kristo, gregkh, rafael.j.wysocki; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
PM / QoS: Fix default runtime_pm device resume latency
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pm-qos-fix-default-runtime_pm-device-resume-latency.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
From: Tero Kristo <t-kristo@ti.com>
Date: Mon, 30 Oct 2017 09:10:46 +0200
Subject: PM / QoS: Fix default runtime_pm device resume latency
From: Tero Kristo <t-kristo@ti.com>
commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.
The recent change to the PM QoS framework to introduce a proper
no constraint value overlooked to handle the devices which don't
implement PM QoS OPS. Runtime PM is one of the more severely
impacted subsystems, failing every attempt to runtime suspend
a device. This leads into some nasty second level issues like
probe failures and increased power consumption among other
things.
Fix this by adding a proper return value for devices that don't
implement PM QoS.
Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/linux/pm_qos.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/include/linux/pm_qos.h
+++ b/include/linux/pm_qos.h
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
{
return IS_ERR_OR_NULL(dev->power.qos) ?
- 0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+ PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+ pm_qos_read_value(&dev->power.qos->resume_latency);
}
#else
static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
Patches currently in stable-queue which might be from t-kristo@ti.com are
queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree
2017-11-05 14:44 Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree gregkh
@ 2017-11-07 0:49 ` Rafael J. Wysocki
2017-11-07 10:32 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-11-07 0:49 UTC (permalink / raw)
To: gregkh; +Cc: t-kristo, stable, stable-commits
On 11/5/2017 3:44 PM, gregkh@linuxfoundation.org wrote:
> This is a note to let you know that I've just added the patch titled
>
> PM / QoS: Fix default runtime_pm device resume latency
>
> to the 4.13-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> pm-qos-fix-default-runtime_pm-device-resume-latency.patch
> and it can be found in the queue-4.13 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
> From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
> From: Tero Kristo <t-kristo@ti.com>
> Date: Mon, 30 Oct 2017 09:10:46 +0200
> Subject: PM / QoS: Fix default runtime_pm device resume latency
>
> From: Tero Kristo <t-kristo@ti.com>
>
> commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.
>
> The recent change to the PM QoS framework to introduce a proper
> no constraint value overlooked to handle the devices which don't
> implement PM QoS OPS. Runtime PM is one of the more severely
> impacted subsystems, failing every attempt to runtime suspend
> a device. This leads into some nasty second level issues like
> probe failures and increased power consumption among other
> things.
>
> Fix this by adding a proper return value for devices that don't
> implement PM QoS.
>
> Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> include/linux/pm_qos.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/include/linux/pm_qos.h
> +++ b/include/linux/pm_qos.h
> @@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
> static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
> {
> return IS_ERR_OR_NULL(dev->power.qos) ?
> - 0 : pm_qos_read_value(&dev->power.qos->resume_latency);
> + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
> + pm_qos_read_value(&dev->power.qos->resume_latency);
> }
> #else
> static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
>
>
> Patches currently in stable-queue which might be from t-kristo@ti.com are
>
> queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch
Please drop this from the -stable queue, it has been reverted from the
mainline.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree
2017-11-07 0:49 ` Rafael J. Wysocki
@ 2017-11-07 10:32 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-11-07 10:32 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: t-kristo, stable, stable-commits
On Tue, Nov 07, 2017 at 01:49:03AM +0100, Rafael J. Wysocki wrote:
> On 11/5/2017 3:44 PM, gregkh@linuxfoundation.org wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > PM / QoS: Fix default runtime_pm device resume latency
> >
> > to the 4.13-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > pm-qos-fix-default-runtime_pm-device-resume-latency.patch
> > and it can be found in the queue-4.13 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> >
> >
> > From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
> > From: Tero Kristo <t-kristo@ti.com>
> > Date: Mon, 30 Oct 2017 09:10:46 +0200
> > Subject: PM / QoS: Fix default runtime_pm device resume latency
> >
> > From: Tero Kristo <t-kristo@ti.com>
> >
> > commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.
> >
> > The recent change to the PM QoS framework to introduce a proper
> > no constraint value overlooked to handle the devices which don't
> > implement PM QoS OPS. Runtime PM is one of the more severely
> > impacted subsystems, failing every attempt to runtime suspend
> > a device. This leads into some nasty second level issues like
> > probe failures and increased power consumption among other
> > things.
> >
> > Fix this by adding a proper return value for devices that don't
> > implement PM QoS.
> >
> > Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> > include/linux/pm_qos.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --- a/include/linux/pm_qos.h
> > +++ b/include/linux/pm_qos.h
> > @@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
> > static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
> > {
> > return IS_ERR_OR_NULL(dev->power.qos) ?
> > - 0 : pm_qos_read_value(&dev->power.qos->resume_latency);
> > + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
> > + pm_qos_read_value(&dev->power.qos->resume_latency);
> > }
> > #else
> > static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
> >
> >
> > Patches currently in stable-queue which might be from t-kristo@ti.com are
> >
> > queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch
>
> Please drop this from the -stable queue, it has been reverted from the
> mainline.
Ah, thanks for letting me know, now dropped.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-07 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 14:44 Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree gregkh
2017-11-07 0:49 ` Rafael J. Wysocki
2017-11-07 10:32 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.