* [PATCH net-next] dpaa_eth: fix error return code in dpaa_eth_probe()
@ 2017-11-06 11:12 Wei Yongjun
2017-11-08 4:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-11-06 11:12 UTC (permalink / raw)
To: Madalin Bucur; +Cc: Wei Yongjun, netdev
Fix to return a negative error code from the dpaa_bp_alloc() error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index ebc55b6..6a05c6d 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2728,11 +2728,11 @@ static int dpaa_eth_probe(struct platform_device *pdev)
/* bp init */
for (i = 0; i < DPAA_BPS_NUM; i++) {
- int err;
-
dpaa_bps[i] = dpaa_bp_alloc(dev);
- if (IS_ERR(dpaa_bps[i]))
+ if (IS_ERR(dpaa_bps[i])) {
+ err = PTR_ERR(dpaa_bps[i]);
goto free_dpaa_bps;
+ }
/* the raw size of the buffers used for reception */
dpaa_bps[i]->raw_size = bpool_buffer_raw_size(i, DPAA_BPS_NUM);
/* avoid runtime computations by keeping the usable size here */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] dpaa_eth: fix error return code in dpaa_eth_probe()
2017-11-06 11:12 [PATCH net-next] dpaa_eth: fix error return code in dpaa_eth_probe() Wei Yongjun
@ 2017-11-08 4:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-08 4:26 UTC (permalink / raw)
To: weiyongjun1; +Cc: madalin.bucur, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 6 Nov 2017 11:12:08 +0000
> Fix to return a negative error code from the dpaa_bp_alloc() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-08 4:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 11:12 [PATCH net-next] dpaa_eth: fix error return code in dpaa_eth_probe() Wei Yongjun
2017-11-08 4:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.