All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clocksource: timer-of: drop __init annotations in timer_*_exit functions
@ 2017-11-06 14:48 Sudeep Holla
  0 siblings, 0 replies; only message in thread
From: Sudeep Holla @ 2017-11-06 14:48 UTC (permalink / raw)
  To: linux-kernel; +Cc: Sudeep Holla, Daniel Lezcano, Thomas Gleixner

timer_{base,clk,irq}_exit functions have __init annotations. Commit
f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
added timer_of_exit to undo what has been done by the timer_of_init()
function, which means we need to drop __init to use timer_*_exit
functions.

It also generates the build time warning:
"WARNING: vmlinux.o: Section mismatch in reference from the
 function timer_of_exit() to the variable .init.text:$x
 The function timer_of_exit() references the variable __init $x.
 This is often because timer_of_exit lacks a __init annotation or the
 annotation of $x is wrong."

This patch fixes the above build warning.

Fixes: f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/clocksource/timer-of.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 7c64a5c1bfc1..701b476ccc7c 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -24,7 +24,7 @@
 
 #include "timer-of.h"
 
-static __init void timer_irq_exit(struct of_timer_irq *of_irq)
+static void timer_irq_exit(struct of_timer_irq *of_irq)
 {
 	struct timer_of *to = container_of(of_irq, struct timer_of, of_irq);
 
@@ -72,7 +72,7 @@ static __init int timer_irq_init(struct device_node *np,
 	return 0;
 }
 
-static __init void timer_clk_exit(struct of_timer_clk *of_clk)
+static void timer_clk_exit(struct of_timer_clk *of_clk)
 {
 	of_clk->rate = 0;
 	clk_disable_unprepare(of_clk->clk);
@@ -116,7 +116,7 @@ static __init int timer_clk_init(struct device_node *np,
 	goto out;
 }
 
-static __init void timer_base_exit(struct of_timer_base *of_base)
+static void timer_base_exit(struct of_timer_base *of_base)
 {
 	iounmap(of_base->base);
 }
-- 
2.7.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-11-06 14:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 14:48 [PATCH] clocksource: timer-of: drop __init annotations in timer_*_exit functions Sudeep Holla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.