* [igt-dev] [RFC, i-g-t] Added dynamic Subtest
@ 2020-11-06 9:27 nidhi1.gupta
2020-11-06 9:34 ` Petri Latvala
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: nidhi1.gupta @ 2020-11-06 9:27 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
From: Nidhi Gupta <nidhi1.gupta@intel.com>
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_atomic_transition.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index a71bbe10..aa2afe02 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -1025,16 +1025,16 @@ igt_main
run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
for (i = 1; i <= IGT_MAX_PIPES; i++) {
- igt_subtest_f("%ix-modeset-transitions", i)
+ igt_subtest_with_dynamic_f("%ix-modeset-transitions", i)
run_modeset_transition(&display, i, false, false);
- igt_subtest_f("%ix-modeset-transitions-nonblocking", i)
+ igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i)
run_modeset_transition(&display, i, true, false);
- igt_subtest_f("%ix-modeset-transitions-fencing", i)
+ igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i)
run_modeset_transition(&display, i, false, true);
- igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i)
+ igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i)
run_modeset_transition(&display, i, true, true);
}
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC, i-g-t] Added dynamic Subtest
2020-11-06 9:27 [igt-dev] [RFC, i-g-t] Added dynamic Subtest nidhi1.gupta
@ 2020-11-06 9:34 ` Petri Latvala
2020-11-11 9:42 ` Karthik B S
2020-11-06 9:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-06 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2020-11-06 9:34 UTC (permalink / raw)
To: nidhi1.gupta; +Cc: igt-dev
On Fri, Nov 06, 2020 at 02:57:57PM +0530, nidhi1.gupta@intel.com wrote:
> From: Nidhi Gupta <nidhi1.gupta@intel.com>
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_atomic_transition.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index a71bbe10..aa2afe02 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -1025,16 +1025,16 @@ igt_main
> run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
>
> for (i = 1; i <= IGT_MAX_PIPES; i++) {
> - igt_subtest_f("%ix-modeset-transitions", i)
> + igt_subtest_with_dynamic_f("%ix-modeset-transitions", i)
> run_modeset_transition(&display, i, false, false);
>
> - igt_subtest_f("%ix-modeset-transitions-nonblocking", i)
> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i)
> run_modeset_transition(&display, i, true, false);
>
> - igt_subtest_f("%ix-modeset-transitions-fencing", i)
> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i)
> run_modeset_transition(&display, i, false, true);
>
> - igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i)
> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i)
> run_modeset_transition(&display, i, true, true);
Where are the igt_dynamic() blocks for these?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Added dynamic Subtest
2020-11-06 9:27 [igt-dev] [RFC, i-g-t] Added dynamic Subtest nidhi1.gupta
2020-11-06 9:34 ` Petri Latvala
@ 2020-11-06 9:59 ` Patchwork
2020-11-06 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-11-06 9:59 UTC (permalink / raw)
To: nidhi1.gupta; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5641 bytes --]
== Series Details ==
Series: Added dynamic Subtest
URL : https://patchwork.freedesktop.org/series/83576/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9278 -> IGTPW_5139
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
Known issues
------------
Here are the changes found in IGTPW_5139 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-byt-j1900/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-apl-guc: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#203] / [i915#62]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-apl-guc/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-apl-guc/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-apl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#1635] / [i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-apl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-apl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [SKIP][11] ([fdo#109271]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [INCOMPLETE][13] ([i915#2089]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_timelines:
- fi-apl-guc: [INCOMPLETE][15] ([i915#1635]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-kbl-soraka/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2089]: https://gitlab.freedesktop.org/drm/intel/issues/2089
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Participating hosts (43 -> 39)
------------------------------
Missing (4): fi-tgl-y fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5836 -> IGTPW_5139
CI-20190529: 20190529
CI_DRM_9278: 4004b239e7a4a8c1bfba86208e71021a74be2a57 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
IGT_5836: 4c2ec0ad123b82f42f9fe2297e1a41fec73c9229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
[-- Attachment #1.2: Type: text/html, Size: 7039 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for Added dynamic Subtest
2020-11-06 9:27 [igt-dev] [RFC, i-g-t] Added dynamic Subtest nidhi1.gupta
2020-11-06 9:34 ` Petri Latvala
2020-11-06 9:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-11-06 11:54 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-11-06 11:54 UTC (permalink / raw)
To: nidhi1.gupta; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 22148 bytes --]
== Series Details ==
Series: Added dynamic Subtest
URL : https://patchwork.freedesktop.org/series/83576/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9278_full -> IGTPW_5139_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5139_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5139_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5139_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_flush@basic-wb-prw-default:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-snb4/igt@gem_exec_flush@basic-wb-prw-default.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-snb7/igt@gem_exec_flush@basic-wb-prw-default.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb2/igt@i915_pm_dc@dc5-dpms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb2/igt@i915_pm_dc@dc5-dpms.html
- shard-glk: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk7/igt@i915_pm_dc@dc5-dpms.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk1/igt@i915_pm_dc@dc5-dpms.html
- shard-kbl: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl2/igt@i915_pm_dc@dc5-dpms.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl3/igt@i915_pm_dc@dc5-dpms.html
* igt@kms_atomic_transition@1x-modeset-transitions-fencing:
- shard-iclb: [PASS][9] -> [SKIP][10] +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb3/igt@kms_atomic_transition@1x-modeset-transitions-fencing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb8/igt@kms_atomic_transition@1x-modeset-transitions-fencing.html
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-tglb: [PASS][11] -> [SKIP][12] +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb5/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb6/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
Known issues
------------
Here are the changes found in IGTPW_5139_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_partial_pwrite_pread@write-snoop:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#1888]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw1/igt@gem_partial_pwrite_pread@write-snoop.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw1/igt@gem_partial_pwrite_pread@write-snoop.html
* igt@i915_pm_dc@dc5-dpms:
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#1635])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl3/igt@i915_pm_dc@dc5-dpms.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl2/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rpm@system-suspend-devices:
- shard-iclb: [PASS][17] -> [SKIP][18] ([i915#579]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb3/igt@i915_pm_rpm@system-suspend-devices.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb2/igt@i915_pm_rpm@system-suspend-devices.html
* igt@kms_atomic_transition@1x-modeset-transitions:
- shard-snb: [PASS][19] -> [SKIP][20] ([fdo#109271]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-snb6/igt@kms_atomic_transition@1x-modeset-transitions.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-snb4/igt@kms_atomic_transition@1x-modeset-transitions.html
* igt@kms_atomic_transition@1x-modeset-transitions-fencing:
- shard-kbl: [PASS][21] -> [SKIP][22] ([fdo#109271]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl4/igt@kms_atomic_transition@1x-modeset-transitions-fencing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl6/igt@kms_atomic_transition@1x-modeset-transitions-fencing.html
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: [PASS][23] -> [SKIP][24] ([fdo#109271] / [i915#1635]) +5 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl4/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl2/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
* igt@kms_atomic_transition@2x-modeset-transitions-fencing:
- shard-hsw: [PASS][25] -> [SKIP][26] ([fdo#109271]) +9 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw7/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html
* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing:
- shard-glk: [PASS][27] -> [SKIP][28] ([fdo#109271]) +9 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk3/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk3/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl4/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl4/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#1635] / [i915#1982]) +8 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl3/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1:
- shard-hsw: [PASS][33] -> [INCOMPLETE][34] ([i915#2055])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw1/igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1:
- shard-tglb: [PASS][35] -> [FAIL][36] ([i915#2122])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb7/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb8/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][37] -> [FAIL][38] ([i915#2598])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: [PASS][39] -> [DMESG-WARN][40] ([i915#1982]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][41] -> [SKIP][42] ([i915#433])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_universal_plane@universal-plane-pipe-b-sanity:
- shard-glk: [PASS][45] -> [DMESG-WARN][46] ([i915#1982]) +6 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk5/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk6/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-apl: [PASS][47] -> [FAIL][48] ([i915#1635] / [i915#1755])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl7/igt@sysfs_timeslice_duration@timeout@vecs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl6/igt@sysfs_timeslice_duration@timeout@vecs0.html
#### Possible fixes ####
* igt@gem_exec_gttfill@all:
- shard-hsw: [TIMEOUT][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw8/igt@gem_exec_gttfill@all.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw1/igt@gem_exec_gttfill@all.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][51] ([i915#2389]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk9/igt@gem_exec_reloc@basic-many-active@rcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk6/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [INCOMPLETE][53] ([i915#82]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
- shard-hsw: [FAIL][55] ([i915#1888]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw8/igt@gem_userptr_blits@sync-unmap-cycles.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw7/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_module_load@reload:
- shard-hsw: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw6/igt@i915_module_load@reload.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw8/igt@i915_module_load@reload.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][59] ([i915#454]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][61] ([i915#2521]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl4/igt@kms_async_flips@async-flip-with-page-flip-events.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl2/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge:
- shard-apl: [DMESG-WARN][63] ([i915#1635] / [i915#1982]) -> [PASS][64] +10 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl4/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl7/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
- shard-glk: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +10 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk2/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk8/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][67] ([i915#79]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_sysfs_edid_timing:
- shard-hsw: [FAIL][73] ([IGT#2]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw6/igt@kms_sysfs_edid_timing.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw6/igt@kms_sysfs_edid_timing.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-kbl: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl4/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
* igt@kms_vblank@pipe-c-wait-busy:
- shard-iclb: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb3/igt@kms_vblank@pipe-c-wait-busy.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb5/igt@kms_vblank@pipe-c-wait-busy.html
* igt@perf@enable-disable:
- shard-iclb: [SKIP][79] ([i915#1354]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb2/igt@perf@enable-disable.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb2/igt@perf@enable-disable.html
- shard-hsw: [SKIP][81] ([fdo#109271]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-hsw8/igt@perf@enable-disable.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-hsw7/igt@perf@enable-disable.html
* igt@perf@polling-small-buf:
- shard-glk: [SKIP][83] ([fdo#109271] / [i915#1354]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-glk1/igt@perf@polling-small-buf.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-glk2/igt@perf@polling-small-buf.html
- shard-tglb: [SKIP][85] ([i915#1354]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb5/igt@perf@polling-small-buf.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb8/igt@perf@polling-small-buf.html
- shard-apl: [SKIP][87] ([fdo#109271] / [i915#1354] / [i915#1635]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl3/igt@perf@polling-small-buf.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl8/igt@perf@polling-small-buf.html
- shard-kbl: [SKIP][89] ([fdo#109271] / [i915#1354]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-kbl1/igt@perf@polling-small-buf.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-kbl1/igt@perf@polling-small-buf.html
* igt@perf_pmu@most-busy-idle-check-all@vcs0:
- shard-snb: [FAIL][91] -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-snb6/igt@perf_pmu@most-busy-idle-check-all@vcs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-snb4/igt@perf_pmu@most-busy-idle-check-all@vcs0.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [DMESG-WARN][93] ([i915#2411]) -> [FAIL][94] ([i915#1567])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][95] ([i915#1226]) -> [SKIP][96] ([fdo#109349])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [DMESG-WARN][97] ([i915#2411]) -> [INCOMPLETE][98] ([i915#1436] / [i915#1982])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: [FAIL][99] ([fdo#108145] / [i915#1635] / [i915#265]) -> [DMESG-FAIL][100] ([fdo#108145] / [i915#1635] / [i915#1982])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@runner@aborted:
- shard-tglb: [FAIL][101] ([i915#1814] / [i915#2426]) -> [FAIL][102] ([i915#1602])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9278/shard-tglb6/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/shard-tglb2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1354]: https://gitlab.freedesktop.org/drm/intel/issues/1354
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1567]: https://gitlab.freedesktop.org/drm/intel/issues/1567
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5836 -> IGTPW_5139
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9278: 4004b239e7a4a8c1bfba86208e71021a74be2a57 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
IGT_5836: 4c2ec0ad123b82f42f9fe2297e1a41fec73c9229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5139/index.html
[-- Attachment #1.2: Type: text/html, Size: 26187 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC, i-g-t] Added dynamic Subtest
2020-11-06 9:34 ` Petri Latvala
@ 2020-11-11 9:42 ` Karthik B S
2020-11-11 10:26 ` Petri Latvala
0 siblings, 1 reply; 8+ messages in thread
From: Karthik B S @ 2020-11-11 9:42 UTC (permalink / raw)
To: Petri Latvala, nidhi1.gupta; +Cc: igt-dev
On 11/6/2020 3:04 PM, Petri Latvala wrote:
> On Fri, Nov 06, 2020 at 02:57:57PM +0530, nidhi1.gupta@intel.com wrote:
>> From: Nidhi Gupta <nidhi1.gupta@intel.com>
>>
>> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
>> ---
>> tests/kms_atomic_transition.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
>> index a71bbe10..aa2afe02 100644
>> --- a/tests/kms_atomic_transition.c
>> +++ b/tests/kms_atomic_transition.c
>> @@ -1025,16 +1025,16 @@ igt_main
>> run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
>>
>> for (i = 1; i <= IGT_MAX_PIPES; i++) {
Since we're now anyway planning to use dynamic subtests for this,
Could we just have a count of the number of outputs connected and use
this, instead of using IGT_MAX_PIPES to populate the subtests and
eventually skipping them?
@Petri,
Does this sound good?
Thanks,
Karthik.B.S
>> - igt_subtest_f("%ix-modeset-transitions", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions", i)
>> run_modeset_transition(&display, i, false, false);
>>
>> - igt_subtest_f("%ix-modeset-transitions-nonblocking", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i)
>> run_modeset_transition(&display, i, true, false);
>>
>> - igt_subtest_f("%ix-modeset-transitions-fencing", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i)
>> run_modeset_transition(&display, i, false, true);
>>
>> - igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i)
>> run_modeset_transition(&display, i, true, true);
> Where are the igt_dynamic() blocks for these?
>
>
> --
> Petri Latvala
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC, i-g-t] Added dynamic Subtest
2020-11-11 9:42 ` Karthik B S
@ 2020-11-11 10:26 ` Petri Latvala
0 siblings, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2020-11-11 10:26 UTC (permalink / raw)
To: Karthik B S; +Cc: igt-dev, nidhi1.gupta
On Wed, Nov 11, 2020 at 03:12:12PM +0530, Karthik B S wrote:
> On 11/6/2020 3:04 PM, Petri Latvala wrote:
> > On Fri, Nov 06, 2020 at 02:57:57PM +0530, nidhi1.gupta@intel.com wrote:
> > > From: Nidhi Gupta <nidhi1.gupta@intel.com>
> > >
> > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> > > ---
> > > tests/kms_atomic_transition.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> > > index a71bbe10..aa2afe02 100644
> > > --- a/tests/kms_atomic_transition.c
> > > +++ b/tests/kms_atomic_transition.c
> > > @@ -1025,16 +1025,16 @@ igt_main
> > > run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
> > > for (i = 1; i <= IGT_MAX_PIPES; i++) {
>
> Since we're now anyway planning to use dynamic subtests for this,
>
> Could we just have a count of the number of outputs connected and use this,
> instead of using IGT_MAX_PIPES to populate the subtests and eventually
> skipping them?
Yeah that sounds proper actually.
So igt_subtest_with_dynamic("modeset-transitions"), with
for_each_pipe, or for_each_pipe_with_single_output, or
for_each_connected_output, based on what kind of coverage is needed,
and igt_dynamic_f for each.
--
Petri Latvala
>
> @Petri,
>
> Does this sound good?
>
> Thanks,
> Karthik.B.S
> > > - igt_subtest_f("%ix-modeset-transitions", i)
> > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions", i)
> > > run_modeset_transition(&display, i, false, false);
> > > - igt_subtest_f("%ix-modeset-transitions-nonblocking", i)
> > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i)
> > > run_modeset_transition(&display, i, true, false);
> > > - igt_subtest_f("%ix-modeset-transitions-fencing", i)
> > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i)
> > > run_modeset_transition(&display, i, false, true);
> > > - igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i)
> > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i)
> > > run_modeset_transition(&display, i, true, true);
> > Where are the igt_dynamic() blocks for these?
> >
> >
> > --
> > Petri Latvala
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC, i-g-t] Added Dynamic Subtest
2020-12-01 2:32 [igt-dev] [RFC, i-g-t] Added Dynamic Subtest nidhi1.gupta
@ 2020-12-01 13:44 ` Petri Latvala
0 siblings, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2020-12-01 13:44 UTC (permalink / raw)
To: nidhi1.gupta; +Cc: igt-dev
On Tue, Dec 01, 2020 at 08:02:58AM +0530, nidhi1.gupta@intel.com wrote:
> From: Nidhi Gupta <nidhi1.gupta@intel.com>
>
> In kms_plane_scaling have a subtest with 2 pipe it
> will execute it weather 2 pipes are available or not.
> Later it has to be analysed and discard it as valid skip.
> To save this time updated in test to first check the available
> outputs and then execute the test
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_plane_scaling.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 89b82416..95be07cc 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -682,6 +682,7 @@ static data_t data;
> igt_main_args("", long_opts, help_str, opt_handler, &data)
> {
> enum pipe pipe;
> + int count = 0;
>
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_AMDGPU);
> @@ -717,10 +718,17 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> igt_dynamic_f("pipe-%s-scaler-with-clipping-clamping", kmstest_pipe_name(pipe))
> test_scaler_with_clipping_clamping_scenario(&data, pipe, output);
> }
> - }
>
> - igt_subtest_f("2x-scaler-multi-pipe")
> - test_scaler_with_multi_pipe_plane(&data);
> + igt_subtest_with_dynamic("scaler-multi-pipe") {
> + for_each_pipe_with_single_output(&data.display, pipe, output) {
> + ++count;
> + }
> + if (count >= 2) {
> + igt_dynamic_f("2x-scaler-multi-pipe")
> + test_scaler_with_multi_pipe_plane(&data);
> + }
> + }
> + }
NAK. This will make the test still skip on less than 2 outputs, but
the skip is now harder to filter. (The skip will be for
"scaler-multi-pipe" with the message "no dynamic subtests entered")
To save human time in cibuglog analysis, rather make the
less-than-required-outputs skip messages consistent so one filter can
cover them all.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [RFC, i-g-t] Added Dynamic Subtest
@ 2020-12-01 2:32 nidhi1.gupta
2020-12-01 13:44 ` Petri Latvala
0 siblings, 1 reply; 8+ messages in thread
From: nidhi1.gupta @ 2020-12-01 2:32 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
From: Nidhi Gupta <nidhi1.gupta@intel.com>
In kms_plane_scaling have a subtest with 2 pipe it
will execute it weather 2 pipes are available or not.
Later it has to be analysed and discard it as valid skip.
To save this time updated in test to first check the available
outputs and then execute the test
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_plane_scaling.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 89b82416..95be07cc 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -682,6 +682,7 @@ static data_t data;
igt_main_args("", long_opts, help_str, opt_handler, &data)
{
enum pipe pipe;
+ int count = 0;
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_AMDGPU);
@@ -717,10 +718,17 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
igt_dynamic_f("pipe-%s-scaler-with-clipping-clamping", kmstest_pipe_name(pipe))
test_scaler_with_clipping_clamping_scenario(&data, pipe, output);
}
- }
- igt_subtest_f("2x-scaler-multi-pipe")
- test_scaler_with_multi_pipe_plane(&data);
+ igt_subtest_with_dynamic("scaler-multi-pipe") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ ++count;
+ }
+ if (count >= 2) {
+ igt_dynamic_f("2x-scaler-multi-pipe")
+ test_scaler_with_multi_pipe_plane(&data);
+ }
+ }
+ }
igt_fixture
igt_display_fini(&data.display);
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-01 13:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 9:27 [igt-dev] [RFC, i-g-t] Added dynamic Subtest nidhi1.gupta
2020-11-06 9:34 ` Petri Latvala
2020-11-11 9:42 ` Karthik B S
2020-11-11 10:26 ` Petri Latvala
2020-11-06 9:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-06 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-01 2:32 [igt-dev] [RFC, i-g-t] Added Dynamic Subtest nidhi1.gupta
2020-12-01 13:44 ` Petri Latvala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.