All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] net: fix incorrect comment with regard to VLAN packet handling
@ 2017-11-07 19:32 Girish Moodalbail
  2017-11-10  9:04 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Girish Moodalbail @ 2017-11-07 19:32 UTC (permalink / raw)
  To: netdev, davem

The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar
to hw-accel") unified accel and non-accel path for VLAN RX. With that
fix we do not register any packet_type handler for VLANs anymore, so fix
the incorrect comment.

Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
---
 include/linux/netdevice.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 2eaac7d..7098978 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4411,15 +4411,7 @@ void netdev_printk(const char *level, const struct net_device *dev,
  *	Why 16. Because with 16 the only overlap we get on a hash of the
  *	low nibble of the protocol value is RARP/SNAP/X.25.
  *
- *      NOTE:  That is no longer true with the addition of VLAN tags.  Not
- *             sure which should go first, but I bet it won't make much
- *             difference if we are running VLANs.  The good news is that
- *             this protocol won't be in the list unless compiled in, so
- *             the average user (w/out VLANs) will not be adversely affected.
- *             --BLG
- *
  *		0800	IP
- *		8100    802.1Q VLAN
  *		0001	802.3
  *		0002	AX.25
  *		0004	802.2
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: fix incorrect comment with regard to VLAN packet handling
  2017-11-07 19:32 [PATCH net] net: fix incorrect comment with regard to VLAN packet handling Girish Moodalbail
@ 2017-11-10  9:04 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-10  9:04 UTC (permalink / raw)
  To: girish.moodalbail; +Cc: netdev

From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Tue,  7 Nov 2017 11:32:11 -0800

> The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar
> to hw-accel") unified accel and non-accel path for VLAN RX. With that
> fix we do not register any packet_type handler for VLANs anymore, so fix
> the incorrect comment.
> 
> Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-10  9:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 19:32 [PATCH net] net: fix incorrect comment with regard to VLAN packet handling Girish Moodalbail
2017-11-10  9:04 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.