* [PATCH] drm/i915: Idle the GPU before shinking everything
@ 2017-11-07 21:31 Chris Wilson
2017-11-08 9:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Chris Wilson @ 2017-11-07 21:31 UTC (permalink / raw)
To: intel-gfx
The handling of contexts are peculiar. Instead of tieing their vma to
activity, we pin the context. This means that we cannot simply unbind
the context object itself at will (which would normally cause us to wait
for the vma to be idle), but must manually idle the GPU and retire
requests first.
A consequence of this peculiarity is when doing a last desperate attempt
to recover memory. If the memory is tied up inside active context
objects, we will fail to recover any memory simply by trying to unbind
the objects without first doing a wait-for-idle.
A side-effect of removing the call to shrinker_lock_uninterruptible()
from i915_gem_shrinker_oom() was that we removed an unlocked
wait-for-idle, and so lost the "natural" shrinkage of context objects.
By replacing that with a locked wait from inside i915_gem_shrink(), we
not only replace it with the ability to recover all context objects, but
do so for all i915_gem_shrink_all() callers.
References: https://bugs.freedesktop.org/show_bug.cgi?id=102936
Fixes: f2123818ffad ("drm/i915: Move dev_priv->mm.[un]bound_list to its own lock")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
index eb31f8aa5c21..e72f5543a4e9 100644
--- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
+++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
@@ -162,6 +162,24 @@ i915_gem_shrink(struct drm_i915_private *dev_priv,
if (!shrinker_lock(dev_priv, &unlock))
return 0;
+ /*
+ * When shrinking everything, also consider active contexts.
+ * Active contexts are pinned until they are retired, and so can
+ * not be simply unbound to retire and unpin their pages. To shrink
+ * the contexts, we must wait until the gpu is idle and to be able
+ * to shrink *all* contexts, first switch to the permanently
+ * pinned kernel context.
+ *
+ * We don't care about errors here (trying to switch contexts will
+ * need an allocation for its request etc); if we cannot switch and
+ * wait upon the GPU, we will free as much as we can and hope to get
+ * a second chance.
+ */
+ if (target == -1ul && flags & I915_SHRINK_ACTIVE) {
+ i915_gem_switch_to_kernel_context(dev_priv);
+ i915_gem_wait_for_idle(dev_priv, I915_WAIT_LOCKED);
+ }
+
trace_i915_gem_shrink(dev_priv, target, flags);
i915_gem_retire_requests(dev_priv);
--
2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Idle the GPU before shinking everything
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
@ 2017-11-08 9:31 ` Patchwork
2017-11-08 9:38 ` [PATCH] " Chris Wilson
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-11-08 9:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Idle the GPU before shinking everything
URL : https://patchwork.freedesktop.org/series/33373/
State : failure
== Summary ==
Series 33373v1 drm/i915: Idle the GPU before shinking everything
https://patchwork.freedesktop.org/api/1.0/series/33373/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test gem_exec_gttfill:
Subgroup basic:
pass -> DMESG-WARN (fi-blb-e6850)
pass -> DMESG-WARN (fi-elk-e7500)
pass -> DMESG-WARN (fi-ilk-650)
pass -> DMESG-WARN (fi-snb-2520m)
pass -> DMESG-WARN (fi-snb-2600)
pass -> DMESG-WARN (fi-ivb-3520m)
pass -> DMESG-WARN (fi-ivb-3770)
pass -> DMESG-WARN (fi-byt-j1900)
pass -> DMESG-WARN (fi-byt-n2820)
pass -> DMESG-WARN (fi-hsw-4770)
pass -> DMESG-WARN (fi-hsw-4770r)
pass -> DMESG-WARN (fi-bdw-5557u)
pass -> DMESG-WARN (fi-skl-6260u)
pass -> DMESG-WARN (fi-skl-6600u)
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6700k)
pass -> DMESG-WARN (fi-skl-6770hq)
pass -> DMESG-WARN (fi-bxt-j4205)
pass -> DMESG-WARN (fi-kbl-7500u)
pass -> DMESG-WARN (fi-kbl-7560u)
pass -> DMESG-WARN (fi-kbl-7567u)
pass -> DMESG-WARN (fi-kbl-r)
pass -> DMESG-WARN (fi-cnl-y)
Test gem_mmap:
Subgroup basic-small-bo:
pass -> DMESG-WARN (fi-gdg-551)
pass -> DMESG-WARN (fi-bwr-2160)
Test gem_ringfill:
Subgroup basic-default-hang:
pass -> INCOMPLETE (fi-glk-dsi) fdo#103359
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
pass -> FAIL (fi-gdg-551) fdo#102618
Test kms_flip:
Subgroup basic-plain-flip:
incomplete -> PASS (fi-cnl-y) fdo#103339
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bsw-n3050)
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (fi-gdg-551) fdo#102707
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618
fdo#103339 https://bugs.freedesktop.org/show_bug.cgi?id=103339
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fi-bdw-5557u total:289 pass:267 dwarn:1 dfail:0 fail:0 skip:21 time:440s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:447s
fi-blb-e6850 total:289 pass:222 dwarn:2 dfail:0 fail:0 skip:65 time:370s
fi-bsw-n3050 total:232 pass:200 dwarn:0 dfail:0 fail:0 skip:31
fi-bwr-2160 total:289 pass:182 dwarn:1 dfail:0 fail:0 skip:106 time:263s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:482s
fi-bxt-j4205 total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:484s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:472s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:462s
fi-cnl-y total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:561s
fi-elk-e7500 total:289 pass:228 dwarn:1 dfail:0 fail:0 skip:60 time:420s
fi-gdg-551 total:289 pass:175 dwarn:3 dfail:0 fail:2 skip:109 time:254s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:529s
fi-glk-dsi total:156 pass:133 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770 total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:418s
fi-hsw-4770r total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:421s
fi-ilk-650 total:289 pass:227 dwarn:1 dfail:0 fail:0 skip:61 time:418s
fi-ivb-3520m total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:471s
fi-ivb-3770 total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:450s
fi-kbl-7500u total:289 pass:263 dwarn:2 dfail:0 fail:0 skip:24 time:476s
fi-kbl-7560u total:289 pass:269 dwarn:1 dfail:0 fail:0 skip:19 time:517s
fi-kbl-7567u total:289 pass:268 dwarn:1 dfail:0 fail:0 skip:20 time:471s
fi-kbl-r total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:525s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:494s
fi-skl-6260u total:289 pass:268 dwarn:1 dfail:0 fail:0 skip:20 time:445s
fi-skl-6600u total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:538s
fi-skl-6700hq total:289 pass:262 dwarn:1 dfail:0 fail:0 skip:26 time:552s
fi-skl-6700k total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:268 dwarn:1 dfail:0 fail:0 skip:20 time:487s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:451s
fi-snb-2520m total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:546s
fi-snb-2600 total:289 pass:248 dwarn:1 dfail:0 fail:0 skip:40 time:411s
748f2c6b4046b23a623b4af3799563ef3110bb0d drm-tip: 2017y-11m-08d-07h-50m-13s UTC integration manifest
d6c82b94ed26 drm/i915: Idle the GPU before shinking everything
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7002/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Idle the GPU before shinking everything
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
2017-11-08 9:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-11-08 9:38 ` Chris Wilson
2017-11-08 9:44 ` [PATCH v2] " Chris Wilson
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2017-11-08 9:38 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2017-11-07 21:31:20)
> The handling of contexts are peculiar. Instead of tieing their vma to
> activity, we pin the context. This means that we cannot simply unbind
> the context object itself at will (which would normally cause us to wait
> for the vma to be idle), but must manually idle the GPU and retire
> requests first.
>
> A consequence of this peculiarity is when doing a last desperate attempt
> to recover memory. If the memory is tied up inside active context
> objects, we will fail to recover any memory simply by trying to unbind
> the objects without first doing a wait-for-idle.
However, we are totally not allowed to use ordinary allocs here, making
sending a request next to impossible. We'll just have to wait for idle
and nothing more. Alternatively we have a specially crafted request just
for the shrinker... Ugh.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] drm/i915: Idle the GPU before shinking everything
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
2017-11-08 9:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-11-08 9:38 ` [PATCH] " Chris Wilson
@ 2017-11-08 9:44 ` Chris Wilson
2017-11-08 14:56 ` Joonas Lahtinen
2017-11-08 10:59 ` ✓ Fi.CI.BAT: success for drm/i915: Idle the GPU before shinking everything (rev2) Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2017-11-08 9:44 UTC (permalink / raw)
To: intel-gfx
The handling of contexts are peculiar. Instead of tieing their vma to
activity, we pin the context. This means that we cannot simply unbind
the context object itself at will (which would normally cause us to wait
for the vma to be idle), but must manually idle the GPU and retire
requests first.
A consequence of this peculiarity is when doing a last desperate attempt
to recover memory. If the memory is tied up inside active context
objects, we will fail to recover any memory simply by trying to unbind
the objects without first doing a wait-for-idle.
A side-effect of removing the call to shrinker_lock_uninterruptible()
from i915_gem_shrinker_oom() was that we removed an unlocked
wait-for-idle, and so lost the "natural" shrinkage of context objects.
By replacing that with a locked wait from inside i915_gem_shrink(), we
not only replace it with the ability to recover all context objects, but
do so for all i915_gem_shrink_all() callers.
v2: Switching requires request allocation, which is not permitted from
inside the shrinker as it only uses ordinary allocations.
References: https://bugs.freedesktop.org/show_bug.cgi?id=102936
Fixes: f2123818ffad ("drm/i915: Move dev_priv->mm.[un]bound_list to its own lock")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
index eb31f8aa5c21..3770e3323fc8 100644
--- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
+++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
@@ -162,6 +162,18 @@ i915_gem_shrink(struct drm_i915_private *dev_priv,
if (!shrinker_lock(dev_priv, &unlock))
return 0;
+ /*
+ * When shrinking the active list, also consider active contexts.
+ * Active contexts are pinned until they are retired, and so can
+ * not be simply unbound to retire and unpin their pages. To shrink
+ * the contexts, we must wait until the gpu is idle.
+ *
+ * We don't care about errors here; if we cannot wait upon the GPU,
+ * we will free as much as we can and hope to get a second chance.
+ */
+ if (flags & I915_SHRINK_ACTIVE)
+ i915_gem_wait_for_idle(dev_priv, I915_WAIT_LOCKED);
+
trace_i915_gem_shrink(dev_priv, target, flags);
i915_gem_retire_requests(dev_priv);
--
2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Idle the GPU before shinking everything (rev2)
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
` (2 preceding siblings ...)
2017-11-08 9:44 ` [PATCH v2] " Chris Wilson
@ 2017-11-08 10:59 ` Patchwork
2017-11-08 11:37 ` ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-11-08 10:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Idle the GPU before shinking everything (rev2)
URL : https://patchwork.freedesktop.org/series/33373/
State : success
== Summary ==
Series 33373v2 drm/i915: Idle the GPU before shinking everything
https://patchwork.freedesktop.org/api/1.0/series/33373/revisions/2/mbox/
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:444s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:380s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:533s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:273s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:502s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:501s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:489s
fi-cnl-y total:63 pass:46 dwarn:0 dfail:0 fail:0 skip:16
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:487s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:464s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:481s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:533s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:575s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:455s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:546s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:455s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:563s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
748f2c6b4046b23a623b4af3799563ef3110bb0d drm-tip: 2017y-11m-08d-07h-50m-13s UTC integration manifest
f5a81e16f84c drm/i915: Idle the GPU before shinking everything
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7007/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Idle the GPU before shinking everything (rev2)
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
` (3 preceding siblings ...)
2017-11-08 10:59 ` ✓ Fi.CI.BAT: success for drm/i915: Idle the GPU before shinking everything (rev2) Patchwork
@ 2017-11-08 11:37 ` Patchwork
2017-11-08 11:57 ` ✓ Fi.CI.BAT: success " Patchwork
2017-11-08 13:06 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-11-08 11:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Idle the GPU before shinking everything (rev2)
URL : https://patchwork.freedesktop.org/series/33373/
State : failure
== Summary ==
Series 33373v2 drm/i915: Idle the GPU before shinking everything
https://patchwork.freedesktop.org/api/1.0/series/33373/revisions/2/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test gem_exec_flush:
Subgroup basic-uc-pro-default:
pass -> INCOMPLETE (fi-cnl-y)
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:444s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:380s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:533s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:273s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:502s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:501s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:489s
fi-cnl-y total:63 pass:46 dwarn:0 dfail:0 fail:0 skip:16
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:487s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:464s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:481s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:533s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:575s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:455s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:546s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:455s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:563s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
748f2c6b4046b23a623b4af3799563ef3110bb0d drm-tip: 2017y-11m-08d-07h-50m-13s UTC integration manifest
f5a81e16f84c drm/i915: Idle the GPU before shinking everything
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7007/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Idle the GPU before shinking everything (rev2)
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
` (4 preceding siblings ...)
2017-11-08 11:37 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2017-11-08 11:57 ` Patchwork
2017-11-08 13:06 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-11-08 11:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Idle the GPU before shinking everything (rev2)
URL : https://patchwork.freedesktop.org/series/33373/
State : success
== Summary ==
Series 33373v2 drm/i915: Idle the GPU before shinking everything
https://patchwork.freedesktop.org/api/1.0/series/33373/revisions/2/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:444s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:459s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:380s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:533s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:273s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:502s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:501s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:489s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:464s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:481s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:533s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:575s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:455s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:546s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:455s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:563s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
Blacklisted hosts:
fi-cnl-y total:63 pass:46 dwarn:0 dfail:0 fail:0 skip:16
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:487s
748f2c6b4046b23a623b4af3799563ef3110bb0d drm-tip: 2017y-11m-08d-07h-50m-13s UTC integration manifest
f5a81e16f84c drm/i915: Idle the GPU before shinking everything
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7007/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Idle the GPU before shinking everything (rev2)
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
` (5 preceding siblings ...)
2017-11-08 11:57 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-11-08 13:06 ` Patchwork
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2017-11-08 13:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Idle the GPU before shinking everything (rev2)
URL : https://patchwork.freedesktop.org/series/33373/
State : success
== Summary ==
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-a:
dmesg-warn -> PASS (shard-hsw) fdo#102249
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-toggle:
skip -> PASS (shard-hsw) fdo#102670
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (shard-hsw) fdo#102707
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
shard-hsw total:2540 pass:1431 dwarn:1 dfail:0 fail:11 skip:1097 time:9198s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7007/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Idle the GPU before shinking everything
2017-11-08 9:44 ` [PATCH v2] " Chris Wilson
@ 2017-11-08 14:56 ` Joonas Lahtinen
0 siblings, 0 replies; 9+ messages in thread
From: Joonas Lahtinen @ 2017-11-08 14:56 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Wed, 2017-11-08 at 09:44 +0000, Chris Wilson wrote:
> The handling of contexts are peculiar. Instead of tieing their vma to
> activity, we pin the context. This means that we cannot simply unbind
> the context object itself at will (which would normally cause us to wait
> for the vma to be idle), but must manually idle the GPU and retire
> requests first.
>
> A consequence of this peculiarity is when doing a last desperate attempt
> to recover memory. If the memory is tied up inside active context
> objects, we will fail to recover any memory simply by trying to unbind
> the objects without first doing a wait-for-idle.
>
> A side-effect of removing the call to shrinker_lock_uninterruptible()
> from i915_gem_shrinker_oom() was that we removed an unlocked
> wait-for-idle, and so lost the "natural" shrinkage of context objects.
> By replacing that with a locked wait from inside i915_gem_shrink(), we
> not only replace it with the ability to recover all context objects, but
> do so for all i915_gem_shrink_all() callers.
>
> v2: Switching requires request allocation, which is not permitted from
> inside the shrinker as it only uses ordinary allocations.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102936
> Fixes: f2123818ffad ("drm/i915: Move dev_priv->mm.[un]bound_list to its own lock")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-11-08 14:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 21:31 [PATCH] drm/i915: Idle the GPU before shinking everything Chris Wilson
2017-11-08 9:31 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-11-08 9:38 ` [PATCH] " Chris Wilson
2017-11-08 9:44 ` [PATCH v2] " Chris Wilson
2017-11-08 14:56 ` Joonas Lahtinen
2017-11-08 10:59 ` ✓ Fi.CI.BAT: success for drm/i915: Idle the GPU before shinking everything (rev2) Patchwork
2017-11-08 11:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-11-08 11:57 ` ✓ Fi.CI.BAT: success " Patchwork
2017-11-08 13:06 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.