* [LTP] [PATCH] lib: add include config.h in cloner.c
@ 2019-06-19 7:14 Li Wang
2019-06-19 7:19 ` Jan Stancek
0 siblings, 1 reply; 2+ messages in thread
From: Li Wang @ 2019-06-19 7:14 UTC (permalink / raw)
To: ltp
This is a follow fix for commit f6164ffc2804b2a68218, otherwise clone08
failed with ENOSYS error:
clone08.c:81: INFO: running CLONE_PARENT
clone08.c:104: BROK: CLONE_PARENT clone() failed: ENOSYS
tst_test.c:357: BROK: Reported by child (2785)
That becuase CLONE_SUPPORTS_7_ARGS macro is included in config.h, without
this header file, the ltp_clone7() will fall into ENOSYS branch.
Reported-by: Ping Fang <pifang@redhat.com>
Signed-off-by: Li Wang <liwang@redhat.com>
---
lib/cloner.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/cloner.c b/lib/cloner.c
index 8469745d0..11401f230 100644
--- a/lib/cloner.c
+++ b/lib/cloner.c
@@ -28,6 +28,7 @@
#include <stdlib.h>
#include <sched.h>
#include <stdarg.h>
+#include "config.h"
#include "tst_clone.h"
#undef clone /* we want to use clone() */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] lib: add include config.h in cloner.c
2019-06-19 7:14 [LTP] [PATCH] lib: add include config.h in cloner.c Li Wang
@ 2019-06-19 7:19 ` Jan Stancek
0 siblings, 0 replies; 2+ messages in thread
From: Jan Stancek @ 2019-06-19 7:19 UTC (permalink / raw)
To: ltp
----- Original Message -----
> This is a follow fix for commit f6164ffc2804b2a68218, otherwise clone08
> failed with ENOSYS error:
>
> clone08.c:81: INFO: running CLONE_PARENT
> clone08.c:104: BROK: CLONE_PARENT clone() failed: ENOSYS
> tst_test.c:357: BROK: Reported by child (2785)
>
> That becuase CLONE_SUPPORTS_7_ARGS macro is included in config.h, without
> this header file, the ltp_clone7() will fall into ENOSYS branch.
>
> Reported-by: Ping Fang <pifang@redhat.com>
> Signed-off-by: Li Wang <liwang@redhat.com>
Sorry about that, that include should have stayed in.
Pushed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 7:14 [LTP] [PATCH] lib: add include config.h in cloner.c Li Wang
2019-06-19 7:19 ` Jan Stancek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.