From: Elena Reshetova <elena.reshetova@intel.com> To: mingo@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, tj@kernel.org, hannes@cmpxchg.org, lizefan@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, eparis@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org, keescook@chromium.org, tglx@linutronix.de, dvhart@infradead.org, ebiederm@xmission.com, linux-mm@kvack.org, axboe@kernel.dk, Elena Reshetova <elena.reshetova@intel.com> Subject: [PATCH 04/16] sched: convert user_struct.__count to refcount_t Date: Wed, 15 Nov 2017 16:03:28 +0200 [thread overview] Message-ID: <1510754620-27088-5-git-send-email-elena.reshetova@intel.com> (raw) In-Reply-To: <1510754620-27088-1-git-send-email-elena.reshetova@intel.com> atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable user_struct.__count is used as pure reference counter. Convert it to refcount_t and fix up the operations. **Important note for maintainers: Some functions from refcount_t API defined in lib/refcount.c have different memory ordering guarantees than their atomic counterparts. The full comparison can be seen in https://lkml.org/lkml/2017/11/15/57 and it is hopefully soon in state to be merged to the documentation tree. Normally the differences should not matter since refcount_t provides enough guarantees to satisfy the refcounting use cases, but in some rare cases it might matter. Please double check that you don't have some undocumented memory guarantees for this variable usage. For the user_struct.__count it might make a difference in following places: - free_uid(): decrement in refcount_dec_and_lock() only provides RELEASE ordering, control dependency on success and will hold a spin lock on success vs. fully ordered atomic counterpart. Note there is no changes in spin lock locking here. Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> --- include/linux/sched/user.h | 5 +++-- kernel/user.c | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/linux/sched/user.h b/include/linux/sched/user.h index 0dcf4e4..2ca7cf4 100644 --- a/include/linux/sched/user.h +++ b/include/linux/sched/user.h @@ -4,6 +4,7 @@ #include <linux/uidgid.h> #include <linux/atomic.h> +#include <linux/refcount.h> struct key; @@ -11,7 +12,7 @@ struct key; * Some day this will be a full-fledged user tracking system.. */ struct user_struct { - atomic_t __count; /* reference count */ + refcount_t __count; /* reference count */ atomic_t processes; /* How many processes does this user have? */ atomic_t sigpending; /* How many pending signals does this user have? */ #ifdef CONFIG_FANOTIFY @@ -55,7 +56,7 @@ extern struct user_struct root_user; extern struct user_struct * alloc_uid(kuid_t); static inline struct user_struct *get_uid(struct user_struct *u) { - atomic_inc(&u->__count); + refcount_inc(&u->__count); return u; } extern void free_uid(struct user_struct *); diff --git a/kernel/user.c b/kernel/user.c index 9a20acc..f104474 100644 --- a/kernel/user.c +++ b/kernel/user.c @@ -96,7 +96,7 @@ static DEFINE_SPINLOCK(uidhash_lock); /* root_user.__count is 1, for init task cred */ struct user_struct root_user = { - .__count = ATOMIC_INIT(1), + .__count = REFCOUNT_INIT(1), .processes = ATOMIC_INIT(1), .sigpending = ATOMIC_INIT(0), .locked_shm = 0, @@ -122,7 +122,7 @@ static struct user_struct *uid_hash_find(kuid_t uid, struct hlist_head *hashent) hlist_for_each_entry(user, hashent, uidhash_node) { if (uid_eq(user->uid, uid)) { - atomic_inc(&user->__count); + refcount_inc(&user->__count); return user; } } @@ -169,7 +169,7 @@ void free_uid(struct user_struct *up) return; local_irq_save(flags); - if (atomic_dec_and_lock(&up->__count, &uidhash_lock)) + if (refcount_dec_and_lock(&up->__count, &uidhash_lock)) free_user(up, flags); else local_irq_restore(flags); @@ -190,7 +190,7 @@ struct user_struct *alloc_uid(kuid_t uid) goto out_unlock; new->uid = uid; - atomic_set(&new->__count, 1); + refcount_set(&new->__count, 1); /* * Before adding this, check whether we raced -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Elena Reshetova <elena.reshetova@intel.com> To: mingo@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, tj@kernel.org, hannes@cmpxchg.org, lizefan@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, eparis@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org, keescook@chromium.org, tglx@linutronix.de, dvhart@infradead.org, ebiederm@xmission.com, linux-mm@kvack.org, axboe@kernel.dk, Elena Reshetova <elena.reshetova@intel.com> Subject: [PATCH 04/16] sched: convert user_struct.__count to refcount_t Date: Wed, 15 Nov 2017 16:03:28 +0200 [thread overview] Message-ID: <1510754620-27088-5-git-send-email-elena.reshetova@intel.com> (raw) In-Reply-To: <1510754620-27088-1-git-send-email-elena.reshetova@intel.com> atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable user_struct.__count is used as pure reference counter. Convert it to refcount_t and fix up the operations. **Important note for maintainers: Some functions from refcount_t API defined in lib/refcount.c have different memory ordering guarantees than their atomic counterparts. The full comparison can be seen in https://lkml.org/lkml/2017/11/15/57 and it is hopefully soon in state to be merged to the documentation tree. Normally the differences should not matter since refcount_t provides enough guarantees to satisfy the refcounting use cases, but in some rare cases it might matter. Please double check that you don't have some undocumented memory guarantees for this variable usage. For the user_struct.__count it might make a difference in following places: - free_uid(): decrement in refcount_dec_and_lock() only provides RELEASE ordering, control dependency on success and will hold a spin lock on success vs. fully ordered atomic counterpart. Note there is no changes in spin lock locking here. Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> --- include/linux/sched/user.h | 5 +++-- kernel/user.c | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/linux/sched/user.h b/include/linux/sched/user.h index 0dcf4e4..2ca7cf4 100644 --- a/include/linux/sched/user.h +++ b/include/linux/sched/user.h @@ -4,6 +4,7 @@ #include <linux/uidgid.h> #include <linux/atomic.h> +#include <linux/refcount.h> struct key; @@ -11,7 +12,7 @@ struct key; * Some day this will be a full-fledged user tracking system.. */ struct user_struct { - atomic_t __count; /* reference count */ + refcount_t __count; /* reference count */ atomic_t processes; /* How many processes does this user have? */ atomic_t sigpending; /* How many pending signals does this user have? */ #ifdef CONFIG_FANOTIFY @@ -55,7 +56,7 @@ extern struct user_struct root_user; extern struct user_struct * alloc_uid(kuid_t); static inline struct user_struct *get_uid(struct user_struct *u) { - atomic_inc(&u->__count); + refcount_inc(&u->__count); return u; } extern void free_uid(struct user_struct *); diff --git a/kernel/user.c b/kernel/user.c index 9a20acc..f104474 100644 --- a/kernel/user.c +++ b/kernel/user.c @@ -96,7 +96,7 @@ static DEFINE_SPINLOCK(uidhash_lock); /* root_user.__count is 1, for init task cred */ struct user_struct root_user = { - .__count = ATOMIC_INIT(1), + .__count = REFCOUNT_INIT(1), .processes = ATOMIC_INIT(1), .sigpending = ATOMIC_INIT(0), .locked_shm = 0, @@ -122,7 +122,7 @@ static struct user_struct *uid_hash_find(kuid_t uid, struct hlist_head *hashent) hlist_for_each_entry(user, hashent, uidhash_node) { if (uid_eq(user->uid, uid)) { - atomic_inc(&user->__count); + refcount_inc(&user->__count); return user; } } @@ -169,7 +169,7 @@ void free_uid(struct user_struct *up) return; local_irq_save(flags); - if (atomic_dec_and_lock(&up->__count, &uidhash_lock)) + if (refcount_dec_and_lock(&up->__count, &uidhash_lock)) free_user(up, flags); else local_irq_restore(flags); @@ -190,7 +190,7 @@ struct user_struct *alloc_uid(kuid_t uid) goto out_unlock; new->uid = uid; - atomic_set(&new->__count, 1); + refcount_set(&new->__count, 1); /* * Before adding this, check whether we raced -- 2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-15 14:08 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 14:03 [PATCH 00/16] v6 kernel core pieces refcount conversions Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 01/16] futex: convert futex_pi_state.refcount to refcount_t Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 02/16] sched: convert sighand_struct.count " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 03/16] sched: convert signal_struct.sigcnt " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova [this message] 2017-11-15 14:03 ` [PATCH 04/16] sched: convert user_struct.__count " Elena Reshetova 2017-11-17 0:16 ` Kees Cook 2017-11-17 0:16 ` Kees Cook 2017-11-15 14:03 ` [PATCH 05/16] sched: convert numa_group.refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 06/16] sched/task_struct: convert task_struct.usage " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 07/16] sched/task_struct: convert task_struct.stack_refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 08/16] perf: convert perf_event_context.refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 09/16] perf/ring_buffer: convert ring_buffer.refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 10/16] perf/ring_buffer: convert ring_buffer.aux_refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 11/16] uprobes: convert uprobe.ref " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 14:03 ` [PATCH 12/16] nsproxy: convert nsproxy.count " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-15 16:36 ` Eric W. Biederman 2017-11-15 16:36 ` Eric W. Biederman 2017-11-15 16:36 ` Eric W. Biederman 2017-11-17 7:16 ` Reshetova, Elena 2017-11-17 7:16 ` Reshetova, Elena 2017-11-15 14:03 ` [PATCH 13/16] groups: convert group_info.usage " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-17 0:08 ` Kees Cook 2017-11-17 0:08 ` Kees Cook 2017-11-15 14:03 ` [PATCH 14/16] creds: convert cred.usage " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-17 0:14 ` Kees Cook 2017-11-17 0:14 ` Kees Cook 2017-11-15 14:03 ` [PATCH 15/16] kcov: convert kcov.refcount " Elena Reshetova 2017-11-15 14:03 ` Elena Reshetova 2017-11-17 0:10 ` Kees Cook 2017-11-17 0:10 ` Kees Cook 2017-11-15 14:03 ` [PATCH 16/16] bdi: convert bdi_writeback_congested.refcnt from atomic_t " Elena Reshetova 2018-12-05 1:06 ` [PATCH 00/16] v6 kernel core pieces refcount conversions Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1510754620-27088-5-git-send-email-elena.reshetova@intel.com \ --to=elena.reshetova@intel.com \ --cc=acme@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=arnd@arndb.de \ --cc=axboe@kernel.dk \ --cc=dvhart@infradead.org \ --cc=ebiederm@xmission.com \ --cc=eparis@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=hannes@cmpxchg.org \ --cc=keescook@chromium.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan@huawei.com \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.