All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] benchmarks/gem_exec_nop: fix engines selection
@ 2017-11-20 11:49 Dmitry Rogozhkin
  2017-11-20 20:11 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Rogozhkin @ 2017-11-20 11:49 UTC (permalink / raw)
  To: intel-gfx

Code on loop() function shadowed function parameter which led
to inability to try out different engines in the test: we always
loaded RCS0.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103804
Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 benchmarks/gem_exec_nop.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
index 03a0354..8eb88c1 100644
--- a/benchmarks/gem_exec_nop.c
+++ b/benchmarks/gem_exec_nop.c
@@ -106,11 +106,11 @@ static int loop(unsigned ring, int reps, int ncpus, unsigned flags)
 		return 77;
 
 	all_nengine = 0;
-	for (ring = 1; ring < 16; ring++) {
+	for (unsigned r = 1; r < 16; r++) {
 		execbuf.flags &= ~ENGINE_FLAGS;
-		execbuf.flags |= ring;
+		execbuf.flags |= r;
 		if (__gem_execbuf(fd, &execbuf) == 0)
-			all_engines[all_nengine++] = ring;
+			all_engines[all_nengine++] = r;
 	}
 
 	if (ring == -1) {
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for benchmarks/gem_exec_nop: fix engines selection
  2017-11-20 11:49 [PATCH igt] benchmarks/gem_exec_nop: fix engines selection Dmitry Rogozhkin
@ 2017-11-20 20:11 ` Patchwork
  2017-11-20 20:41 ` [PATCH igt] " Chris Wilson
  2017-11-20 21:32 ` ✗ Fi.CI.IGT: failure for " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-11-20 20:11 UTC (permalink / raw)
  To: Dmitry Rogozhkin; +Cc: intel-gfx

== Series Details ==

Series: benchmarks/gem_exec_nop: fix engines selection
URL   : https://patchwork.freedesktop.org/series/34114/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
9fb5344bab2540e3d12a7d3a94c2a3801a6fec36 tools/error_decode: Print ASCII user buffers

with latest DRM-Tip kernel build CI_DRM_3364
b2687393ce91 drm-tip: 2017y-11m-20d-18h-35m-27s UTC integration manifest

No testlist changes.

Test chamelium:
        Subgroup dp-crc-fast:
                fail       -> PASS       (fi-kbl-7500u) fdo#103163
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-gdg-551) fdo#102618

fdo#103163 https://bugs.freedesktop.org/show_bug.cgi?id=103163
fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:449s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:461s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:382s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:548s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:278s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:513s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:513s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:504s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:492s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:610s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:434s
fi-gdg-551       total:289  pass:177  dwarn:1   dfail:0   fail:2   skip:109 time:279s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:542s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:432s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:446s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:430s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:493s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:465s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:479s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:532s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:473s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:534s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:580s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:455s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:549s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:571s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:527s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:504s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:463s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:564s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:428s
Blacklisted hosts:
fi-glk-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:500s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_514/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH igt] benchmarks/gem_exec_nop: fix engines selection
  2017-11-20 11:49 [PATCH igt] benchmarks/gem_exec_nop: fix engines selection Dmitry Rogozhkin
  2017-11-20 20:11 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-20 20:41 ` Chris Wilson
  2017-11-20 21:32 ` ✗ Fi.CI.IGT: failure for " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-11-20 20:41 UTC (permalink / raw)
  To: Dmitry Rogozhkin, intel-gfx

Quoting Dmitry Rogozhkin (2017-11-20 11:49:46)
> Code on loop() function shadowed function parameter which led
> to inability to try out different engines in the test: we always
> loaded RCS0.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103804
> Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

> ---
>  benchmarks/gem_exec_nop.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
> index 03a0354..8eb88c1 100644
> --- a/benchmarks/gem_exec_nop.c
> +++ b/benchmarks/gem_exec_nop.c
> @@ -106,11 +106,11 @@ static int loop(unsigned ring, int reps, int ncpus, unsigned flags)
>                 return 77;
>  
>         all_nengine = 0;
> -       for (ring = 1; ring < 16; ring++) {
> +       for (unsigned r = 1; r < 16; r++) {
>                 execbuf.flags &= ~ENGINE_FLAGS;
> -               execbuf.flags |= ring;
> +               execbuf.flags |= r;
>                 if (__gem_execbuf(fd, &execbuf) == 0)
> -                       all_engines[all_nengine++] = ring;
> +                       all_engines[all_nengine++] = r;
>         }

Exactly what I did on Sat and forgot to send on.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* ✗ Fi.CI.IGT: failure for benchmarks/gem_exec_nop: fix engines selection
  2017-11-20 11:49 [PATCH igt] benchmarks/gem_exec_nop: fix engines selection Dmitry Rogozhkin
  2017-11-20 20:11 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-11-20 20:41 ` [PATCH igt] " Chris Wilson
@ 2017-11-20 21:32 ` Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-11-20 21:32 UTC (permalink / raw)
  To: Dmitry Rogozhkin; +Cc: intel-gfx

== Series Details ==

Series: benchmarks/gem_exec_nop: fix engines selection
URL   : https://patchwork.freedesktop.org/series/34114/
State : failure

== Summary ==

Test perf:
        Subgroup blocking:
                fail       -> PASS       (shard-hsw) fdo#102252
Test drv_module_reload:
        Subgroup basic-reload:
                pass       -> DMESG-WARN (shard-snb) fdo#102848
        Subgroup basic-reload-inject:
                pass       -> DMESG-WARN (shard-hsw) fdo#102707
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test kms_flip:
        Subgroup dpms-vs-vblank-race-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#103060
Test gem_pwrite:
        Subgroup huge-cpu-fbr:
                skip       -> PASS       (shard-snb)
Test drv_selftest:
        Subgroup mock_sanitycheck:
                pass       -> DMESG-WARN (shard-hsw) fdo#103719
Test kms_frontbuffer_tracking:
        Subgroup fbc-rgb565-draw-blt:
                pass       -> FAIL       (shard-snb)
Test kms_plane:
        Subgroup plane-panning-bottom-right-suspend-pipe-b-planes:
                pass       -> SKIP       (shard-snb)

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103719 https://bugs.freedesktop.org/show_bug.cgi?id=103719

shard-hsw        total:2585 pass:1471 dwarn:3   dfail:1   fail:11  skip:1099 time:9290s
shard-snb        total:2585 pass:1257 dwarn:2   dfail:1   fail:13  skip:1312 time:7878s
Blacklisted hosts:
shard-apl        total:2585 pass:1623 dwarn:3   dfail:1   fail:22  skip:936 time:12828s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_514/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-20 21:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-20 11:49 [PATCH igt] benchmarks/gem_exec_nop: fix engines selection Dmitry Rogozhkin
2017-11-20 20:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-20 20:41 ` [PATCH igt] " Chris Wilson
2017-11-20 21:32 ` ✗ Fi.CI.IGT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.